Bug on %2F encoded urls on IOS because file name is too long

[Tom3652]

Hi,

Thanks for the package, however your plugin doesn't work on iOS because "local file name is too long" when the URL is encoded with %2F = /

It means that File file = new File('$dir/${basename(url)}'); can't be saved on iOS because of the basename too long.

Thanks !

[mafreud]

@Tom3652 Thank you for opening an issue!
Will be fixed in hours!

• fix: Clean file name by removing query parameters in GallerySaver #12

[mafreud]

@Tom3652 Fixed!

[Tom3652]

Hey @mafreud thank you for the very quick fix !
Indeed i have forgot to mention that query parameters were also included !!

However this doesn't completely solve my main issue -> my URLs are encoded with Cloud Storage by %2F replacing the / so the basename(url) returns the entire URL except the domain 😂

Before your plugin i was doing it manually by creating a new temporary file name using Uuid().v4() to avoid any issue.
Keeping the last URL segment as file name is the correct thing to do for most users, but in my case it's problematic :/

Could you add it as a non-required parameter maybe ? I mean to provide a custom file name instead of forcing the basename(url) ?

Thanks !!

[mafreud]

@Tom3652
Hi! Thank you for the detailed information.
Then, feel free to open a PR! I will check it as soon as possible!

[Tom3652]

Hi @mafreud thanks for re-opening !
The problem is that i am forking for few years the gallery_saver and i am unable to fork this project
-> I am not sure how to proceed to make the PR in that case ?

Otherwise i can provide you the copy-paste code of the methods similar to what i am using :

///saves video from provided temp path and optional album name in gallery
  static Future<bool?> saveVideo(
    String path, {
    String? albumName,
    bool toDcim = false,
    Map<String, String>? headers,
    String customFileName = "",
  }) async {
    File? tempFile;
    if (path.isEmpty) {
      throw ArgumentError(pleaseProvidePath);
    }
    if (!isVideo(path)) {
      throw ArgumentError(fileIsNotVideo);
    }
    if (!isLocalFilePath(path)) {
      tempFile = await _downloadFile(
        path,
        isVideo: true,
        customFileName: customFileName,
        headers: headers,
      );
      path = tempFile.path;
    }
    bool? result = await _channel.invokeMethod(
      methodSaveVideo,
      <String, dynamic>{'path': path, 'albumName': albumName, 'toDcim': toDcim},
    );
    if (tempFile != null) {
      tempFile.delete();
    }
    return result;
  }

  ///saves image from provided temp path and optional album name in gallery
  static Future<bool?> saveImage(
    String path, {
    String? albumName,
    bool toDcim = false,
    Map<String, String>? headers,
    String customFileName = "",
  }) async {
    File? tempFile;
    if (path.isEmpty) {
      throw ArgumentError(pleaseProvidePath);
    }
    if (!isImage(path)) {
      throw ArgumentError(fileIsNotImage);
    }
    if (!isLocalFilePath(path)) {
      tempFile = await _downloadFile(
        path,
        isVideo: false,
        customFileName: customFileName,
        headers: headers,
      );
      path = tempFile.path;
    }

    bool? result = await _channel.invokeMethod(
      methodSaveImage,
      <String, dynamic>{'path': path, 'albumName': albumName, 'toDcim': toDcim},
    );
    if (tempFile != null) {
      tempFile.delete();
    }

    return result;
  }

  static Future<File> _downloadFile(
    String url, {
    Map<String, String>? headers,
    String customFileName = "",
    required bool isVideo,
  }) async {
    print(url);
    print(headers);
    http.Client _client = new http.Client();
    var req = await _client.get(Uri.parse(url), headers: headers);
    if (req.statusCode >= 400) {
      throw HttpException(req.statusCode.toString());
    }
    var bytes = req.bodyBytes;
    String dir = (await getTemporaryDirectory()).path;

    // Remove query parameters to get a clean file name
    String cleanUrl = url.split('?').first;
    // Create the final file name
    String finalFileName = '$dir/${basename(cleanUrl)}';
    if (customFileName.isNotEmpty) {
      finalFileName = customFileName + isVideo ? ".mp4" : ".jpg";
    }
    File file = new File(finalFileName);
    await file.writeAsBytes(bytes);
    print('File size:${await file.length()}');
    print(file.path);
    return file;
  }

Please note that i have added a required bool isVideo, but as a public plugin, forcing the extension might not always be the best idea.
However in my case and for all my apps, this is what i am using.

I admit i have additional checks for GIFs / PDFs in my projects but this is not relevant here.

What do you think ?