Merge pull request #1367 from open-circle/copilot/support-min-value-integer

Support integer type for min_value and max_value actions

Author: fabian-hiller

packages/to-json-schema/CHANGELOG.md

@@ -5,6 +5,7 @@ All notable changes to the library will be documented in this file.
 ## vX.X.X (Month DD, YYYY)
 
 - Add support for `examples` action
+- Add support for `integer` when used with `minValue` and `maxValue` actions (pull request #1367)
 - Fix conversion of `exactOptional` object properties (pull request #1220)
 - Fix conversion of `variant` to use `oneOf` instead of `anyOf` (pull request #1193)
 

packages/to-json-schema/src/converters/convertAction/convertAction.test.ts

@@ -460,6 +460,19 @@ describe('convertAction', () => {
     });
   });
 
+  test('should convert max value action for integers', () => {
+    expect(
+      convertAction(
+        { type: 'integer' },
+        v.maxValue<v.ValueInput, 100>(100),
+        undefined
+      )
+    ).toStrictEqual({
+      type: 'integer',
+      maximum: 100,
+    });
+  });
+
   test('should throw error for max value action with invalid type', () => {
     const action = v.maxValue<v.ValueInput, 3>(3);
     const error1 =
@@ -629,6 +642,19 @@ describe('convertAction', () => {
     });
   });
 
+  test('should convert min value action for integers', () => {
+    expect(
+      convertAction(
+        { type: 'integer' },
+        v.minValue<v.ValueInput, 1>(1),
+        undefined
+      )
+    ).toStrictEqual({
+      type: 'integer',
+      minimum: 1,
+    });
+  });
+
   test('should throw error for min value action with invalid type', () => {
     const action = v.minValue<v.ValueInput, 3>(3);
     const error1 =

packages/to-json-schema/src/converters/convertAction/convertAction.ts

@@ -261,7 +261,7 @@ export function convertAction(
     }
 
     case 'max_value': {
-      if (jsonSchema.type !== 'number') {
+      if (jsonSchema.type !== 'number' && jsonSchema.type !== 'integer') {
         errors = addError(
           errors,
           `The "max_value" action is not supported on type "${jsonSchema.type}".`
@@ -313,7 +313,7 @@ export function convertAction(
     }
 
     case 'min_value': {
-      if (jsonSchema.type !== 'number') {
+      if (jsonSchema.type !== 'number' && jsonSchema.type !== 'integer') {
         errors = addError(
           errors,
           `The "min_value" action is not supported on type "${jsonSchema.type}".`