Skip to content

Commit 8a3830e

Browse files
committed
review changes
1 parent 2171097 commit 8a3830e

File tree

2 files changed

+3
-12
lines changed

2 files changed

+3
-12
lines changed

interactive_ai/workflows/otx_domain/trainer/otx_v2/scripts/minio_util.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
logger = logging.getLogger("mlflow_job")
1414

1515

16-
def download_file_from_url(client: Minio, object_name: str, file_path: str) -> None:
16+
def download_file_from_url(client: Minio, bucket_name: str, object_name: str, file_path: str) -> None:
1717
"""
1818
Download file from weights url and save it in target S3 bucket
1919
"""
@@ -77,7 +77,7 @@ def download_file(bucket_name, object_name, file_path, endpoint): # noqa: ANN00
7777
print(f"File '{object_name}' downloaded successfully to '{file_path}'")
7878
except S3Error as e:
7979
if e.code == "NoSuchKey":
80-
download_file_from_url(client, object_name, file_path)
80+
download_file_from_url(client, bucket_name, object_name, file_path)
8181
else:
8282
logger.warning(f"{traceback.print_exc()}")
8383
logger.warning("Trying to get object using presigned URL")

platform/services/weights_uploader/pyproject.toml

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -60,16 +60,7 @@ dummy-variable-rgx = "^(_+|(_+[a-zA-Z0-9_]*[a-zA-Z0-9]+?))$"
6060
"ANN"]
6161

6262
# Covers BDD tests
63-
"*features*.py" = ["E741", "E402", "E501",
64-
"S",
65-
"RET",
66-
"PL",
67-
"RUF",
68-
"SIM",
69-
"D103",
70-
"ARG",
71-
"PYI024",
72-
"ANN"]
63+
"*features*.py" = ["E741", "E402", "E501"]
7364

7465
[tool.ruff.lint.isort]
7566
# First-party = self-contained packages defined within Geti

0 commit comments

Comments
 (0)