increase unit test coverage

Author: samueltaripin

image-templates/ubuntu24-x86_64-edge-raw.yml

@@ -40,6 +40,11 @@ packageRepositories:
     pkey: "<PUBLIC_KEY_URL>" # Uncomment and replace in real config
     component: "restricted"
 
+  # - codename: "localdeb"
+  #   path: "/data/os-image-composer/localdeb" # Uncomment and replace with local path
+  #   pkey: "[trusted=yes]" # Make sure to put trusted
+  #   component: "main" # Make sure to put main or leave empty
+
 systemConfig:
   name: edge
   description: edge ubuntu image with immutable rootfs

internal/config/apt_sources_test.go

@@ -387,6 +387,34 @@ func TestGenerateAptSourcesFromRepositories_NonDEBSystem(t *testing.T) {
 	}
 }
 
+func TestGenerateAptSourcesFromRepositories_PathOnlyRepo(t *testing.T) {
+	template := &ImageTemplate{
+		Target: TargetInfo{
+			OS: "ubuntu",
+		},
+		PackageRepositories: []PackageRepository{
+			{
+				Codename:  "localdeb",
+				Path:      "/data/os-image-composer/localdeb",
+				PKey:      "[trusted=yes]",
+				Component: "main",
+			},
+		},
+		SystemConfig: SystemConfig{
+			AdditionalFiles: []AdditionalFileInfo{},
+		},
+	}
+
+	err := template.GenerateAptSourcesFromRepositories()
+	if err != nil {
+		t.Fatalf("GenerateAptSourcesFromRepositories() failed for path-only repo: %v", err)
+	}
+
+	if len(template.SystemConfig.AdditionalFiles) != 0 {
+		t.Errorf("expected no apt additional files for path-only repo, got %d", len(template.SystemConfig.AdditionalFiles))
+	}
+}
+
 func TestAddUniqueAdditionalFile(t *testing.T) {
 	template := &ImageTemplate{
 		SystemConfig: SystemConfig{
@@ -618,6 +646,13 @@ func TestNormalizeRepositoryPriorities(t *testing.T) {
 	}
 }
 
+func TestNormalizeRepositoryPriorities_NilInput(t *testing.T) {
+	result := normalizeRepositoryPriorities(nil)
+	if len(result) != 0 {
+		t.Errorf("expected empty result for nil input, got len=%d", len(result))
+	}
+}
+
 func TestGetRepositoryName(t *testing.T) {
 	tests := []struct {
 		name     string

internal/config/config_test.go

@@ -3206,6 +3206,77 @@ systemConfig:
 	}
 }
 
+func TestPackageRepositoryYAMLParsingLocalPath(t *testing.T) {
+	yamlContent := `image:
+  name: test-local-repo-parsing
+  version: "1.0.0"
+
+target:
+  os: ubuntu
+  dist: ubuntu24
+  arch: x86_64
+  imageType: raw
+
+packageRepositories:
+  - codename: "localdeb"
+    path: "/data/os-image-composer/localdeb"
+    pkey: "[trusted=yes]"
+    component: "main"
+
+systemConfig:
+  name: test
+  packages:
+    - test-package
+  kernel:
+    version: "6.12"
+    cmdline: "quiet"
+`
+
+	tmpFile, err := os.CreateTemp("", "test-local-repo-*.yml")
+	if err != nil {
+		t.Fatalf("failed to create temp file: %v", err)
+	}
+	if err := tmpFile.Chmod(0600); err != nil {
+		tmpFile.Close()
+		os.Remove(tmpFile.Name())
+		return
+	}
+	defer os.Remove(tmpFile.Name())
+
+	if _, err := tmpFile.WriteString(yamlContent); err != nil {
+		t.Fatalf("failed to write temp file: %v", err)
+	}
+	tmpFile.Close()
+
+	template, err := LoadTemplate(tmpFile.Name(), false)
+	if err != nil {
+		t.Fatalf("failed to load YAML template with local package repository: %v", err)
+	}
+
+	repos := template.GetPackageRepositories()
+	if len(repos) != 1 {
+		t.Fatalf("expected 1 parsed repository, got %d", len(repos))
+	}
+
+	repo := template.GetRepositoryByCodename("localdeb")
+	if repo == nil {
+		t.Fatalf("expected to find localdeb repository")
+	}
+
+	if repo.Path != "/data/os-image-composer/localdeb" {
+		t.Errorf("expected repo path '/data/os-image-composer/localdeb', got '%s'", repo.Path)
+	}
+	if repo.PKey != "[trusted=yes]" {
+		t.Errorf("expected repo pkey '[trusted=yes]', got '%s'", repo.PKey)
+	}
+	if repo.Component != "main" {
+		t.Errorf("expected repo component 'main', got '%s'", repo.Component)
+	}
+	if repo.URL != "" {
+		t.Errorf("expected repo URL to be empty for local path repository, got '%s'", repo.URL)
+	}
+}
+
 func TestPackageRepositoriesWithDuplicateCodenames(t *testing.T) {
 	repos := []PackageRepository{
 		{Codename: "duplicate", URL: "https://first.com", PKey: "https://first.com/key.pub"},

internal/config/validate/validate_test.go

@@ -686,3 +686,45 @@ systemConfig:
 		t.Errorf("expected template with URL pkey to pass validation, but got: %v", err)
 	}
 }
+
+// TestPackageRepositoryWithLocalPath validates that a local path repository
+// with [trusted=yes] is accepted by schema validation.
+func TestPackageRepositoryWithLocalPath(t *testing.T) {
+	templateYAML := `image:
+  name: test-local-path-repo
+  version: "1.0.0"
+
+target:
+  os: ubuntu
+  dist: ubuntu24
+  arch: x86_64
+  imageType: raw
+
+packageRepositories:
+  - codename: "localdeb"
+    path: "/data/os-image-composer/localdeb"
+    pkey: "[trusted=yes]"
+    component: "main"
+
+systemConfig:
+  name: test
+  packages:
+    - test-package
+  kernel:
+    version: "6.14"
+`
+
+	var raw interface{}
+	if err := yaml.Unmarshal([]byte(templateYAML), &raw); err != nil {
+		t.Fatalf("YAML parsing error: %v", err)
+	}
+
+	dataJSON, err := json.Marshal(raw)
+	if err != nil {
+		t.Fatalf("JSON marshaling error: %v", err)
+	}
+
+	if err := ValidateImageTemplateJSON(dataJSON); err != nil {
+		t.Errorf("expected template with local path repo to pass validation, but got: %v", err)
+	}
+}

internal/provider/ubuntu/ubuntu_test.go

@@ -2194,3 +2194,30 @@ func TestBuildUserRepoListFieldMapping(t *testing.T) {
 		t.Errorf("ID: expected %q, got %q", expectedID, r.ID)
 	}
 }
+
+func TestBuildUserRepoListSkipsPathOnlyRepos(t *testing.T) {
+	input := []config.PackageRepository{
+		{
+			Codename: "localdeb",
+			Path:     "/data/os-image-composer/localdeb",
+			PKey:     "[trusted=yes]",
+		},
+		{
+			URL:      "https://example.com/repo",
+			Codename: "noble",
+			PKey:     "https://example.com/key.gpg",
+		},
+	}
+
+	result := buildUserRepoList(input)
+	if len(result) != 1 {
+		t.Fatalf("expected 1 URL-based repo, got %d", len(result))
+	}
+
+	if result[0].URL != "https://example.com/repo" {
+		t.Errorf("expected URL repo to be retained, got %q", result[0].URL)
+	}
+	if result[0].Codename != "noble" {
+		t.Errorf("expected codename %q, got %q", "noble", result[0].Codename)
+	}
+}