Skip to content

Commit 94945e4

Browse files
author
Tadeusz Matenko
committed
fix!: update ListCustomConfigsRequest field types
Update ListCustomConfigsRequest field types to match types used by other list requests. BREAKING CHANGE: `page_size` and `offset` fields change type from int32 to uint32
1 parent a114a7d commit 94945e4

8 files changed

Lines changed: 102 additions & 106 deletions

File tree

apiv2/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ GOEXTRAFLAGS := $(COMMON_GOEXTRAFLAGS)
8989

9090
generate: buf-gen generate-api ## generate protos, types, server and client
9191

92-
lint: $(OUT_DIR) generate buf-breaking validate-openapi license yamllint go-lint hadolint mdlint ## Run all lint
92+
lint: $(OUT_DIR) generate validate-openapi license yamllint go-lint hadolint mdlint ## Run all lint
9393

9494
test: $(OUT_DIR) go-test ## Run all tests
9595

apiv2/VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2.1.2-dev
1+
3.0.0

apiv2/api/openapi/openapi.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3493,7 +3493,6 @@ paths:
34933493
title: page_size
34943494
maximum: 100
34953495
minimum: 1
3496-
format: int32
34973496
description: |-
34983497
(OPTIONAL) Defines the amount of items to be contained in a single page.
34993498
Default of 20.
@@ -3504,7 +3503,6 @@ paths:
35043503
type: integer
35053504
title: offset
35063505
maximum: 10000
3507-
format: int32
35083506
description: (OPTIONAL) Index of the first item to return. This allows skipping items.
35093507
responses:
35103508
default:
@@ -7736,15 +7734,13 @@ components:
77367734
title: page_size
77377735
maximum: 100
77387736
minimum: 1
7739-
format: int32
77407737
description: |-
77417738
(OPTIONAL) Defines the amount of items to be contained in a single page.
77427739
Default of 20.
77437740
offset:
77447741
type: integer
77457742
title: offset
77467743
maximum: 10000
7747-
format: int32
77487744
description: (OPTIONAL) Index of the first item to return. This allows skipping items.
77497745
title: ListCustomConfigsRequest
77507746
additionalProperties: false

apiv2/api/proto/services/v1/services.proto

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2654,17 +2654,17 @@ message ListCustomConfigsRequest {
26542654
];
26552655
// Defines the amount of items to be contained in a single page.
26562656
// Default of 20.
2657-
int32 page_size = 3 [
2657+
uint32 page_size = 3 [
26582658
(google.api.field_behavior) = OPTIONAL,
2659-
(buf.validate.field).int32 = {
2659+
(buf.validate.field).uint32 = {
26602660
gte: 1
26612661
lte: 100
26622662
}
26632663
];
26642664
// Index of the first item to return. This allows skipping items.
2665-
int32 offset = 4 [
2665+
uint32 offset = 4 [
26662666
(google.api.field_behavior) = OPTIONAL,
2667-
(buf.validate.field).int32 = {
2667+
(buf.validate.field).uint32 = {
26682668
gte: 0
26692669
lte: 10000
26702670
}

apiv2/docs/proto.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3148,8 +3148,8 @@ Request message for the ListCustomConfigs method.
31483148
| ----- | ---- | ----- | ----------- |
31493149
| order_by | [string](#string) | | Optional comma separated list of fields to specify a sorting order. See https://google.aip.dev/132 for details. |
31503150
| filter | [string](#string) | | Optional filter to return only item of interest. See https://google.aip.dev/160 for details. |
3151-
| page_size | [int32](#int32) | | Defines the amount of items to be contained in a single page. Default of 20. |
3152-
| offset | [int32](#int32) | | Index of the first item to return. This allows skipping items. |
3151+
| page_size | [uint32](#uint32) | | Defines the amount of items to be contained in a single page. Default of 20. |
3152+
| offset | [uint32](#uint32) | | Index of the first item to return. This allows skipping items. |
31533153

31543154

31553155

apiv2/internal/pbapi/services/v1/services.pb.go

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apiv2/pkg/api/v2/edge-infrastructure-manager-openapi-server.gen.go

Lines changed: 82 additions & 82 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)