fix issues in npm audit/dependabot (#599)

Author: vigneshintel

.github/workflows/library.yml

@@ -24,7 +24,7 @@ jobs:
       - name: Cache npm dependencies
         uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238  # v6.2.0
         with:
-          node-version: 18.17.1
+          node-version: 20
           cache: "npm"
 
       - name: Install dependencies

apps/admin/public/mockServiceWorker.js

@@ -7,7 +7,7 @@
  * - Please do NOT modify this file.
  */
 
-const PACKAGE_VERSION = '2.11.3'
+const PACKAGE_VERSION = '2.12.10'
 const INTEGRITY_CHECKSUM = '4db4a41e972cec1b64cc569c66952d82'
 const IS_MOCKED_RESPONSE = Symbol('isMockedResponse')
 const activeClientIds = new Set()
@@ -205,6 +205,7 @@ async function resolveMainClient(event) {
  * @param {FetchEvent} event
  * @param {Client | undefined} client
  * @param {string} requestId
+ * @param {number} requestInterceptedAt
  * @returns {Promise<Response>}
  */
 async function getResponse(event, client, requestId, requestInterceptedAt) {

apps/app-orch/public/mockServiceWorker.js

@@ -7,7 +7,7 @@
  * - Please do NOT modify this file.
  */
 
-const PACKAGE_VERSION = '2.11.3'
+const PACKAGE_VERSION = '2.12.10'
 const INTEGRITY_CHECKSUM = '4db4a41e972cec1b64cc569c66952d82'
 const IS_MOCKED_RESPONSE = Symbol('isMockedResponse')
 const activeClientIds = new Set()
@@ -205,6 +205,7 @@ async function resolveMainClient(event) {
  * @param {FetchEvent} event
  * @param {Client | undefined} client
  * @param {string} requestId
+ * @param {number} requestInterceptedAt
  * @returns {Promise<Response>}
  */
 async function getResponse(event, client, requestId, requestInterceptedAt) {

apps/app-orch/src/components/atoms/ApplicationProfileOverrideValueComboBoxCell/ApplicationProfileOverrideValueComboBoxCell.cy.tsx

@@ -115,7 +115,7 @@ describe("<ApplicationProfileOverrideValueComboBoxCell />", () => {
     );
 
     pom.combobox.select("value1");
-    pom.root.click(0, 0); //blur or go out of focus
+    pom.combobox.root.find("input").focus().blur(); //blur or go out of focus
     const expectedValue = {
       "Model Size": "value1",
     };

apps/app-orch/src/components/atoms/ApplicationProfileParameterOverrideForm/ApplicationProfileParameterOverrideForm.cy.tsx

@@ -3,7 +3,6 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-import { cyGet } from "@orch-ui/tests";
 import { applicationOne, profileTwo } from "@orch-ui/utils";
 import { setupStore } from "../../../store";
 import { initialState } from "../../../store/reducers/setupDeployment";
@@ -100,7 +99,7 @@ describe("<ApplicationProfileParameterOverrideForm />", () => {
     );
 
     pom.selectParam(0, "value1");
-    cyGet("testHelper").click();
+    pom.table.getRows().eq(0).find(".spark-combobox input").focus().blur();
     cy.window()
       .its("store")
       .invoke("getState")
@@ -113,7 +112,7 @@ describe("<ApplicationProfileParameterOverrideForm />", () => {
       });
 
     pom.selectParam(1, "12");
-    cyGet("testHelper").click();
+    pom.table.getRows().eq(1).find(".spark-combobox input").focus().blur();
 
     const expectedValueUpdate = {
       ...expectedValue,
@@ -123,7 +122,7 @@ describe("<ApplicationProfileParameterOverrideForm />", () => {
       },
     };
     pom.typeParam(1, "value4");
-    cyGet("testHelper").click();
+    pom.table.getRows().eq(1).find(".spark-combobox input").focus().blur();
     cy.window()
       .its("store")
       .invoke("getState")

apps/app-orch/src/components/organisms/applications/ApplicationSource/ApplicationSource.cy.tsx

@@ -85,14 +85,14 @@ describe("<ApplicationSource />", () => {
     validVersions.forEach((version) => {
       it(`should accept valid versionPattern: "${version}"`, () => {
         // Type version and check for valid state
-        pom.el.chartVersionCombobox.first().clear().type(version);
+        pom.el.chartVersionCombobox.find("input").first().clear().type(version);
         cy.contains("Invalid version").should("not.exist");
       });
     });
 
     invalidVersions.forEach((version) => {
       it(`should reject invalid versionPattern: "${version}"`, () => {
-        pom.el.chartVersionCombobox.first().clear().type(version);
+        pom.el.chartVersionCombobox.find("input").first().clear().type(version);
         cy.contains("Invalid version").should("exist");
       });
     });

apps/app-orch/src/components/organisms/deployments/DeploymentUpgradeModal/DeploymentUpgradeModal.cy.tsx

@@ -10,6 +10,10 @@ import DeploymentUpgradeModal from "./DeploymentUpgradeModal";
 import { DeploymentUpgradeModalPom } from "./DeploymentUpgradeModal.pom";
 
 const pom = new DeploymentUpgradeModalPom();
+
+// Use empty appVersion so the Combobox filter (contains) shows all versions in dropdown
+const deployment = { ...deployments.deployments[0], appVersion: "" };
+
 describe("Deployments Upgrade modal", () => {
   describe("when selecting the latest version", () => {
     beforeEach(() => {
@@ -18,12 +22,12 @@ describe("Deployments Upgrade modal", () => {
         <DeploymentUpgradeModal
           isOpen
           setIsOpen={() => {}}
-          deployment={deployments.deployments[0]}
+          deployment={deployment}
         />,
       );
       pom.waitForApis();
       pom.el.selectDeploymentVersion.find("button").click();
-      cy.get("[data-key='3.0.0']").click();
+      cy.get(".spark-popover").contains("3.0.0").click();
     });
     it("upgrade", () => {
       pom.interceptApis([pom.api.postUpgradeDeploymentsList]);
@@ -62,7 +66,7 @@ describe("Deployments Upgrade modal", () => {
           setIsOpen={(isOpen) => {
             setIsOpen(isOpen);
           }}
-          deployment={deployments.deployments[0]}
+          deployment={deployment}
         />
       ) : (
         <div data-cy="isClosed">Modal is closed</div>
@@ -75,7 +79,7 @@ describe("Deployments Upgrade modal", () => {
     });
     it("should invoke the callback on cancel", () => {
       pom.el.selectDeploymentVersion.find("button").click();
-      cy.get("[data-key='3.0.0']").click();
+      cy.get(".spark-popover").contains("3.0.0").click();
       pom.el.cancelBtn.click();
       cyGet("isClosed").should("contain.text", "Modal is closed");
     });
@@ -84,7 +88,7 @@ describe("Deployments Upgrade modal", () => {
     });
     it("should upgrade a deployment and invoke the callback", () => {
       pom.el.selectDeploymentVersion.find("button").click();
-      cy.get("[data-key='3.0.0']").click();
+      cy.get(".spark-popover").contains("3.0.0").click();
 
       pom.el.upgradeBtn.should("not.have.class", "spark-button-disabled");
 

apps/app-orch/src/components/organisms/deployments/DeploymentsTable/DeploymentsTable.cy.tsx

@@ -138,17 +138,16 @@ describe("<DeploymentsTable />", () => {
       pom.interceptApis([pom.api.getDeploymentsList]);
       cy.mount(<DeploymentsTable hasPermission={false} />);
       pom.waitForApis();
-      pom.el.addDeploymentButton.should("have.attr", "aria-disabled", "true");
+      pom.el.addDeploymentButton.should("have.class", "spark-button-disabled");
     });
 
     it("enable action button when authorized", () => {
       pom.interceptApis([pom.api.getDeploymentsList]);
       cy.mount(<DeploymentsTable hasPermission={true} />);
       pom.waitForApis();
       pom.el.addDeploymentButton.should(
-        "not.have.attr",
-        "aria-disabled",
-        "true",
+        "not.have.class",
+        "spark-button-disabled",
       );
     });
 

apps/app-orch/src/components/organisms/profiles/ParameterOverridesForm/ParameterOverridesForm.cy.tsx

@@ -86,6 +86,7 @@ describe("<ParameterOverridesForm/>", () => {
     pom.root.should("not.contain.text", "Unique name required");
     pom.el.defaultValue.should("have.value", "testValue1");
     flagsPom.selectComboboxItem(3);
+    flagsPom.root.find("input").focus().blur();
     pom.el.suggestedValue.click();
     pom.el.defaultValue.should("have.value", "");
     cy.get("@onUpdateStub").should("have.been.calledWith", [

apps/app-orch/src/components/pages/SetupDeployment/SetupDeployment.cy.tsx

@@ -73,7 +73,7 @@ describe("<SetupDeployment>", () => {
         "contain.text",
         "There are no Deployment Packages currently available.",
       );
-      pom.el.nextBtn.should("have.attr", "aria-disabled", "true");
+      pom.el.nextBtn.should("have.class", "spark-button-disabled");
     });
   });
 
@@ -90,7 +90,7 @@ describe("<SetupDeployment>", () => {
     });
 
     it("should disable Next Button before package selection", () => {
-      pom.el.nextBtn.should("have.attr", "aria-disabled", "true");
+      pom.el.nextBtn.should("have.class", "spark-button-disabled");
     });
 
     it("should contain list of multiple deployment package", () => {
@@ -113,7 +113,7 @@ describe("<SetupDeployment>", () => {
         pom.selectProfile.emptyPom.el.emptySubTitle.contains(
           "No Deployment Profiles found.",
         );
-        pom.el.nextBtn.should("have.attr", "aria-disabled", "true");
+        pom.el.nextBtn.should("have.class", "spark-button-disabled");
       });
     });
 
@@ -135,7 +135,7 @@ describe("<SetupDeployment>", () => {
           .getRowBySearchText(packageWithParameterTemplates.defaultProfileName!)
           .find("[data-cy='radioButtonCy']")
           .should("be.checked");
-        pom.el.nextBtn.should("have.attr", "aria-disabled", "false");
+        pom.el.nextBtn.should("not.have.class", "spark-button-disabled");
       });
       describe("w/o override parameter", () => {
         beforeEach(() => {
@@ -268,19 +268,17 @@ describe("<SetupDeployment>", () => {
             .getRows()
             .eq(0)
             .find(".spark-combobox input")
-            .should("not.be.disabled");
-
-          pom.OverrideProfileValues.overrideTable.overrideForm.table
-            .getRows()
-            .eq(0)
-            .find(".spark-combobox input")
-            .clear();
-
-          pom.OverrideProfileValues.overrideTable.overrideForm.table
-            .getRows()
-            .eq(0)
-            .find(".spark-combobox input")
-            .type("222");
+            .should("not.be.disabled")
+            .clear()
+            .should("have.value", "")
+            .type("222", { delay: 100 })
+            .should("have.value", "222")
+            .then(($input) => {
+              // Dispatch focusout (which React delegates onBlur from) to commit value to Redux
+              $input[0].dispatchEvent(
+                new FocusEvent("focusout", { bubbles: true }),
+              );
+            });
         });
 
         it(
@@ -345,7 +343,7 @@ describe("<SetupDeployment>", () => {
             pom.interceptApis([pom.api.postDeploymentMocked]);
             pom.el.nextBtn.click().as("postClick");
             //To avoid mutliple deploy request , Check if deploy button is disabled after click
-            cy.get("@postClick").should("have.attr", "aria-disabled", "true");
+            cy.get("@postClick").should("have.class", "spark-button-disabled");
             pom.waitForApis();
 
             cy.get(`@${pom.api.postDeploymentMocked}`)