Skip to content

Commit 8d655f7

Browse files
authored
Removed parameter templates filtering using kubernetesVersion (#402)
1 parent 4e799ce commit 8d655f7

5 files changed

Lines changed: 3 additions & 44 deletions

File tree

apps/cluster-orch/src/components/atom/ClusterTemplatesDropdown/ClusterTemplatesDropdown.tsx

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -14,39 +14,24 @@ export interface ClusterTemplatesDropdownProps {
1414
onSelectionChange?: (value: string) => void;
1515
clusterTemplateName?: string;
1616
isDisabled?: boolean;
17-
kubernetesVersion?: string;
1817
}
1918
const ClusterTemplatesDropdown = ({
2019
onSelectionChange,
2120
clusterTemplateName,
2221
isDisabled,
23-
kubernetesVersion,
2422
}: ClusterTemplatesDropdownProps) => {
2523
const projectName = SharedStorage.project?.name ?? "";
26-
const templatesParam: cm.GetV2ProjectsByProjectNameTemplatesApiArg = {
27-
projectName,
28-
};
29-
if (kubernetesVersion) {
30-
// Apply the filter to the query
31-
templatesParam.filter = `kubernetesVersion=${kubernetesVersion}`;
32-
}
3324

3425
const {
3526
data: clusterTemplates,
3627
isSuccess: isTemplateSuccess,
3728
isLoading: isTemplateLoading,
3829
isError: isTemplateError,
3930
error,
40-
refetch,
41-
} = cm.useGetV2ProjectsByProjectNameTemplatesQuery(templatesParam);
31+
} = cm.useGetV2ProjectsByProjectNameTemplatesQuery({ projectName });
4232

4333
const [templateNames, setTemplateNames] = useState<string[]>();
4434

45-
// Add useEffect to trigger refetch when kubernetesVersion changes
46-
useEffect(() => {
47-
refetch();
48-
}, [kubernetesVersion, refetch]);
49-
5035
useEffect(() => {
5136
if (!clusterTemplates) return;
5237
const filteredList: string[] = [];

apps/infra/src/components/organism/ConfigureAllHosts/ConfigureAllHosts.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ const ConfigureAllHosts = () => {
5757
const {
5858
commonHostData,
5959
createCluster,
60-
kubernetesVersion,
6160
formStatus: { showAdvancedOptions },
6261
} = useAppSelector(selectHostProvisionState);
6362

@@ -118,7 +117,6 @@ const ConfigureAllHosts = () => {
118117
<Flex cols={[4]} gap="2">
119118
{ClusterTemplatesDropdownRemote && (
120119
<ClusterTemplatesDropdownRemote
121-
kubernetesVersion={kubernetesVersion}
122120
clusterTemplateName={commonHostData.clusterTemplateName}
123121
onSelectionChange={(value: string) => {
124122
dispatch(setCommonClusterTemplateName(value));

apps/infra/src/store/provisionHost.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ export interface HostProvisionState {
5050
autoProvision: boolean;
5151
createCluster: boolean;
5252
hasHostDefinitionError: boolean;
53-
kubernetesVersion: string;
5453
}
5554

5655
export const initialState: HostProvisionState = {
@@ -70,7 +69,6 @@ export const initialState: HostProvisionState = {
7069
autoProvision: true,
7170
createCluster: true,
7271
hasHostDefinitionError: false,
73-
kubernetesVersion: "",
7472
};
7573

7674
export type SiteReadWithPath = infra.SiteResourceRead & {
@@ -256,14 +254,6 @@ export const provisionHost = createSlice({
256254
const changed = state.commonHostData?.os?.name !== action.payload.name;
257255
state.commonHostData.os = action.payload;
258256

259-
const metadata = action.payload.metadata?.trim() || "{}";
260-
state.kubernetesVersion =
261-
(
262-
JSON.parse(metadata) as {
263-
"kubernetes-version"?: string;
264-
}
265-
)["kubernetes-version"] ?? "";
266-
267257
if (changed) {
268258
delete state.commonHostData["clusterTemplateName"];
269259
delete state.commonHostData["clusterTemplateVersion"];

library/utils/mocks/cluster-orch/mocks.ts

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,8 @@ const projectName = SharedStorage.project?.name;
1515

1616
const cts = new ClusterTemplatesStore();
1717
export const clusterTemplateHandlers = [
18-
http.get(`/v2/projects/${projectName}/templates`, ({ request }) => {
19-
const filter = new URL(request.url).searchParams.get("filter");
20-
let templates = cts.list();
21-
22-
if (filter) {
23-
const kubeVersion = filter.split("=").pop();
24-
templates = templates.filter((template) => {
25-
return template.kubernetesVersion === kubeVersion;
26-
});
27-
}
18+
http.get(`/v2/projects/${projectName}/templates`, () => {
19+
const templates = cts.list();
2820

2921
return HttpResponse.json(
3022
{

library/utils/mocks/infra/store/osresources.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ export const createOsResource = (
1515
profileName: string,
1616
securityFeature: infra.InstanceResourceRead["securityFeature"],
1717
osType: infra.OperatingSystemResourceRead["osType"],
18-
metadata: string,
1918
): infra.OperatingSystemResourceRead => {
2019
return {
2120
resourceId: id,
@@ -30,7 +29,6 @@ export const createOsResource = (
3029
'{"Repo":[{"Name":"libpcre2-32-0","Version":"10.42-3","Architecture":"x86_64","Distribution":"tmv3","URL":"https://www.pcre.org/","License":"BSD","Modified":"No"},{"Name":"libpcre2-16-0","Version":"10.42-3","Architecture":"x86_64","Distribution":"tmv3","URL":"https://www.pcre.org/","License":"BSD","Modified":"No"}]}',
3130
existingCves:
3231
'[{"cve_id":"CVE-2016-5180","priority":"critical","affected_packages":["fluent-bit-3.1.9-11.emt3.x86_64"]},{"cve_id":"CVE-2021-3672","priority":"medium","affected_packages":["fluent-bit-3.1.9-11.emt3.x86_64"]},{"cve_id":"CVE-2020-8277","priority":"high","affected_packages":["fluent-bit-3.1.9-11.emt3.x86_64"]},{"cve_id":"CVE-2022-4904","priority":"high","affected_packages":["fluent-bit-3.1.9-11.emt3.x86_64"]}]',
33-
metadata,
3432
};
3533
};
3634

@@ -42,7 +40,6 @@ export const osTb = createOsResource(
4240
"TbOS",
4341
"SECURITY_FEATURE_SECURE_BOOT_AND_FULL_DISK_ENCRYPTION",
4442
"OS_TYPE_IMMUTABLE",
45-
'{"kubernetes-version":"v1.28.0"}',
4643
);
4744

4845
export const osTbUpdate = createOsResource(
@@ -53,7 +50,6 @@ export const osTbUpdate = createOsResource(
5350
"TbOS",
5451
"SECURITY_FEATURE_SECURE_BOOT_AND_FULL_DISK_ENCRYPTION",
5552
"OS_TYPE_IMMUTABLE",
56-
'{"kubernetes-version":"v1.28.0"}',
5753
);
5854

5955
export const osUbuntu = createOsResource(
@@ -64,7 +60,6 @@ export const osUbuntu = createOsResource(
6460
"Ubuntu-x86_profile",
6561
"SECURITY_FEATURE_SECURE_BOOT_AND_FULL_DISK_ENCRYPTION",
6662
"OS_TYPE_IMMUTABLE",
67-
'{"kubernetes-version":"v1.30.0"}',
6863
);
6964

7065
export const osRedHat = createOsResource(
@@ -75,7 +70,6 @@ export const osRedHat = createOsResource(
7570
"Redhat-x86_profile",
7671
"SECURITY_FEATURE_NONE",
7772
"OS_TYPE_IMMUTABLE",
78-
'{"kubernetes-version":"v1.32.0"}',
7973
);
8074

8175
export class OsResourceStore extends BaseStore<

0 commit comments

Comments
 (0)