[ITEP-27177] Cluster Edit: Remove add/remove host (#89)

Author: RPG-coder-intc

apps/cluster-orch/src/components/atom/ClusterEditNodeReview/ClusterEditNodeReview.cy.tsx

@@ -23,10 +23,6 @@ describe("<ClusterEditNodeReview/>", () => {
       pom.root.should("exist");
       pom.root.should("contain.text", "No hosts available.");
     });
-    it("should click `Add Host` to call @addNode handler function for opening drawer", () => {
-      pom.el.addHostBtn.click();
-      cy.get("@addNode").should("be.called");
-    });
   });
 
   describe("when nodes/hosts are available", () => {

apps/cluster-orch/src/components/atom/ClusterEditNodeReview/ClusterEditNodeReview.tsx

@@ -5,8 +5,7 @@
 
 import { cm } from "@orch-ui/apis";
 import { TableColumn } from "@orch-ui/components";
-import { Button, Heading, Table } from "@spark-design/react";
-import { ButtonSize, ButtonVariant } from "@spark-design/tokens";
+import { Heading, Table } from "@spark-design/react";
 import { NodeTableColumns } from "../../../utils/NodeTableColumns";
 import NodeRoleDropdown from "../NodeRoleDropdown/NodeRoleDropdown";
 
@@ -21,17 +20,15 @@ interface ClusterEditNodeReviewProps {
   /** Notify any changes to node via the node dropdown */
   onNodeUpdate: (node: cm.NodeInfo, value: NodeRoles) => void;
   /** Notify click on Add Host button */
-  onAddNode: () => void;
+  onAddNode?: () => void;
   /** Notify click on Remove Host button */
-  onRemoveNode: (node: cm.NodeInfo) => void;
+  onRemoveNode?: (node: cm.NodeInfo) => void;
 }
 
 const ClusterEditNodeReview = ({
   clusterNodeList = [],
   configuredClusterNode = [],
   onNodeUpdate,
-  onAddNode,
-  onRemoveNode,
 }: ClusterEditNodeReviewProps) => {
   const cy = { "data-cy": dataCy };
 
@@ -56,17 +53,18 @@ const ClusterEditNodeReview = ({
         />
       );
     }),
-    NodeTableColumns.actions((node) => (
-      <Button
-        data-cy="removeHostBtn"
-        className="remove-host-button"
-        size={ButtonSize.Medium}
-        variant={ButtonVariant.Ghost}
-        onPress={() => onRemoveNode(node)}
-      >
-        Remove from Cluster
-      </Button>
-    )),
+    /** This is not supported by Cluster Manager (cm) Api */
+    // NodeTableColumns.actions((node) => (
+    //   <Button
+    //     data-cy="removeHostBtn"
+    //     className="remove-host-button"
+    //     size={ButtonSize.Medium}
+    //     variant={ButtonVariant.Ghost}
+    //     onPress={() => onRemoveNode(node)}
+    //   >
+    //     Remove from Cluster
+    //   </Button>
+    // )),
   ];
 
   return (
@@ -96,15 +94,16 @@ const ClusterEditNodeReview = ({
         "No hosts available."
       )}
 
-      <Button
+      {/** This is not supported by Cluster Manager (cm) Api */}
+      {/* <Button
         data-cy="addHostBtn"
         className="add-host-button"
         size={ButtonSize.Large}
         variant={ButtonVariant.Secondary}
         onPress={onAddNode}
       >
         Add Host
-      </Button>
+      </Button> */}
     </div>
   );
 };

apps/cluster-orch/src/components/organism/ClusterEdit/HostSelection/HostSelection.cy.tsx

@@ -112,19 +112,19 @@ describe("<HostSelection/>", () => {
       pom.root.should("exist");
     });
 
-    it("should open drawer", () => {
+    xit("should open drawer", () => {
       pom.clusterSelectedNodeReviewTablePom.el.addHostBtn.click();
       pom.clusterAddNodeDrawerPom.root.should("exist");
     });
 
-    it("should open and close drawer by cancel", () => {
+    xit("should open and close drawer by cancel", () => {
       pom.clusterSelectedNodeReviewTablePom.el.addHostBtn.click();
       pom.getAddNodeDrawerBase().should("have.class", "spark-drawer-show");
       pom.clusterAddNodeDrawerPom.el.cancelBtn.click();
       pom.getAddNodeDrawerBase().should("have.class", "spark-drawer-hide");
     });
 
-    it("should open and close drawer from header", () => {
+    xit("should open and close drawer from header", () => {
       pom.clusterSelectedNodeReviewTablePom.el.addHostBtn.click();
       pom.getAddNodeDrawerBase().should("have.class", "spark-drawer-show");
       pom.clusterAddNodeDrawerPom.root
@@ -133,7 +133,7 @@ describe("<HostSelection/>", () => {
       pom.getAddNodeDrawerBase().should("have.class", "spark-drawer-hide");
     });
 
-    describe("should see host selection from drawer to review table", () => {
+    xdescribe("should see host selection from drawer to review table", () => {
       beforeEach(() => {
         pom.clusterSelectedNodeReviewTablePom.el.addHostBtn.click();
         pom.clusterAddNodeDrawerPom.nodeTablePom.el.rowSelectCheckbox.click();
@@ -186,7 +186,7 @@ describe("<HostSelection/>", () => {
       });
     });
 
-    it("will remove host from cluster", () => {
+    xit("will remove host from cluster", () => {
       pom.clusterSelectedNodeReviewTablePom.table
         .getRowBySearchText("host-dh38bjw9")
         .find("[data-cy='removeHostBtn']")