Update instructions to rebuild images after changes before testing

Author: saratpoluri

.github/copilot-instructions.md

@@ -48,6 +48,13 @@ Skills are loaded on-demand based on task context to optimize token usage:
 
 Skills are detected and loaded based on file type, task keywords, and context signals. Explicitly request a skill if the auto-detection doesn't load it.
 
+### Instruction Placement Policy (Critical)
+
+- Prefer skill files under `.github/skills/` for detailed procedural rules.
+- Keep this file focused on high-level routing and references to canonical skill documents.
+- Avoid duplicating policy/checklist text across this file and skills.
+- If overlap is found, retain one canonical source and replace duplicates with a short pointer.
+
 ## Architecture Overview
 
 **Core Components:**
@@ -112,6 +119,15 @@ make -C tests geometry-unit                           # Specific test (e.g., geo
 For runtime test verification requirements, use
 `.github/skills/test-verification-gate.md`.
 
+### Containerized Test Image Freshness Gate (Critical)
+
+Use `.github/skills/test-verification-gate.md` as the single source of truth
+for image freshness checks, rebuild-before-test requirements, and retry policy
+for containerized test targets.
+
+Service-specific examples belong in each service guide (for controller, see
+`controller/Agents.md`).
+
 ## Code Patterns & Conventions
 
 **Python Packaging**:

.github/prompts/reflect.prompt.md

@@ -5,6 +5,16 @@ description: "Reflect on this conversation and suggest instruction updates"
 
 # Self-Reflection Task
 
+## Instruction Placement Rule (Critical)
+
+Before proposing documentation changes, apply this hierarchy:
+
+1. Put detailed procedural policy in the most specific skill file under `.github/skills/`.
+2. Keep `.github/copilot-instructions.md` as orchestration/entry-point guidance with pointers to skill files.
+3. Keep `Agents.md` files service-specific with concrete examples and commands, not duplicated global policy text.
+4. Do not duplicate the same checklist/policy text across global instructions and skill files.
+5. If overlap is unavoidable, keep one canonical source and replace duplicates with short references.
+
 1. Review the entire conversation history.
 2. Identify patterns where I had to correct you or clarify my intent.
 3. Suggest specific additions or modifications to the `.github/copilot-instructions.md`, files under `.github/skills` directory, `Agents.md` in each service directory and other relevant documentation to prevent these issues in the future.

.github/skills/test-verification-gate.md

@@ -17,9 +17,24 @@ Ensure runtime verification is completed and reported consistently.
 2. Prefer a root target when practical (for example, `make run_unit_tests`).
 3. Otherwise select the narrowest scoped target in `tests/Makefile`
    (for example, `make -C tests scenescape-unit`).
-4. Execute the target.
-5. If failures occur, fix and rerun the same target.
-6. Report exact command and concise pass/fail summary.
+4. If the selected target runs in a service `...-test` container image,
+   rebuild images for changed services before executing tests.
+5. Execute the target.
+6. If failures occur, confirm image freshness before code-level debugging:
+   - Rebuild the impacted service runtime and test images if not rebuilt.
+   - Rerun the same target once on fresh images.
+7. If still failing, fix and rerun the same target.
+8. Report exact command and concise pass/fail summary.
+
+## Image Freshness Mapping (Common)
+
+- Changed `controller/src/**` + `make -C tests scene-unit`:
+  - `make controller`
+  - `make -C controller test-build`
+  - then run `make -C tests scene-unit SUPASS=<password>`
+
+Apply the same pattern to other services: rebuild runtime + test image before
+running containerized test targets.
 
 ## Blocked Execution Policy
 
@@ -35,5 +50,6 @@ runtime), report:
 - Lint success only
 - Syntax-only checks
 - IDE static errors only
+- Repeated reruns against stale container images
 
 These checks are useful but do not replace runtime test execution.