Skip to content

Commit e746441

Browse files
committed
Remove redundancy
1 parent 16bfb1d commit e746441

1 file changed

Lines changed: 4 additions & 9 deletions

File tree

tests/functional/tc_sensors_send_mqtt_messages.py

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
THING_TYPES = ["person", "chair", "table", "couch"]
2828
MAX_CONTROLLER_WAIT = 30 # seconds
2929

30-
class WillOurShipGo(FunctionalTest):
30+
class SensorMqttMessageFlowTest(FunctionalTest):
3131
def __init__(self, testName, request, recordXMLAttribute):
3232
super().__init__(testName, request, recordXMLAttribute)
3333
self.sceneUID = self.params['scene_id']
@@ -353,13 +353,9 @@ def _verify_region_events(self):
353353
events = self.regionEvents.get(sensor_name, [])
354354
assert events, f"No events received for sensor {sensor_name}"
355355

356-
saw_enter_or_exit = False
357356
saw_sensor_payload = False
358357
exited_ids = set()
359358
for event in events:
360-
if event.get('entered') or event.get('exited'):
361-
saw_enter_or_exit = True
362-
363359
for entered in event.get('entered', []):
364360
entered_id = self._extract_obj_id(entered)
365361
if entered_id is not None and entered_id in exited_ids:
@@ -389,7 +385,6 @@ def _verify_region_events(self):
389385
sensors = obj.get('sensors', {})
390386
if sensor_name in sensors and sensors[sensor_name].get('values'):
391387
saw_sensor_payload = True
392-
assert saw_enter_or_exit, f"No entered/exited event data for sensor {sensor_name}"
393388
assert saw_sensor_payload, f"No sensor payload found in events for sensor {sensor_name}"
394389
return
395390

@@ -626,14 +621,14 @@ def checkForMalfunctions(self):
626621
self.recordTestResult()
627622
return
628623

629-
def test_sensor_region_events(request, record_xml_attribute):
630-
test = WillOurShipGo(TEST_NAME, request, record_xml_attribute)
624+
def test_sensor_mqtt_message_flow(request, record_xml_attribute):
625+
test = SensorMqttMessageFlowTest(TEST_NAME, request, record_xml_attribute)
631626
test.checkForMalfunctions()
632627
assert test.exitCode == 0
633628
return
634629

635630
def main():
636-
return test_sensor_region_events(None, None)
631+
return test_sensor_mqtt_message_flow(None, None)
637632

638633
if __name__ == '__main__':
639634
os._exit(main() or 0)

0 commit comments

Comments
 (0)