From e055910431ea87c42b4bccf9f9948158d0038936 Mon Sep 17 00:00:00 2001 From: "Yermolenko, Dmytro" Date: Thu, 30 Apr 2026 11:32:59 +0200 Subject: [PATCH 1/3] Change name check in serializers.py --- manager/src/manager/serializers.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/manager/src/manager/serializers.py b/manager/src/manager/serializers.py index 2734227b6..a4ab1ecae 100644 --- a/manager/src/manager/serializers.py +++ b/manager/src/manager/serializers.py @@ -560,8 +560,11 @@ def validate(self, attrs): raise serializers.ValidationError({'body': ['Request body is required.']}) name = attrs.get('name', None) - if not name or not name.strip(): - raise serializers.ValidationError({'name': ['This field is required.']}) + if not self.instance: # creation — name always required + if not name or not name.strip(): + raise serializers.ValidationError({'name': ['This field is required.']}) + elif name is not None and not name.strip(): # partial update — only validate if provided + raise serializers.ValidationError({'name': ['This field may not be blank.']}) allowed = set(self.fields.keys()) | { "mesh_translation", From c20410f5098b411a5f585658553630061600a9f2 Mon Sep 17 00:00:00 2001 From: "Yermolenko, Dmytro" Date: Thu, 30 Apr 2026 15:20:27 +0200 Subject: [PATCH 2/3] Remove comments --- manager/src/manager/serializers.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/manager/src/manager/serializers.py b/manager/src/manager/serializers.py index a4ab1ecae..085de9eb7 100644 --- a/manager/src/manager/serializers.py +++ b/manager/src/manager/serializers.py @@ -560,10 +560,10 @@ def validate(self, attrs): raise serializers.ValidationError({'body': ['Request body is required.']}) name = attrs.get('name', None) - if not self.instance: # creation — name always required + if not self.instance: if not name or not name.strip(): raise serializers.ValidationError({'name': ['This field is required.']}) - elif name is not None and not name.strip(): # partial update — only validate if provided + elif name is not None and not name.strip(): raise serializers.ValidationError({'name': ['This field may not be blank.']}) allowed = set(self.fields.keys()) | { From f7d12dbb6ef384943329664b192014aed3896f19 Mon Sep 17 00:00:00 2001 From: Sarat Poluri Date: Thu, 30 Apr 2026 17:32:29 -0700 Subject: [PATCH 3/3] Apply suggestions from code review Co-authored-by: Sarat Poluri --- manager/src/manager/serializers.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/manager/src/manager/serializers.py b/manager/src/manager/serializers.py index 085de9eb7..6f32d6030 100644 --- a/manager/src/manager/serializers.py +++ b/manager/src/manager/serializers.py @@ -564,7 +564,7 @@ def validate(self, attrs): if not name or not name.strip(): raise serializers.ValidationError({'name': ['This field is required.']}) elif name is not None and not name.strip(): - raise serializers.ValidationError({'name': ['This field may not be blank.']}) + raise serializers.ValidationError({'name': ['This field cannot be blank.']}) allowed = set(self.fields.keys()) | { "mesh_translation",