Commit 2482699
DevBot
fix(search): fix JSX onClick by removing double signal binding
Root cause: class={this.#overlayClass} in render reads a computed signal,
triggering full re-render when the overlay opens/closes. This recreates
the overlay DOM element, losing the JSX onClick handler (attached via
addEventListener in applyProps).
Fix: use static class='overlay' and rely solely on data-signal-attr='class'
for dynamic updates. This avoids full re-render and preserves the click
handler across open/close transitions.
Also reverts the connectedCallback addEventListener workaround — no longer
needed since the VNode onClick handler works correctly with this fix.
Verification:
- deno task test: 894 passed, 0 failed
- e2e chromium: 25/25 passed (search + theme + i18n)
- autoflow:push: 4/4 PASS1 parent 6ca5031 commit 2482699
1 file changed
Lines changed: 1 addition & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
215 | 215 | | |
216 | 216 | | |
217 | 217 | | |
218 | | - | |
219 | | - | |
220 | | - | |
221 | | - | |
222 | | - | |
223 | 218 | | |
224 | 219 | | |
225 | 220 | | |
| |||
369 | 364 | | |
370 | 365 | | |
371 | 366 | | |
372 | | - | |
| 367 | + | |
373 | 368 | | |
374 | 369 | | |
375 | 370 | | |
| |||
0 commit comments