feat: edit marginal costs and dispatch of biomass/biogas generators in CBA (#719)

* feat: set marginal costs for biomass and biogas generators

* feat: remove volume limits on biomass and biogas dispatch

* chore: remove checks and logs

* chore: remove logger and update docs

* refac: make simple refactoring and add comments

* feat: revert `scripts/cba/solve_cba_network.py` back to `master`

* feat: add slack to biomass/biogas dispatch `e_sum_min`

* feat: increase slack to 40%

* docs: add #719 to doc/release_notes

* refac: use `n_msv.snapshots` instead of `msv_mp.index`

Co-authored-by: Thomas Gilon <thomas.gilon@openenergytransition.org>

* feat: directly set marginal price as marginal cost, instead of adding

Co-authored-by: Thomas Gilon <thomas.gilon@openenergytransition.org>

* chore: edit comment

Co-authored-by: Thomas Gilon <thomas.gilon@openenergytransition.org>

* feat: create config option `cba.biomass_biogas_slack` for slack instead of hardcoding

* refac: filter by both carriers and volume limits

* refac: remove setting marginal cost dataframe

* chore: add type hints

* feat: add `cba.biomass_biogas_slack` config option as rule input

* fix: add back Generator type

* docs: add #719 to doc/release_notes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* chore: add details in comments of configs

* docs: change function description

* chore: edit comment for slack in config/test/config.tyndp.yaml

Co-authored-by: Thomas Gilon <thomas.gilon@openenergytransition.org>

* doc: edit link in PR description

Co-authored-by: Thomas Gilon <thomas.gilon@openenergytransition.org>

* refac: change `has_volume_limit` to bool

* feat: remove `e_sum` energy budget constraint on biomass/biogas slack

* feat: remove `cba.biomass_biogas_slack` config option

* refac: remove `get_components_with_volume_limits()` function

* docs: edit PR description in doc/release_notes

---------

Co-authored-by: Thomas Gilon <thomas.gilon@openenergytransition.org>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: 3 people

doc/release_notes.md

@@ -29,6 +29,8 @@
     - Add `include_objective_constant` and `assign_all_duals` to solving config validator.
     - Add `gurobi-simplex` as solver option.
 
+* Change dispatch of biomass and biogas generators in CBA by (a) setting the buses' marginal prices as the generators' marginal costs and (b) removing energy budget constraints ([#719](https://github.com/open-energy-transition/open-tyndp/pull/719)).
+
 **Bugfixes and Compatibility**
 
 * Rename bus for `t339` project (Tyrrhenian) from ITSI to ITVI ([#751](https://github.com/open-energy-transition/open-tyndp/pull/751)).

scripts/cba/prepare_rolling_horizon.py

@@ -135,8 +135,8 @@ def disable_volume_limits(n: pypsa.Network):
     for c in n.components[{"Generator", "Link"}]:
         has_e_sum_min = isfinite(c.static.get("e_sum_min", []))
         if has_e_sum_min.any():
-            c.static["has_volume_limit"] = 0
-            c.static.loc[has_e_sum_min, "has_volume_limit"] = 1
+            c.static["has_volume_limit"] = False
+            c.static.loc[has_e_sum_min, "has_volume_limit"] = True
             c.static.loc[has_e_sum_min, "e_sum_min"] = -inf
             c.static.loc[has_e_sum_min, "e_sum_max"] = inf
 
@@ -196,6 +196,52 @@ def apply_msv_to_network(
         n.c[c].dynamic["marginal_cost"].loc[:, s_i] = msv
 
 
+def apply_biomass_biogas_bus_marginal_prices(
+    n: pypsa.Network,
+    n_msv: pypsa.Network,
+    carriers: list[str] = ["solid biomass", "biogas"],
+    resample_method: str = "ffill",
+):
+    """
+    Set biomass/biogas buses' marginal prices as the generators' marginal costs.
+
+    For each biomass/biogas generator in the rolling horizon network:
+    use the marginal price time series of its attached bus from the MSV network and
+    set the marginal price as the generator's marginal cost.
+
+    Parameters
+    ----------
+    n : pypsa.Network
+        Target network.
+    n_msv : pypsa.Network
+        Solved MSV network containing bus marginal prices.
+    carriers : list[str], optional
+        Generator carriers to apply bus marginal prices to. Defaults to ["solid biomass", "biogas"].
+    resample_method : str, optional
+        Method for resampling MSV bus marginal prices to target resolution. Default "ffill".
+    """
+    if isinstance(carriers, str):
+        carriers = [carriers]
+
+    # Get bus marginal prices from MSV network
+    msv_mp = n_msv.buses_t.marginal_price
+
+    # Resample marginal prices if needed
+    bus_mp = (
+        msv_mp
+        if n_msv.snapshots.equals(n.snapshots)
+        else resample_msv_to_target(msv_mp, n.snapshots, method=resample_method)
+    )
+
+    # Get index of generators with target carriers
+    gen_index = n.generators.index[n.generators.carrier.isin(carriers)]
+
+    # Set marginal cost for each generator based on the marginal price of its bus
+    for g in gen_index:
+        bus = n.generators.at[g, "bus"]
+        n.generators_t.marginal_cost[g] = bus_mp[bus].reindex(n.snapshots)
+
+
 def set_initial_state_from_pf(
     n: pypsa.Network,
     n_msv: pypsa.Network,
@@ -359,6 +405,9 @@ def fix_reservoir_soc_at_boundaries(
     # Apply marginal storage value to all non-cyclic carriers
     apply_msv_to_network(n, n_msv, cyclic_carriers, resample_method)
 
+    # Add bus marginal prices to the marginal costs of the biomass/biogas generators
+    apply_biomass_biogas_bus_marginal_prices(n, n_msv, resample_method=resample_method)
+
     # Fix reservoir state of charge at window boundaries from perfect foresight
     soc_boundary_carriers = snakemake.params.get("soc_boundary_carriers", [])
     cba_solving = snakemake.config.get("cba", {}).get("solving", {})

scripts/cba/solve_cba_network.py

@@ -191,24 +191,6 @@ def optimize_with_rolling_horizon(
                     n.storage_units_t.state_of_charge.loc[snapshots[start - 1]]
                 )
 
-        # Set per-window energy budgets for volume-limited components
-        # (biomass, biogas) based on PF dispatch stored in generators_t.p
-        for c_name in ["Generator", "Link"]:
-            c = n.c[c_name]
-            if "has_volume_limit" not in c.static.columns:
-                continue
-            vol_idx = c.static.index[c.static["has_volume_limit"] == 1]
-            if vol_idx.empty:
-                continue
-            p_col = "p" if c_name == "Generator" else "p0"
-            pf_p = c.dynamic[p_col]
-            for comp in vol_idx:
-                if comp not in pf_p.columns:
-                    continue
-                window_energy = pf_p.loc[sns, comp].sum()
-                c.static.loc[comp, "e_sum_min"] = window_energy
-                c.static.loc[comp, "e_sum_max"] = window_energy
-
         status, condition = n.optimize(sns, **kwargs)  # type: ignore
 
         # If solve is successful, dispose of Model object to release license before next rolling horizon
@@ -341,7 +323,7 @@ def solve_network(
         snakemake = mock_snakemake(
             "solve_cba_network",
             run="NT",
-            cba_project="t4",
+            cba_project="t16",
             planning_horizons="2030",
             configfiles=["config/config.tyndp.yaml"],
         )