Skip to content

Fix incoherent naming convention for collect_/combine_indicators #796

Description

@tgilon

Version Checks

  • This bug exists on the latest release of Open-TYNDP.
  • This bug exists on the current master branch of Open-TYNDP.
  • This bug does NOT exist in the upstream master branch of PyPSA-Eur (therefore, the bug is likely Open-TYNDP specific).

Affected Component/Workflow

  • I have labeled this bug report with the affected component(s) using GitHub labels (e.g., SB, CBA, documentation, etc.).

Change Classification

Standard

Security & Data Risk Check

  • This bug touches or exposes confidential data.
  • This bug adds or changes external data sources, download URLs, APIs, services, credentials, or tokens.
  • This bug could affect data integrity or reproducibility of published results.

Risk Level of Fix

N/A

Bug Description

Two PR were merged almost simultaneously without proper testing. #753 introduced a new use of collect_indicators, and, in the meantime #761 refactored it to combine_indicators.

Actual Behavior

summary_benchmark_indicators uses collect_indicators

Expected Behavior

To use combine_indicators

Steps to Reproduce

snakemake -c4 cba

InputFunctionException in rule plot_summary_projects_benchmark in file "open-tyndp/rules/cba.smk", line 598:
Error:
WorkflowError:
Rule collect_indicators is not defined in this workflow.

Environment Information

No response

Metadata

Metadata

Assignees

Labels

CBACost Benefit Analysis

Type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions