Skip to content

Commit 784196c

Browse files
chore: resolve open dependabot security alerts (#252)
* chore: resolve open dependabot security alerts - vitest ^2.1.9 -> ^4.1.0 to fix UI server arbitrary file read/exec (critical, GHSA-5xrq-8626-4rwp, alerts #40 #41) - @analogjs/vitest-angular ^1.11.0 -> ^2.6.0 for vitest 4 compatibility - add ws ^8.21.0 override to avoid reintroducing GHSA-58qx-3vcg-4xpx via jsdom Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> * chore: bump angular-integration node engine to >=22 for vitest 4 Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> * chore: bump esbuild to ^0.28.1 in integration tests to resolve security alerts Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> * chore: raise angular-integration node engine floor to >=22.22.3 Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> * test(angular): flush change detection in directive else-template assertions Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> * Revert "test(angular): flush change detection in directive else-template assertions" This reverts commit 92b3257. Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> * chore: use vitest ^3.2.6 (patched) with @analogjs/vitest-angular ^1.22.5 Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> * chore: revert to vitest ^4.1.0 toolchain (3.x regresses angular directive tests) Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> * fix(angular): set feature flag value before super.ngOnChanges so else template renders Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> * chore: regenerate API client (oapi-codegen v2.7.0 -> v2.7.1) Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> * chore: bump angular to 19.2.25 and form-data to 4.0.6 for security alerts Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> * chore: resolve form-data via lockfile instead of direct dependency Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> * chore: align angular-integration node engine range with subdependency constraints Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> --------- Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
1 parent c2688a7 commit 784196c

7 files changed

Lines changed: 802 additions & 461 deletions

File tree

internal/api/client/sync_client.gen.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/cmd/testdata/success_angular.golden

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -424,9 +424,9 @@ export class DiscountPercentageFeatureFlagDirective extends FeatureFlagDirective
424424
}
425425

426426
override ngOnChanges() {
427-
super.ngOnChanges();
428-
429427
this._featureFlagValue = this.discountPercentageFeatureFlagValue;
428+
429+
super.ngOnChanges();
430430
}
431431

432432
/**
@@ -696,9 +696,9 @@ export class GreetingMessageFeatureFlagDirective extends FeatureFlagDirective<st
696696
}
697697

698698
override ngOnChanges() {
699-
super.ngOnChanges();
700-
701699
this._featureFlagValue = this.greetingMessageFeatureFlagValue;
700+
701+
super.ngOnChanges();
702702
}
703703

704704
/**
@@ -837,9 +837,9 @@ export class ThemeCustomizationFeatureFlagDirective extends FeatureFlagDirective
837837
}
838838

839839
override ngOnChanges() {
840-
super.ngOnChanges();
841-
842840
this._featureFlagValue = this.themeCustomizationFeatureFlagValue;
841+
842+
super.ngOnChanges();
843843
}
844844

845845
/**
@@ -978,9 +978,9 @@ export class UsernameMaxLengthFeatureFlagDirective extends FeatureFlagDirective<
978978
}
979979

980980
override ngOnChanges() {
981-
super.ngOnChanges();
982-
983981
this._featureFlagValue = this.usernameMaxLengthFeatureFlagValue;
982+
983+
super.ngOnChanges();
984984
}
985985

986986
/**

internal/generators/angular/angular.tmpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -221,9 +221,9 @@ export class {{ .Key | ToPascal }}FeatureFlagDirective extends FeatureFlagDirect
221221
{{- if ne $type "boolean" }}
222222

223223
override ngOnChanges() {
224-
super.ngOnChanges();
225-
226224
this._featureFlagValue = this.{{ .Key | ToCamel }}FeatureFlagValue;
225+
226+
super.ngOnChanges();
227227
}
228228
{{- end }}
229229

0 commit comments

Comments
 (0)