Skip to content

Commit 4cb89c5

Browse files
committed
Resolved gemini's comments
Signed-off-by: Marcin Olko <molko@google.com>
1 parent 6c48b96 commit 4cb89c5

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

providers/flagd/tests/evaluator/json_logic/check_progress.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
python3 check_progress.py
1010
1111
Requirements:
12-
- gbazelisk (or bazel) must be in the PATH.
12+
- gbazelisk must be in the PATH.
1313
- Must be run from a directory where gbazelisk can find the workspace.
1414
"""
1515
import subprocess

providers/flagd/tests/evaluator/json_logic/generate_tests_annotations.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ def get_args(logic, op):
7777

7878

7979
def resolve_var(data, var_name):
80-
if var_name == "":
80+
if var_name == "" or var_name is None:
8181
return data
8282
if not isinstance(data, (dict, list)):
8383
return None
@@ -98,7 +98,7 @@ def resolve_var(data, var_name):
9898
return curr
9999

100100

101-
def recursive_scan(node, data, path=""):
101+
def recursive_scan(node, data):
102102
"""
103103
Scans the logic tree recursively.
104104
Returns exclusion_reason (str) or None.
@@ -210,7 +210,7 @@ def recursive_scan(node, data, path=""):
210210
# --- Recursive Step ---
211211
for arg in args:
212212
if isinstance(arg, dict):
213-
reason = recursive_scan(arg, data, path + f"/{op}")
213+
reason = recursive_scan(arg, data)
214214
if reason:
215215
return reason
216216

0 commit comments

Comments
 (0)