Attached evaluator to provider (#50)

* Attached evaluator to provider

Signed-off-by: Marcin Olko <molko@google.com>

* Updated test

Signed-off-by: Marcin Olko <molko@google.com>

---------

Signed-off-by: Marcin Olko <molko@google.com>

Author: m-olko

providers/flagd/src/BUILD

@@ -7,6 +7,7 @@ cc_library(
     include_prefix = "flagd",
     visibility = ["//visibility:public"],
     deps = [
+        ":evaluator",
         ":flagd_configuration",
         ":sync",
         "@abseil-cpp//absl/log",

providers/flagd/src/provider.cpp

@@ -23,7 +23,9 @@ FlagdProvider::FlagdProvider(FlagdProviderConfig config)
     LOG(FATAL) << "File sync is not implemented yet!";
   }
 
-  sync_ = std::make_unique<GrpcSync>(configuration_);
+  sync_ = std::make_shared<GrpcSync>(configuration_);
+
+  evaluator_ = std::make_unique<JsonLogicEvaluator>(sync_);
 }
 
 FlagdProvider::~FlagdProvider() {
@@ -57,9 +59,13 @@ std::unique_ptr<openfeature::BoolResolutionDetails>
 FlagdProvider::GetBooleanEvaluation(const std::string_view flag,
                                     bool default_value,
                                     const openfeature::EvaluationContext& ctx) {
-  return std::make_unique<openfeature::BoolResolutionDetails>(
-      default_value, openfeature::Reason::kDefault, "default-variant",
-      openfeature::FlagMetadata(), std::nullopt, std::nullopt);
+  if (!is_ready_) {
+    return std::make_unique<openfeature::BoolResolutionDetails>(
+        default_value, openfeature::Reason::kError, "",
+        openfeature::FlagMetadata(), openfeature::ErrorCode::kProviderNotReady,
+        "Provider not ready");
+  }
+  return evaluator_->ResolveBoolean(flag, default_value, ctx);
 }
 
 }  // namespace flagd

providers/flagd/src/provider.h

@@ -8,6 +8,7 @@
 
 #include "absl/status/status.h"
 #include "flagd/configuration.h"
+#include "flagd/evaluator.h"
 #include "flagd/sync.h"
 
 namespace flagd {
@@ -31,7 +32,8 @@ class FlagdProvider : public openfeature::FeatureProvider {
 
  private:
   FlagdProviderConfig configuration_;
-  std::unique_ptr<FlagSync> sync_;
+  std::shared_ptr<FlagSync> sync_;
+  std::unique_ptr<Evaluator> evaluator_;
   std::atomic<bool> is_ready_;
 };
 

providers/flagd/tests/smoke/openfeature.cpp

@@ -13,13 +13,17 @@ TEST(FlagdProviderTest, ProviderCreation) {
   std::shared_ptr<openfeature::FeatureProvider> provider =
       std::make_shared<flagd::FlagdProvider>(config);
 
-  provider->Init({}).IgnoreError();
-
   std::unique_ptr<openfeature::BoolResolutionDetails> details =
       provider->GetBooleanEvaluation("test_flag", false, {});
 
+  // We didn't call Init, so the provider is not ready.
   auto expected_details = openfeature::BoolResolutionDetails{
-      false, openfeature::Reason::kDefault, "default-variant", {}};
+      false,
+      openfeature::Reason::kError,
+      "",
+      {},
+      openfeature::ErrorCode::kProviderNotReady,
+      "Provider not ready"};
 
   EXPECT_EQ(details->GetValue(), expected_details.GetValue());
   EXPECT_EQ(details->GetReason(), expected_details.GetReason());