Added null defaultVariant handling#79
Conversation
Signed-off-by: Marcin Olko <molko@google.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the flag evaluation mechanism to properly handle scenarios where a "defaultVariant" is either omitted or explicitly set to "null" in the flag configuration. Previously, such cases would result in an error; now, the system correctly falls back to the code-defined default value, returning "Reason::kDefault". This change aligns the flag evaluation with the OpenFeature specification's intent for default values, improving the robustness and flexibility of feature flag management. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly implements handling for missing or null defaultVariant by returning the default value. However, the implementation has a critical flaw that can cause a crash if the defaultVariant field is missing from the flag configuration. I've provided a specific code suggestion to fix this issue by using a safer method to check for the key's presence and null value. The new tests are well-written and cover the intended functionality.
Signed-off-by: Marcin Olko <molko@google.com>
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request correctly implements handling for missing or null defaultVariant by returning the code-defined default value. The core logic change in evaluator.cpp is sound, and the new tests verify this behavior. I have added a couple of suggestions for the test code: one to improve correctness with floating-point comparisons and another to reduce code duplication by using parameterized tests.
Signed-off-by: Marcin Olko <molko@google.com>
Signed-off-by: Marcin Olko <molko@google.com>
3 participants
This PR
Adds handling for explicit code defined default, by omitting defaultValue field or setting it to
null.Changes are also fixing some issues from the linter, that due to broken check were introduced earlier.
Related Issues
Fixes #78
Notes
Implementation of: https://github.com/open-feature/flagd/blob/main/docs/architecture-decisions/support-code-default.md
How to test