feat!: bump Flagsmith SDK to 8.x/9.x, drop IFlagsmithConfiguration (#644)

Signed-off-by: Adam Vialpando <adamvialpando@gmail.com>

Author: adamvialpando

src/OpenFeature.Contrib.Providers.Flagsmith/FlagsmithProvider.cs

@@ -33,8 +33,8 @@ public class FlagsmithProvider : FeatureProvider
     /// Creates new instance of <see cref="FlagsmithProvider"/>
     /// </summary>
     /// <param name="providerOptions">Open feature provider options. You can just use <see cref="FlagsmithProviderConfiguration"/> class </param>
-    /// <param name="flagsmithOptions">Flagsmith client options. You can just use <see cref="FlagsmithConfiguration"/> class</param>
-    public FlagsmithProvider(IFlagsmithProviderConfiguration providerOptions, IFlagsmithConfiguration flagsmithOptions)
+    /// <param name="flagsmithOptions">Flagsmith client options.</param>
+    public FlagsmithProvider(IFlagsmithProviderConfiguration providerOptions, FlagsmithConfiguration flagsmithOptions)
     {
         Configuration = providerOptions;
         _flagsmithClient = new FlagsmithClient(flagsmithOptions);
@@ -43,13 +43,14 @@ public FlagsmithProvider(IFlagsmithProviderConfiguration providerOptions, IFlags
     /// <summary>
     /// Creates new instance of <see cref="FlagsmithProvider"/>
     /// </summary>
-    /// <param name="flagsmithOptions">Flagsmith client options. You can just use <see cref="FlagsmithConfiguration"/> class</param>
+    /// <param name="flagsmithOptions">Flagsmith client options.</param>
     /// <param name="providerOptions">Open feature provider options. You can just use <see cref="FlagsmithProviderConfiguration"/> class </param>
     /// <param name="httpClient">Http client that will be used for flagsmith requests. You also can use it to register <see cref="FeatureProvider"/> as Typed HttpClient with <see cref="FeatureProvider"> as abstraction</see></param>
-    public FlagsmithProvider(IFlagsmithProviderConfiguration providerOptions, IFlagsmithConfiguration flagsmithOptions, HttpClient httpClient)
+    public FlagsmithProvider(IFlagsmithProviderConfiguration providerOptions, FlagsmithConfiguration flagsmithOptions, HttpClient httpClient)
     {
         Configuration = providerOptions;
-        _flagsmithClient = new FlagsmithClient(flagsmithOptions, httpClient);
+        flagsmithOptions.HttpClient = httpClient;
+        _flagsmithClient = new FlagsmithClient(flagsmithOptions);
     }
 
 

src/OpenFeature.Contrib.Providers.Flagsmith/OpenFeature.Contrib.Providers.Flagsmith.csproj

@@ -19,7 +19,7 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Flagsmith" Version="5.4.3" />
+    <PackageReference Include="Flagsmith" Version="[8.0,10.0)" />
   </ItemGroup>
 
   <ItemGroup>

src/OpenFeature.Contrib.Providers.Flagsmith/README.md

@@ -57,10 +57,10 @@ var providerConfig = new FlagsmithProviderConfiguration();
 // Flagsmith client configuration
 var flagsmithConfig = new FlagsmithConfiguration
 {
-    ApiUrl = "https://edge.api.flagsmith.com/api/v1/",
+    ApiUri = new Uri("https://edge.api.flagsmith.com/api/v1/"),
     EnvironmentKey = "",
-    EnableClientSideEvaluation = false,
-    EnvironmentRefreshIntervalSeconds = 60,
+    EnableLocalEvaluation = false,
+    EnvironmentRefreshInterval = TimeSpan.FromSeconds(60),
     EnableAnalytics = false,
     Retries = 1,
 };

test/OpenFeature.Contrib.Providers.Flagsmith.Test/FlagsmithProviderTest.cs

@@ -16,10 +16,10 @@ public class UnitTestFlagsmithProvider
 {
     private static FlagsmithConfiguration GetDefaultFlagsmithConfiguration() => new()
     {
-        ApiUrl = "https://edge.api.flagsmith.com/api/v1/",
+        ApiUri = new Uri("https://edge.api.flagsmith.com/api/v1/"),
         EnvironmentKey = "some-key",
-        EnableClientSideEvaluation = false,
-        EnvironmentRefreshIntervalSeconds = 60,
+        EnableLocalEvaluation = false,
+        EnvironmentRefreshInterval = TimeSpan.FromSeconds(60),
         EnableAnalytics = false,
         Retries = 1
     };
@@ -48,12 +48,13 @@ public void CreateFlagmithProvider_WithValidCredentialsAndCustomHttpClient_Creat
         var config = GetDefaultFlagsmithConfiguration();
         var providerConfig = GetDefaultFlagsmithProviderConfigurationConfiguration();
         using var httpClient = new HttpClient();
+
         // Act
         var flagsmithProvider = new FlagsmithProvider(providerConfig, config, httpClient);
 
-
         // Assert
         Assert.NotNull(flagsmithProvider._flagsmithClient);
+        Assert.Same(httpClient, config.HttpClient);
     }
 
     [Fact]