Address PR comments

Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>

Author: kylejuliandev

src/OpenFeature.Contrib.Providers.Flagd/FlagdConfig.cs

@@ -368,8 +368,8 @@ private void PreBuild()
         }
     }
 
-    private static int TryGetEnvironmentVariableOrDefault(string enviromentVariable, int defaultPort)
+    private static int TryGetEnvironmentVariableOrDefault(string environmentVariable, int defaultPort)
     {
-        return int.TryParse(Environment.GetEnvironmentVariable(enviromentVariable), out var p) ? p : defaultPort;
+        return int.TryParse(Environment.GetEnvironmentVariable(environmentVariable), out var p) ? p : defaultPort;
     }
 }

src/OpenFeature.Contrib.Providers.Flagd/README.md

@@ -161,7 +161,7 @@ The URI of the flagd server to which the `flagd Provider` connects to can either
 | Option name                  | Environment variable name      | Type    | Default   | Values          |
 | ---------------------------- | ------------------------------ | ------- | --------- | --------------- |
 | host                         | FLAGD_HOST                     | string  | localhost |                 |
-| port                         | FLAGD_PORT (FLAGD_SYNC_PORT when resolver is in-process)   | number  | 8013 (8015 when resolver in in-process)      |                 |
+| port                         | FLAGD_PORT (FLAGD_SYNC_PORT when resolver is in-process)   | number  | 8013 (8015 when resolver is in-process)      |                 |
 | tls                          | FLAGD_TLS                      | boolean | false     |                 |
 | tls certPath                 | FLAGD_SERVER_CERT_PATH         | string  |           |                 |
 | unix socket path             | FLAGD_SOCKET_PATH              | string  |           |                 |

test/OpenFeature.Contrib.Providers.Flagd.Test/FlagdConfigTest.cs

@@ -241,8 +241,8 @@ public void SyncPortOverridesPort()
         finally
         {
             // Cleanup
-            Environment.SetEnvironmentVariable(FlagdConfig.EnvVarPort, "");
-            Environment.SetEnvironmentVariable(FlagdConfig.EnvVarSyncPort, "");
+            Environment.SetEnvironmentVariable(FlagdConfig.EnvVarPort, null);
+            Environment.SetEnvironmentVariable(FlagdConfig.EnvVarSyncPort, null);
         }
     }
 
@@ -265,7 +265,7 @@ public void FallsBackToLegacyPort()
         finally
         {
             // Cleanup
-            Environment.SetEnvironmentVariable(FlagdConfig.EnvVarPort, "");
+            Environment.SetEnvironmentVariable(FlagdConfig.EnvVarPort, null);
         }
     }
 
@@ -288,8 +288,8 @@ public void DoesNotUseSyncPortForRpcResolver()
         finally
         {
             // Cleanup
-            Environment.SetEnvironmentVariable(FlagdConfig.EnvVarPort, "");
-            Environment.SetEnvironmentVariable(FlagdConfig.EnvVarSyncPort, "");
+            Environment.SetEnvironmentVariable(FlagdConfig.EnvVarPort, null);
+            Environment.SetEnvironmentVariable(FlagdConfig.EnvVarSyncPort, null);
         }
     }
 }