Skip to content

Commit 32a5ba7

Browse files
feat: introduce provider_id to sync service FetchAllFlags (#87)
<!-- Please use this template for your pull request. --> <!-- Please use the sections that you need and delete other sections --> ## This PR <!-- add the description of the PR here --> - introduces the `provider_id` field to the `FetchAllFlagsRequest` message ### Related Issues <!-- add here the GitHub issue that this PR resolves if applicable --> ### Notes <!-- any additional notes for this PR --> ### Follow-up Tasks <!-- anything that is related to this PR but not done here should be noted under this section --> <!-- if there is a need for a new issue, please link it here --> ### How to test <!-- if applicable, add testing instructions under this section --> --------- Signed-off-by: James Milligan <james@omnant.co.uk>
1 parent 7fe0e32 commit 32a5ba7

1 file changed

Lines changed: 7 additions & 2 deletions

File tree

protobuf/sync/v1/sync_service.proto

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ option go_package = "flagd/grpcsync";
66

77
// SyncFlagsRequest is the request initiating the sever-streaming rpc. Flagd sends this request, acting as the client
88
message SyncFlagsRequest {
9-
// Optional: A unique identifier for flagd provider (grpc client) initiating the request. The server implementations
9+
// Optional: A unique identifier for flagd provider (grpc client) initiating the request. The server implementations
1010
// can utilize this identifier to aggregate flag configurations and stream them to a specific client. This identifier
1111
// is intended to be optional. However server implementation may enforce it.
1212
string provider_id = 1;
@@ -47,7 +47,12 @@ message SyncFlagsResponse {
4747
}
4848

4949
// FetchAllFlagsRequest is the request to fetch all flags. Flagd sends this request as the client in order to resync its internal state
50-
message FetchAllFlagsRequest {}
50+
message FetchAllFlagsRequest {
51+
// Optional: A unique identifier for flagd provider (grpc client) initiating the request. The server implementations
52+
// can utilize this identifier to aggregate flag configurations and stream them to a specific client. This identifier
53+
// is intended to be optional. However server implementation may enforce it.
54+
string provider_id = 1;
55+
}
5156

5257
// FetchAllFlagsResponse is the server response containing feature flag configurations
5358
message FetchAllFlagsResponse {

0 commit comments

Comments
 (0)