revert: drop v1/legacy bulk disabled-handling

v1 (and the legacy/Old service) use proto3 scalar fields that can't
omit Value on the wire. Single-flag already emits zero values alongside
reason=DISABLED; making bulk specially-omit Value via the oneof was
inconsistent with the single-flag behavior and added complexity.

Just let bulk include disabled flags with zero values + reason=DISABLED,
matching single-flag. v2 and OFREP retain proper omission (they have
the means to omit).

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>

Author: toddbaert

flagd/pkg/service/flag-evaluation/flag_evaluator.go

@@ -90,13 +90,6 @@ func (s *OldFlagEvaluationService) ResolveAll(
 		// register the impression and reason for each flag evaluated
 		s.metrics.RecordEvaluation(ctx, value.Error, value.Reason, value.Variant, value.FlagKey)
 
-		if value.Reason == model.DisabledReason {
-			res.Flags[value.FlagKey] = &schemaV1.AnyFlag{
-				Reason: value.Reason,
-			}
-			continue
-		}
-
 		switch v := value.Value.(type) {
 		case bool:
 			res.Flags[value.FlagKey] = &schemaV1.AnyFlag{

flagd/pkg/service/flag-evaluation/flag_evaluator_v1.go

@@ -10,7 +10,6 @@ import (
 	"connectrpc.com/connect"
 	"github.com/open-feature/flagd/core/pkg/evaluator"
 	"github.com/open-feature/flagd/core/pkg/logger"
-	"github.com/open-feature/flagd/core/pkg/model"
 	"github.com/open-feature/flagd/core/pkg/service"
 	"github.com/open-feature/flagd/core/pkg/store"
 	"github.com/open-feature/flagd/core/pkg/telemetry"
@@ -92,18 +91,6 @@ func (s *FlagEvaluationService) ResolveAll(
 	for _, resolved := range resolutions {
 		// register the impression and reason for each flag evaluated
 		s.metrics.RecordEvaluation(ctx, resolved.Error, resolved.Reason, resolved.Variant, resolved.FlagKey)
-		if resolved.Reason == model.DisabledReason {
-			metadata, err := structpb.NewStruct(resolved.Metadata)
-			if err != nil {
-				s.logger.WarnWithID(reqID, fmt.Sprintf("error resolving all flags: %v", err))
-				return nil, fmt.Errorf("error resolving flags. Tracking ID: %s", reqID)
-			}
-			res.Flags[resolved.FlagKey] = &evalV1.AnyFlag{
-				Reason:   resolved.Reason,
-				Metadata: metadata,
-			}
-			continue
-		}
 		switch v := resolved.Value.(type) {
 		case bool:
 			res.Flags[resolved.FlagKey] = &evalV1.AnyFlag{

flagd/pkg/service/flag-evaluation/flag_evaluator_v1_test.go

@@ -19,37 +19,6 @@ import (
 	"google.golang.org/protobuf/types/known/structpb"
 )
 
-func TestConnectServiceV2_ResolveAll_DisabledFlagHasMetadata(t *testing.T) {
-	ctrl := gomock.NewController(t)
-	eval := mock.NewMockIEvaluator(ctrl)
-	eval.EXPECT().ResolveAllValues(gomock.Any(), gomock.Any(), gomock.Any()).Return(
-		[]evaluator.AnyValue{
-			{
-				Reason:  model.DisabledReason,
-				FlagKey: "disabled-flag",
-				Metadata: model.Metadata{
-					"scope": "my-app",
-				},
-			},
-		},
-		model.Metadata{},
-		nil,
-	).AnyTimes()
-
-	metrics, _ := getMetricReader()
-	s := NewFlagEvaluationService(logger.NewLogger(nil, false), eval, &eventingConfiguration{}, metrics, nil, nil, 0)
-
-	got, err := s.ResolveAll(context.Background(), connect.NewRequest(&evalV1.ResolveAllRequest{}))
-	require.NoError(t, err)
-
-	flag, ok := got.Msg.Flags["disabled-flag"]
-	require.True(t, ok, "disabled flag missing from ResolveAll response")
-	require.Equal(t, model.DisabledReason, flag.Reason)
-	require.Nil(t, flag.Value, "disabled flag must not carry a value")
-	require.NotNil(t, flag.Metadata, "disabled flag must propagate per-flag metadata")
-	require.Equal(t, "my-app", flag.Metadata.Fields["scope"].GetStringValue())
-}
-
 func TestConnectServiceV2_ResolveAll(t *testing.T) {
 	tests := map[string]struct {
 		req         *evalV1.ResolveAllRequest