teams: smoother voices native list adapting (fixes #13007) (#12954)

Author: dogi

app/build.gradle

@@ -12,8 +12,8 @@ android {
         applicationId "org.ole.planet.myplanet"
         minSdk = 26
         targetSdk = 36
-        versionCode = 5331
-        versionName = "0.53.31"
+        versionCode = 5332
+        versionName = "0.53.32"
         ndkVersion = '26.3.11579264'
         vectorDrawables.useSupportLibrary = true
     }

app/src/main/java/org/ole/planet/myplanet/base/BaseVoicesFragment.kt

@@ -69,13 +69,13 @@ abstract class BaseVoicesFragment : BaseContainerFragment(), OnNewsItemClickList
             if (result.resultCode == Activity.RESULT_OK) {
                 val newsId = result.data?.getStringExtra("newsId")
                 newsId.let { adapterNews?.updateReplyBadge(it) }
-                adapterNews?.refreshCurrentItems()
+                adapterNews?.submitList(adapterNews?.currentList?.toList())
             }
         }
     }
 
     override fun onDataChanged() {
-        adapterNews?.refreshCurrentItems()
+        adapterNews?.submitList(adapterNews?.currentList?.toList())
     }
 
     override fun onReplyPosted(newsId: String?) {

app/src/main/java/org/ole/planet/myplanet/ui/teams/voices/TeamsVoicesFragment.kt

@@ -240,15 +240,15 @@ class TeamsVoicesFragment : BaseTeamFragment() {
             adapterNews?.sharedPrefManager = sharedPrefManager
             adapterNews?.setListener(this)
             if (!isMemberFlow.value) adapterNews?.setNonTeamMember(true)
-            realmNewsList?.let { adapterNews?.updateList(it) }
+            realmNewsList?.let { adapterNews?.submitList(it) }
             binding.rvDiscussion.adapter = adapterNews
             adapterNews?.let {
                 showNoData(binding.tvNodata, it.itemCount, "discussions")
             }
         } else {
             (existingAdapter as? VoicesAdapter)?.let { adapter ->
                 realmNewsList?.let {
-                    adapter.updateList(it)
+                    adapter.submitList(it)
                     showNoData(binding.tvNodata, adapter.itemCount, "discussions")
                 }
             }

app/src/main/java/org/ole/planet/myplanet/ui/voices/ReplyActivity.kt

@@ -165,7 +165,7 @@ open class ReplyActivity : AppCompatActivity(), OnNewsItemClickListener {
             } else {
                 newsAdapter.updateParentNews(news)
             }
-            newsAdapter.updateList(list)
+            newsAdapter.submitList(list)
         }
     }
 

app/src/main/java/org/ole/planet/myplanet/ui/voices/VoicesAdapter.kt

@@ -137,17 +137,6 @@ class VoicesAdapter(
         this.imageList = imageList
     }
 
-    fun addItem(news: RealmNews?) {
-        val currentList = currentList.toMutableList()
-        currentList.add(0, news)
-        submitListSafely(currentList) {
-            recyclerView?.post {
-                recyclerView?.scrollToPosition(0)
-                recyclerView?.smoothScrollToPosition(0)
-            }
-        }
-    }
-
     fun setFromLogin(fromLogin: Boolean) {
         this.fromLogin = fromLogin
     }
@@ -327,7 +316,7 @@ class VoicesAdapter(
                             newsToDelete?.id?.let { id ->
                                 deletePostFn(id) {
                                     val newList = snapshotList.toMutableList().apply { removeAt(adjustedPos) }
-                                    submitListSafely(newList)
+                                    submitList(newList)
                                     parentNews?.id?.let { pid ->
                                         val current = replyCountCache[pid]
                                         replyCountCache[pid] = if (current != null) maxOf(0, current - 1) else 0
@@ -426,10 +415,6 @@ class VoicesAdapter(
         return null
     }
 
-    fun updateList(newList: List<RealmNews?>) {
-        submitListSafely(newList)
-    }
-
     fun updateParentNews(news: RealmNews?) {
         val contentChanged = parentNews?.message != news?.message ||
             parentNews?.isEdited != news?.isEdited
@@ -438,10 +423,6 @@ class VoicesAdapter(
         if (contentChanged) notifyItemChanged(0)
     }
 
-    fun refreshCurrentItems() {
-        submitListSafely(currentList.toList())
-    }
-
     private fun parseViewIn(viewIn: String?): JsonArray? {
         if (TextUtils.isEmpty(viewIn)) return null
         return try {
@@ -514,11 +495,6 @@ class VoicesAdapter(
         list?.forEach { preParseNews(it) }
         super.submitList(list, commitCallback)
     }
-
-    private fun submitListSafely(list: List<RealmNews?>, commitCallback: Runnable? = null) {
-        submitList(list, commitCallback)
-    }
-
     private fun setMemberClickListeners(holder: VoicesViewHolder, userModel: RealmUser?, currentLeader: RealmUser?) {
         if (!fromLogin) {
             holder.binding.imgUser.setOnClickListener {

app/src/main/java/org/ole/planet/myplanet/ui/voices/VoicesFragment.kt

@@ -267,10 +267,10 @@ class VoicesFragment : BaseVoicesFragment() {
             adapterNews?.setFromLogin(requireArguments().getBoolean("fromLogin"))
             adapterNews?.setListener(this)
             adapterNews?.registerAdapterDataObserver(observer)
-            adapterNews?.updateList(sortedList)
+            adapterNews?.submitList(sortedList)
             binding.rvNews.adapter = adapterNews
         } else {
-            (binding.rvNews.adapter as? VoicesAdapter)?.updateList(list)
+            (binding.rvNews.adapter as? VoicesAdapter)?.submitList(list)
         }
         adapterNews?.let { showNoData(binding.tvMessage, it.itemCount, currentEmptyStateSource) }
     }