🧪 [testing] Address PR feedback for VoicesLabelManager.formatLabelValue tests

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Author: dogi

app/src/main/java/org/ole/planet/myplanet/services/VoicesLabelManager.kt

@@ -127,10 +127,11 @@ class VoicesLabelManager(
     }
 
     companion object {
+        // internal visibility is required for testing
         internal fun formatLabelValue(raw: String): String {
             val cleaned = raw.replace("_", " ").replace("-", " ")
             if (cleaned.isBlank()) {
-                return raw
+                return ""
             }
             return cleaned
                 .trim()

app/src/main/java/org/ole/planet/myplanet/services/VoicesLabelManager.kt.orig

@@ -0,0 +1,146 @@
+package org.ole.planet.myplanet.services
+
+import android.content.Context
+import android.view.View
+import fisk.chipcloud.ChipCloud
+import io.realm.RealmList
+import java.util.Locale
+import kotlinx.coroutines.CoroutineScope
+import kotlinx.coroutines.Dispatchers
+import kotlinx.coroutines.launch
+import kotlinx.coroutines.withContext
+import org.ole.planet.myplanet.R
+import org.ole.planet.myplanet.databinding.RowNewsBinding
+import org.ole.planet.myplanet.model.RealmNews
+import org.ole.planet.myplanet.repository.VoicesRepository
+import org.ole.planet.myplanet.utils.Constants
+import org.ole.planet.myplanet.utils.Utilities
+
+class VoicesLabelManager(
+    private val context: Context,
+    private val voicesRepository: VoicesRepository,
+    private val scope: CoroutineScope
+) {
+    fun setupAddLabelMenu(binding: RowNewsBinding, voice: RealmNews?, canManageLabels: Boolean) {
+        binding.btnAddLabel.setOnClickListener(null)
+        binding.btnAddLabel.isEnabled = canManageLabels
+        if (!canManageLabels) {
+            return
+        }
+
+        binding.btnAddLabel.setOnClickListener {
+            val usedLabels = voice?.labels?.toSet() ?: emptySet()
+            val availableLabels = Constants.LABELS.filterValues { it !in usedLabels }
+
+            val wrapper = androidx.appcompat.view.ContextThemeWrapper(context, R.style.CustomPopupMenu)
+            val menu = android.widget.PopupMenu(wrapper, binding.btnAddLabel)
+            availableLabels.keys.forEach { labelName ->
+                menu.menu.add(labelName)
+            }
+            menu.setOnMenuItemClickListener { menuItem ->
+                val selectedLabel = Constants.LABELS[menuItem.title]
+                val voiceId = voice?.id
+                if (selectedLabel != null && voiceId != null && voice.labels?.contains(selectedLabel) != true) {
+                    scope.launch {
+                        try {
+                            voicesRepository.addLabel(voiceId, selectedLabel)
+                            withContext(Dispatchers.Main) {
+                                if (voice.labels == null) {
+                                    voice.labels = RealmList()
+                                }
+                                voice.labels?.add(selectedLabel)
+                                Utilities.toast(context, context.getString(R.string.label_added))
+                                showChips(binding, voice, canManageLabels)
+                            }
+                        } catch (e: Exception) {
+                            e.printStackTrace()
+                        }
+                    }
+                }
+                true
+            }
+            menu.show()
+        }
+    }
+
+    fun showChips(binding: RowNewsBinding, voice: RealmNews, canManageLabels: Boolean) {
+        binding.fbChips.removeAllViews()
+
+        for (label in voice.labels ?: emptyList()) {
+            val chipConfig = Utilities.getCloudConfig().apply {
+                selectMode(if (canManageLabels) ChipCloud.SelectMode.close else ChipCloud.SelectMode.none)
+            }
+
+            val chipCloud = ChipCloud(context, binding.fbChips, chipConfig)
+            chipCloud.addChip(getLabel(label))
+
+            if (canManageLabels) {
+                chipCloud.setDeleteListener { _: Int, labelText: String? ->
+                    val selectedLabel = when {
+                        labelText == null -> null
+                        Constants.LABELS.containsKey(labelText) -> Constants.LABELS[labelText]
+                        else -> voice.labels?.firstOrNull { getLabel(it) == labelText }
+                    }
+                    val voiceId = voice.id
+                    if (selectedLabel != null && voiceId != null) {
+                        scope.launch {
+                            try {
+                                voicesRepository.removeLabel(voiceId, selectedLabel)
+                                withContext(Dispatchers.Main) {
+                                    voice.labels?.remove(selectedLabel)
+                                    showChips(binding, voice, canManageLabels)
+                                }
+                            } catch (e: Exception) {
+                                e.printStackTrace()
+                            }
+                        }
+                    }
+                }
+            }
+        }
+        updateAddLabelVisibility(binding, voice, canManageLabels)
+    }
+
+    private fun updateAddLabelVisibility(
+        binding: RowNewsBinding,
+        voice: RealmNews?,
+        canManageLabels: Boolean,
+    ) {
+        if (!canManageLabels) {
+            binding.btnAddLabel.visibility = View.GONE
+            return
+        }
+
+        val usedLabels = voice?.labels?.toSet() ?: emptySet()
+        val labels = Constants.LABELS.values.toSet()
+        binding.btnAddLabel.visibility =
+            if (usedLabels.containsAll(labels)) View.GONE else View.VISIBLE
+    }
+
+    private fun getLabel(s: String): String {
+        for (key in Constants.LABELS.keys) {
+            if (s == Constants.LABELS[key]) {
+                return key
+            }
+        }
+        return formatLabelValue(s)
+    }
+
+    companion object {
+        internal fun formatLabelValue(raw: String): String {
+            val cleaned = raw.replace("_", " ").replace("-", " ")
+            if (cleaned.isBlank()) {
+                return raw
+            }
+            return cleaned
+                .trim()
+                .split(whitespaceRegex)
+                .joinToString(" ") { part ->
+                    part.lowercase(Locale.getDefault()).replaceFirstChar { ch ->
+                        if (ch.isLowerCase()) ch.titlecase(Locale.getDefault()) else ch.toString()
+                    }
+                }
+        }
+        private val whitespaceRegex by lazy { Regex("\\s+") }
+    }
+}

app/src/test/java/org/ole/planet/myplanet/services/VoicesLabelManagerTest.kt

@@ -5,6 +5,12 @@ import org.junit.Test
 
 class VoicesLabelManagerTest {
 
+    @Test
+    fun testFormatLabelValue_singleWord() {
+        assertEquals("Hello", VoicesLabelManager.formatLabelValue("hello"))
+        assertEquals("Hello", VoicesLabelManager.formatLabelValue("HELLO"))
+    }
+
     @Test
     fun testFormatLabelValue_normalizesCase() {
         assertEquals("Hello World", VoicesLabelManager.formatLabelValue("HELLO WORLD"))
@@ -27,11 +33,11 @@ class VoicesLabelManagerTest {
     }
 
     @Test
-    fun testFormatLabelValue_handlesBlankStrings() {
+    fun testFormatLabelValue_handlesNonAlphaOnlyInputs() {
         assertEquals("", VoicesLabelManager.formatLabelValue(""))
-        assertEquals("   ", VoicesLabelManager.formatLabelValue("   "))
-        assertEquals(" _ ", VoicesLabelManager.formatLabelValue(" _ "))
-        assertEquals("-", VoicesLabelManager.formatLabelValue("-"))
-        assertEquals("_-", VoicesLabelManager.formatLabelValue("_-"))
+        assertEquals("", VoicesLabelManager.formatLabelValue("   "))
+        assertEquals("", VoicesLabelManager.formatLabelValue(" _ "))
+        assertEquals("", VoicesLabelManager.formatLabelValue("-"))
+        assertEquals("", VoicesLabelManager.formatLabelValue("_-"))
     }
 }