teams: smoother voices repository uploading (fixes #12925) (#12874)

Author: dogi

app/build.gradle

@@ -12,8 +12,8 @@ android {
         applicationId "org.ole.planet.myplanet"
         minSdk = 26
         targetSdk = 36
-        versionCode = 5295
-        versionName = "0.52.95"
+        versionCode = 5296
+        versionName = "0.52.96"
         ndkVersion = '26.3.11579264'
         vectorDrawables.useSupportLibrary = true
     }

app/src/main/java/org/ole/planet/myplanet/repository/VoicesRepository.kt

@@ -23,7 +23,7 @@ data class NewsUpdateData(
 )
 
 interface VoicesRepository {
-    suspend fun getNewsForUpload(serializeNews: (RealmNews) -> JsonObject): List<NewsUploadData>
+    suspend fun getNewsForUpload(): List<NewsUploadData>
     suspend fun markNewsUploaded(updates: List<NewsUpdateData>)
     suspend fun getLibraryResource(resourceId: String): RealmMyLibrary?
     suspend fun getCommunityNews(userIdentifier: String): Flow<List<RealmNews>>
@@ -50,6 +50,5 @@ interface VoicesRepository {
     suspend fun getPlanetNewsMessages(planetCode: String?): List<RealmNews>
     suspend fun insertNewsFromJson(doc: com.google.gson.JsonObject)
     suspend fun insertNewsList(docs: List<com.google.gson.JsonObject>)
-    fun serializeNews(news: RealmNews): com.google.gson.JsonObject
     fun bulkInsertFromSync(realm: io.realm.Realm, jsonArray: com.google.gson.JsonArray)
 }

app/src/main/java/org/ole/planet/myplanet/repository/VoicesRepositoryImpl.kt

@@ -36,7 +36,7 @@ class VoicesRepositoryImpl @Inject constructor(
 ) : RealmRepository(databaseService, realmDispatcher), VoicesRepository {
     private val concatenatedLinks = ArrayList<String>()
 
-    override suspend fun getNewsForUpload(serializeNews: (RealmNews) -> JsonObject): List<NewsUploadData> {
+    override suspend fun getNewsForUpload(): List<NewsUploadData> {
         return withRealm { realm ->
             realm.where(RealmNews::class.java)
                 .findAll()
@@ -570,7 +570,7 @@ class VoicesRepositoryImpl @Inject constructor(
         news?.sharedBy = JsonUtils.getString("sharedBy", newsObj)
     }
 
-    override fun serializeNews(news: RealmNews): JsonObject {
+    private fun serializeNews(news: RealmNews): JsonObject {
         val `object` = JsonObject()
         `object`.addProperty("chat", news.chat)
         `object`.addProperty("message", news.message)

app/src/main/java/org/ole/planet/myplanet/services/UploadManager.kt

@@ -497,7 +497,7 @@ class UploadManager @Inject constructor(
         // standard UploadCoordinator pattern, so we handle it with custom logic but still use
         // the coordinator for the core upload/update flow where possible.
         val user = userRepository.getUserModelSuspending()
-        val newsItems = voicesRepository.getNewsForUpload { voicesRepository.serializeNews(it) }
+        val newsItems = voicesRepository.getNewsForUpload()
 
         withContext(dispatcherProvider.io) {
             newsItems.chunked(BATCH_SIZE).forEach { batch ->

app/src/main/java/org/ole/planet/myplanet/services/upload/UploadConfigs.kt

@@ -241,13 +241,4 @@ class UploadConfigs @Inject constructor(
             rating.isUpdated = false
         }
     )
-
-    val News = UploadConfig(
-        modelClass = RealmNews::class,
-        endpoint = "news",
-        queryBuilder = { query -> query },  // Upload all news items
-        serializer = UploadSerializer.Simple(voicesRepository::serializeNews),
-        idExtractor = { it.id },
-        dbIdExtractor = { it._id }  // Enables POST/PUT logic
-    )
 }