🧹 [code health improvement] Remove deprecated getUserModel from UserRepositoryImpl

Removes the deprecated synchronous `getUserModel()` method from `UserRepository.kt` and `UserRepositoryImpl.kt`, and removes the deprecated `userModel` and `getUserModelCopy()` properties from `UserSessionManager.kt`. Updates usages to use the new `getUserModelSuspending()` flow within coroutines.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Author: dogi

app/src/main/java/org/ole/planet/myplanet/repository/UserRepository.kt

@@ -78,9 +78,6 @@ interface UserRepository {
         userId: String,
         currentUser: RealmUser
     ): HealthRecord?
-
-    @Deprecated("Use getUserModelSuspending() instead")
-    fun getUserModel(): RealmUser?
     suspend fun getUserModelSuspending(): RealmUser?
     suspend fun getUserProfile(): RealmUser?
     suspend fun getUserImageUrl(): String?

app/src/main/java/org/ole/planet/myplanet/repository/UserRepositoryImpl.kt

@@ -563,19 +563,6 @@ class UserRepositoryImpl @Inject constructor(
         }
     }
 
-    @Deprecated("Use getUserModelSuspending() instead")
-    override fun getUserModel(): RealmUser? {
-        val userId = sharedPrefManager.getUserId().takeUnless { it.isBlank() } ?: return null
-        return databaseService.withRealm { realm ->
-            realm.where(RealmUser::class.java)
-                .equalTo("id", userId)
-                .or()
-                .equalTo("_id", userId)
-                .findFirst()
-                ?.let { realm.copyFromRealm(it) }
-        }
-    }
-
     override suspend fun getUserModelSuspending(): RealmUser? {
         val userId = sharedPrefManager.getUserId().takeUnless { it.isBlank() } ?: return null
         return withRealm { realm ->

app/src/main/java/org/ole/planet/myplanet/services/UserSessionManager.kt

@@ -35,14 +35,6 @@ class UserSessionManager @Inject constructor(
         }
     }
 
-    @Deprecated("Use getUserModel() suspend function instead")
-    val userModel: RealmUser? get() = userRepository.getUserModel()
-
-    @Deprecated("Use getUserModel() suspend function instead")
-    fun getUserModelCopy(): RealmUser? {
-        return userRepository.getUserModel()
-    }
-
     suspend fun getUserModel(): RealmUser? {
         return userRepository.getUserModelSuspending()
     }

app/src/main/java/org/ole/planet/myplanet/ui/dashboard/DashboardActivity.kt

@@ -136,18 +136,17 @@ class DashboardActivity : DashboardElementActivity(), OnHomeItemClickListener, N
             }
         )
 
-        @Suppress("DEPRECATION")
-        user = userSessionManager.userModel
-        checkUser()
-        updateAppTitle()
-        if (handleGuestAccess()) return
-
         isFirstLaunch = savedInstanceState == null
-        if (isFirstLaunch) handleInitialFragment()
         addBackPressCallback()
         collectUiState()
 
         lifecycleScope.launch {
+            user = userSessionManager.getUserModel()
+            checkUser()
+            updateAppTitle()
+            if (handleGuestAccess()) return@launch
+
+            if (isFirstLaunch) handleInitialFragment()
             initializeDashboard()
             isReady = true
             binding.root.invalidate()

app/src/test/java/org/ole/planet/myplanet/services/UserSessionManagerTest.kt

@@ -82,14 +82,6 @@ class UserSessionManagerTest {
         )
     }
 
-    @Test
-    fun `getUserModel returns model from repository`() {
-        val mockUser = mockk<RealmUser>()
-        every { userRepository.getUserModel() } returns mockUser
-        assertEquals(mockUser, userSessionManager.userModel)
-        assertEquals(mockUser, userSessionManager.getUserModelCopy())
-    }
-
     @Test
     fun `getUserModel suspending returns model from repository`() = testScope.runTest {
         val mockUser = mockk<RealmUser>()