apply better survey type value

Author: Mutugiii

gateway/src/modules/public/services/surveys.service.ts

@@ -86,7 +86,7 @@ const sanitizeSurveySnapshot = (survey: SurveyDoc) => ({
   'name': survey.name,
   'description': survey.description || '',
   'questions': survey.questions,
-  'type': 'survey'
+  'type': survey.type
 });
 
 const sanitizeTeam = (team: TeamDoc) => ({
@@ -183,6 +183,13 @@ export const createPublicSurveySubmission = async (req: Request, res: Response)
     });
   }
 
+  if (!answers.every((answer) => isValidAnswer(answer))) {
+    return res.status(400).json({
+      'error': 'Bad Request',
+      'message': 'answers must include a response for each survey question'
+    });
+  }
+
   const submission = buildPublicSubmission(survey, team, payload, configuration);
   const response = await submissionsDB.insert(submission as any);
 

src/app/surveys/surveys.component.html

@@ -75,7 +75,7 @@
               </button>
             </div>
             <div [matTooltip]="getActionTooltip(element, 'send')">
-              <button mat-raised-button color="primary" *ngIf="!teamId && !routeTeamId" [matMenuTriggerFor]="sendMenu" [disabled]="!element.questions.length || element.isArchived || (element.teamId && isManagerRoute)">
+              <button mat-raised-button color="primary" *ngIf="!teamId && !routeTeamId" [matMenuTriggerFor]="sendMenu" [disabled]="!element.questions?.length || element.isArchived || (element.teamId && isManagerRoute)">
                 <mat-icon>send</mat-icon>
                 <label *ngIf="!isMobile" i18n> Send</label>
               </button>
@@ -85,13 +85,13 @@
               <button mat-menu-item style="width: 100%;" (click)="openSendSurveyToTeamsDialog(element)" [disabled]="!element.teamShareAllowed" i18n>Team</button>
             </mat-menu>
             <div [matTooltip]="getActionTooltip(element, 'record')">
-              <button mat-raised-button color="primary" (click)="recordSurvey(element)" [disabled]="!element.questions.length || element.isArchived || (element.teamId && isManagerRoute)">
+              <button mat-raised-button color="primary" (click)="recordSurvey(element)" [disabled]="!element.questions?.length || element.isArchived || (element.teamId && isManagerRoute)">
                 <mat-icon>fiber_manual_record</mat-icon>
                 <label *ngIf="!isMobile" i18n> Record</label>
               </button>
             </div>
             <div *ngIf="element.teamId && (teamId || routeTeamId)" [matTooltip]="getActionTooltip(element, 'public')">
-              <button mat-raised-button color="accent" (click)="element.publicAccess === true ? copyPublicSurveyLink(element) : toggleSurveyPublicAccess(element)" [disabled]="!element.questions.length || element.isArchived">
+              <button mat-raised-button color="accent" (click)="element.publicAccess === true ? copyPublicSurveyLink(element) : toggleSurveyPublicAccess(element)" [disabled]="!element.questions?.length || element.isArchived">
                 <mat-icon>{{ element.publicAccess === true ? 'link' : 'public' }}</mat-icon>
                 <label *ngIf="!isMobile" i18n>{{ element.publicAccess === true ? 'Copy Public Link' : 'Generate Public Link' }}</label>
               </button>
@@ -111,7 +111,7 @@
               </div>
             </ng-container>
             <div [matTooltip]="getActionTooltip(element, 'submissions')">
-              <button mat-raised-button color="primary" *ngIf="!teamId && !routeTeamId" (click)="viewSurveySubmissions(element)" [disabled]="!element.questions.length || !element.taken">
+              <button mat-raised-button color="primary" *ngIf="!teamId && !routeTeamId" (click)="viewSurveySubmissions(element)" [disabled]="!element.questions?.length || !element.taken">
                 <mat-icon>insert_drive_file</mat-icon>
                 <label *ngIf="!isMobile" i18n> Submissions</label>
               </button>