v5.0.x: Add SVE detection alongside NEON in aarch64 op component #13244
+66
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vogma
changed the title
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 64ec344: config: add SVE detection alongside NEON in aarch6...
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
1 similar comment
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 64ec344: config: add SVE detection alongside NEON in aarch6...
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
- Introduce AC_CACHE_CHECK probes for ARM Scalable Vector Extension (SVE)
using both a default compile test and a second test with __attribute__((__target__("+sve"))).
- Define variables op_cv_sve_support and op_cv_sve_add_flags
- Update AM_CONDITIONAL and AC_DEFINE to expose SVE support macros
(OMPI_MCA_OP_HAVE_SVE, OMPI_MCA_OP_SVE_EXTRA_FLAGS).
- Extend final AS_IF to enable the component when either NEON or SVE is available.
- Add a preprocessor guard around SVE-specific function attributes
- Encapsulate the +sve attribute behind OMPI_MCA_OP_SVE_EXTRA_FLAGS, ensuring
that only builds which detected and enabled compiler SVE support will compile with
SVE-targeted code paths.
- Simplifies later code by using SVE_ATTR in function declarations instead of
repeating the attribute clause.
- apply SVE_ATTR macro in C source for conditional +sve targeting
- sve feature detection only on linux
- code review feedback
Signed-off-by: Marco Vogel <[email protected]>
(cherry picked from commit 16cb214)
vogma
force-pushed
the
v5.0.x/aarch64_build_update
branch
from
64ec344 to
42c4eeb
Compare
|
The error seems to be related to the build machine ( |
bosilca
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SVE detection alongside NEON in aarch64 op component
Signed-off-by: Marco Vogel [email protected]
(cherry picked from commit 16cb214)
This is the v5.0.x PR corresponding to main PR #13204