Enable unused-receiver linter (revive) (#7448)

Signed-off-by: Anders Eknert <[email protected]>

Author: anderseknert

.golangci.yaml

@@ -186,8 +186,10 @@ linters-settings:
     rules:
     # this mainly complains about us using min/max for variable names,
     # which seems like an unlikely source of actual issues
-     - name: redefines-builtin-id
-       disabled: true
+      - name: redefines-builtin-id
+        disabled: true
+      - name: unused-receiver
+        disabled: false
 
 linters:
   disable-all: true

cmd/bench.go

@@ -230,7 +230,7 @@ func benchMain(args []string, params benchmarkCommandParams, w io.Writer, r benc
 type goBenchRunner struct {
 }
 
-func (r *goBenchRunner) run(ctx context.Context, ectx *evalContext, params benchmarkCommandParams, f func(context.Context, ...rego.EvalOption) error) (testing.BenchmarkResult, error) {
+func (*goBenchRunner) run(ctx context.Context, ectx *evalContext, params benchmarkCommandParams, f func(context.Context, ...rego.EvalOption) error) (testing.BenchmarkResult, error) {
 
 	var hist, m metrics.Metrics
 	if params.metrics {

cmd/eval.go

@@ -788,7 +788,7 @@ func newrepeatedStringFlag(val []string) repeatedStringFlag {
 	}
 }
 
-func (f *repeatedStringFlag) Type() string {
+func (*repeatedStringFlag) Type() string {
 	return stringType
 }
 
@@ -818,7 +818,7 @@ func newIntFlag(val int) intFlag {
 	}
 }
 
-func (f *intFlag) Type() string {
+func (*intFlag) Type() string {
 	return "int"
 }
 

cmd/flags.go

@@ -207,7 +207,7 @@ func newcapabilitiesFlag() *capabilitiesFlag {
 	}
 }
 
-func (f *capabilitiesFlag) Type() string {
+func (*capabilitiesFlag) Type() string {
 	return stringType
 }
 
@@ -236,7 +236,7 @@ type stringptrFlag struct {
 	isSet bool
 }
 
-func (f *stringptrFlag) Type() string {
+func (*stringptrFlag) Type() string {
 	return stringType
 }
 

cmd/internal/env/env.go

@@ -22,7 +22,7 @@ var (
 
 const globalPrefix = "opa"
 
-func (cf cmdFlagsImpl) CheckEnvironmentVariables(command *cobra.Command) error {
+func (cmdFlagsImpl) CheckEnvironmentVariables(command *cobra.Command) error {
 	var errs []string
 	v := viper.New()
 	v.AutomaticEnv()

internal/logging/logging.go

@@ -50,7 +50,7 @@ func spaces(num int) string {
 	return strings.Repeat(" ", num)
 }
 
-func (p *prettyFormatter) Format(e *logrus.Entry) ([]byte, error) {
+func (*prettyFormatter) Format(e *logrus.Entry) ([]byte, error) {
 	b := new(bytes.Buffer)
 
 	level := strings.ToUpper(e.Level.String())

internal/prometheus/prometheus.go

@@ -94,7 +94,7 @@ func (p *Provider) InstrumentHandler(handler http.Handler, label string) http.Ha
 }
 
 // Info returns attributes that describe the metric provider.
-func (p *Provider) Info() metrics.Info {
+func (*Provider) Info() metrics.Info {
 	return metrics.Info{
 		Name: "prometheus",
 	}

internal/providers/aws/signing_v4a.go

@@ -280,7 +280,7 @@ func buildAuthorizationHeader(credentialStr, signedHeadersStr, signingSignature
 	return parts.String()
 }
 
-func (s *httpSigner) buildCanonicalHeaders(host string, rule v4Internal.Rule, header http.Header, length int64) (signed http.Header, signedHeaders, canonicalHeadersStr string) {
+func (*httpSigner) buildCanonicalHeaders(host string, rule v4Internal.Rule, header http.Header, length int64) (signed http.Header, signedHeaders, canonicalHeadersStr string) {
 	signed = make(http.Header)
 
 	const hostHeader = "host"

internal/wasm/module/module.go

@@ -288,7 +288,7 @@ func (x ExportDescriptorType) String() string {
 }
 
 // Kind returns the function import type kind.
-func (i FunctionImport) Kind() ImportDescriptorType {
+func (FunctionImport) Kind() ImportDescriptorType {
 	return FunctionImportType
 }
 
@@ -297,7 +297,7 @@ func (i FunctionImport) String() string {
 }
 
 // Kind returns the memory import type kind.
-func (i MemoryImport) Kind() ImportDescriptorType {
+func (MemoryImport) Kind() ImportDescriptorType {
 	return MemoryImportType
 }
 
@@ -306,7 +306,7 @@ func (i MemoryImport) String() string {
 }
 
 // Kind returns the table import type kind.
-func (i TableImport) Kind() ImportDescriptorType {
+func (TableImport) Kind() ImportDescriptorType {
 	return TableImportType
 }
 
@@ -315,7 +315,7 @@ func (i TableImport) String() string {
 }
 
 // Kind returns the global import type kind.
-func (i GlobalImport) Kind() ImportDescriptorType {
+func (GlobalImport) Kind() ImportDescriptorType {
 	return GlobalImportType
 }
 

internal/wasm/sdk/opa/loader/http/loader.go

@@ -258,7 +258,7 @@ func (l *Loader) get(ctx context.Context, tag string) (*bundle.Bundle, error) {
 
 // close closes the HTTP response gracefully, first draining it, to
 // avoid resource leaks.
-func (l *Loader) close(resp *http.Response) {
+func (*Loader) close(resp *http.Response) {
 	_, _ = io.Copy(io.Discard, resp.Body) // Ignore errors.
 	_ = resp.Body.Close()
 }