Fix system dump test case by enabling the dump policy.

Currently our testcase directly triggers the system dump
even the dump policy for it is disabled, which results in
our testcase won't trigger any system dump and just simply
system IPL's without dumping system files(OPAL, printk, hbrt log)

So this patch fixes this issue by enabling the system dump policy
before triggering any system dump. And also this adds conditions
to retrieve individual files after dump is generated and make
sure the three files(OPAL, hbrt log and printk log) collected
properly.

For more details: Internal BZ155562

Signed-off-by: Pridhiviraj Paidipeddi <[email protected]>

Author: pridhiviraj

common/OpTestFSP.py

@@ -299,6 +299,20 @@ def wait_for_ipling(self, timeout=10):
             time.sleep(5)
         return BMC_CONST.FW_SUCCESS
 
+    def wait_for_dump_to_start(self):
+        count = 0
+        # Dump maximum can start in one minute(So lets wait for 3 mins)
+        while count < 3:
+            if self.get_sys_status() == "dumping":
+                return True
+            count += 1
+            time.sleep(60)
+        else:
+            print "Current system status: %s" % self.get_sys_status()
+            print "Current progress code: %s" % self.get_progress_code()
+            raise OpTestError("System dump not started even after 3 minutes")
+
+
     ##
     # @brief Wait for system to reach runtime
     # @returns 0 on success or throws exception
@@ -318,6 +332,15 @@ def wait_for_runtime(self, timeout=10):
             time.sleep(5)
         return BMC_CONST.FW_SUCCESS
 
+    def enable_system_dump(self):
+        print "Enabling the system dump policy"
+        self.fspc.run_command("sysdump -sp enableSys")
+        res = self.fspc.run_command("sysdump -vp")
+        if "System dumps             Enabled       Enabled" in res:
+            print "System dump policy enabled successfully"
+            return True
+        raise OpTestError("Failed to enable system dump policy")
+
     ##
     # @brief Trigger system dump from fsp
     # @returns True on success or raises exception
@@ -340,6 +363,8 @@ def trigger_system_dump(self):
     # @returns True on success or throws exception
     #
     def wait_for_systemdump_to_finish(self):
+        self.wait_for_dump_to_start()
+        # If dump starts then wait for finish it
         count = 0
         while count < 30:
             res = self.fspc.run_command("sysdump -qall")

testcases/OpTestDumps.py

@@ -25,6 +25,10 @@
 #  Different dumps for fsp platforms
 #  fipsdump
 #  system dump
+#      host_dump_boottime --> Trigger dump when kernel boots(either Petitboot or OS kernel)
+#      host_dump_runtime  --> Trigger dump when system is in OS or already booted to OS
+#      nmi_dump           --> Trigger system dump by sending NMI interrupts to processors
+#
 
 import time
 import subprocess
@@ -57,7 +61,7 @@ def tearDown(self):
     def trigger_dump(self):
         if self.test == "nmi_dump":
             self.cv_IPMI.ipmi_power_diag()
-        elif self.test == "host_dump":
+        elif "host_dump" in self.test:
             self.cv_FSP.trigger_system_dump()
         else:
             raise Exception("Unknown test type")
@@ -138,15 +142,20 @@ def runTest(self):
             self.skipTest("FSP Platform OPAL specific dump tests")
         self.cv_HOST.host_check_command("opal-dump-parse")
         self.cv_HOST.host_run_command("rm -rf /var/log/dump/SYSDUMP*")
+        self.cv_HOST.host_run_command("rm -rf /var/log/dump/Opal-log*")
+        self.cv_HOST.host_run_command("rm -rf /var/log/dump/HostBoot-Runtime-log*")
+        self.cv_HOST.host_run_command("rm -rf /var/log/dump/printk*")
         self.cv_FSP.fsp_get_console()
         if not self.cv_FSP.mount_exists():
             raise OpTestError("Please mount NFS and retry the test")
 
         self.set_up()
         print self.cv_FSP.fsp_run_command("smgr mfgState")
+        self.cv_FSP.enable_system_dump()
         self.cv_FSP.clear_fsp_errors()
-        self.cv_FSP.power_off_sys()
-        self.cv_FSP.power_on_sys()
+        if "host_dump_boottime" in self.test:
+            self.cv_FSP.power_off_sys()
+            self.cv_FSP.power_on_sys()
         self.util.PingFunc(self.cv_HOST.ip, BMC_CONST.PING_RETRY_POWERCYCLE)
         self.trigger_dump()
         self.cv_FSP.wait_for_systemdump_to_finish()
@@ -164,6 +173,14 @@ def runTest(self):
         self.assertIn("Opal", '\n'.join(res), "sysdump test failed in dumping Opal-log section")
         self.assertIn("HostBoot-Runtime-log", '\n'.join(res), "sysdump test failed in dumping HBRT section")
         self.assertIn("printk", '\n'.join(res), "sysdump test failed in dumping printk section")
+        self.cv_HOST.host_run_command("cd /var/log/dump/")
+        self.cv_HOST.host_run_command("opal-dump-parse -s 1 /var/log/dump/SYSDUMP*")
+        self.cv_HOST.host_run_command("cat Opal-log*")
+        self.cv_HOST.host_run_command("opal-dump-parse -s 2  /var/log/dump/SYSDUMP*")
+        self.cv_HOST.host_run_command("cat HostBoot-Runtime-log*")
+        self.cv_HOST.host_run_command("opal-dump-parse -s 128 /var/log/dump/SYSDUMP*")
+        self.cv_HOST.host_run_command("cat printk*")
+
 
 class FIPS_DUMP(OpTestDumps, unittest.TestCase):
 
@@ -201,10 +218,16 @@ def runTest(self):
             dumpname, size = self.fipsdump_initiate_from_host()
             self.verify_fipsdump(dumpname, size)
 
-class HOST_DUMP(SYSTEM_DUMP):
+class HOST_DUMP_BOOTTIME(SYSTEM_DUMP):
+
+    def set_up(self):
+        self.test = "host_dump_boottime"
+
+class HOST_DUMP_RUNTIME(SYSTEM_DUMP):
 
     def set_up(self):
-        self.test = "host_dump"
+        self.test = "host_dump_runtime"
+
 
 class NMI_DIAG_DUMP(SYSTEM_DUMP):
 
@@ -214,6 +237,7 @@ def set_up(self):
 def suite():
     s = unittest.TestSuite()
     s.addTest(FIPS_DUMP())
-    s.addTest(HOST_DUMP())
+    s.addTest(HOST_DUMP_RUNTIME())
     s.addTest(NMI_DIAG_DUMP())
+    s.addTest(HOST_DUMP_BOOTTIME())
     return s