move pnpm overrides (#1092)

* migrated without linting errors

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* add to paths

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* run nightly, use ubuntu-latest

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* use --no-frozen-lockfile, to accommodate different versions

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* revert running nightly for this PR

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* add steps to set up npx for the tests

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* add comment on overrides, do not use no-frozen-lockfile

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

Author: aaronchongth

.github/workflows/api-client.yml

@@ -6,6 +6,8 @@ on:
       - '.github/actions/bootstrap/action.yml'
       - '.github/minimal-rmf/**'
       - 'packages/api-client/**'
+      - 'package.json'
+      - 'pnpm-workspace.yaml'
   push:
     branches:
       - main

.github/workflows/api-server.yml.disabled

@@ -6,6 +6,8 @@ on:
       - '.github/actions/bootstrap/action.yml'
       - '.github/minimal-rmf/**'
       - 'packages/api-server/**'
+      - 'package.json'
+      - 'pnpm-workspace.yaml'
   push:
     branches:
       - main
@@ -18,7 +20,7 @@ env:
 jobs:
   tests:
     name: Tests
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     container:
       image: ghcr.io/${{ github.repository }}/minimal-rmf:rolling-nightly
       credentials:

.github/workflows/dashboard-e2e.yml.disabled

@@ -9,7 +9,7 @@ env:
 jobs:
   dashboard-e2e:
     name: Dashboard e2e
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     container:
       image: ghcr.io/${{ github.repository }}/e2e
       credentials:

.github/workflows/nightly.yml

@@ -9,7 +9,7 @@ concurrency:
 jobs:
   build-minimal-rmf-docker-images:
     name: Push minimal-rmf Docker image to GitHub Packages
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
@@ -35,7 +35,7 @@ jobs:
   build-dashboard-image:
     needs: build-minimal-rmf-docker-images
     name: Push Dashboard docker image to GitHub Packages
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
@@ -62,7 +62,7 @@ jobs:
   build-api-server-image:
     needs: build-minimal-rmf-docker-images
     name: Push API server docker image to GitHub Packages
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
@@ -125,7 +125,7 @@ jobs:
   api-server:
     needs: build-minimal-rmf-docker-images
     name: Test API server
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
@@ -163,7 +163,7 @@ jobs:
   rmf-dashboard-framework:
     needs: build-minimal-rmf-docker-images
     name: Test dashboard framework
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
@@ -198,7 +198,7 @@ jobs:
   ros-translator:
     needs: build-minimal-rmf-docker-images
     name: Test ros-translator
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
@@ -237,7 +237,7 @@ jobs:
   #     fail-fast: false
   #   needs: build-docker-images
   #   name: Dashboard e2e
-  #   runs-on: ubuntu-24.04
+  #   runs-on: ubuntu-latest
   #   container:
   #     image: ghcr.io/${{ github.repository }}/e2e
   #     options: --privileged --ipc=host

.github/workflows/rmf-dashboard-framework.yml

@@ -8,6 +8,8 @@ on:
       - 'packages/rmf-dashboard-framework/**'
       - 'packages/rmf-models/**'
       - 'packages/api-client/**'
+      - 'package.json'
+      - 'pnpm-workspace.yaml'
   push:
     branches:
       - main
@@ -19,7 +21,7 @@ env:
 jobs:
   unit-tests:
     name: Unit Tests
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     container:
       image: ghcr.io/${{ github.repository }}/minimal-rmf:rolling-nightly
       credentials:

.github/workflows/ros-translator.yml

@@ -6,6 +6,8 @@ on:
       - '.github/actions/bootstrap/action.yml'
       - '.github/minimal-rmf/**'
       - 'packages/ros-translator/**'
+      - 'package.json'
+      - 'pnpm-workspace.yaml'
   push:
     branches:
       - main
@@ -17,7 +19,7 @@ env:
 jobs:
   unit-tests:
     name: Unit Tests
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     container:
       image: ghcr.io/${{ github.repository }}/minimal-rmf:rolling-nightly
       credentials:
@@ -36,5 +38,8 @@ jobs:
         with:
           package: ros-translator
           skip-build: true
+      - name: set up npx
+        run: |
+          pnpm add -g npm
       - name: test
         run: . /opt/ros/rolling/setup.bash && pnpm test

package.json

@@ -32,31 +32,5 @@
       ".venv/bin/pipenv run isort",
       ".venv/bin/pipenv run black"
     ]
-  },
-  "pnpm": {
-    "overrides": {
-      "typescript-json-schema>@types/node": "*",
-      "form-data@<4.0.4": "^4.0.4",
-      "axios@<1.12.0": "^1.16.0",
-      "qs": "^6.14.2",
-      "min-document": "^2.19.1",
-      "follow-redirects": "^1.16.0",
-      "lodash": "^4.18.0",
-      "yaml": "^1.10.3",
-      "serialize-javascript": "^7.0.5",
-      "react-router": "^6.30.2",
-      "@babel/runtime": "^7.26.10",
-      "file-type": "^21.3.1",
-      "@remix-run/router": "^1.23.2",
-      "rollup": "^4.59.0",
-      "phin": "^3.7.1",
-      "node-fetch": "^2.6.7",
-      "ws": "^7.5.10",
-      "cross-spawn": "^7.0.5",
-      "tar-fs": "^2.1.4"
-    }
-  },
-  "overrides": {
-    "react-error-overlay": "6.0.9"
   }
 }