Skip to content

Commit ed87a77

Browse files
update unit test
Co-authored-by: Luc Mcgrady <lucmcgrady@gmail.com>
1 parent 8d0204f commit ed87a77

File tree

1 file changed

+17
-11
lines changed

1 file changed

+17
-11
lines changed

src/optimal_retention.rs

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -925,29 +925,35 @@ mod tests {
925925

926926
#[test]
927927
fn changing_learn_span_should_get_same_review_cnt_per_day() -> Result<()> {
928+
const LOWER: usize = 365;
929+
const DECK_SIZE: usize = 1000;
930+
const LEARN_LIMIT: usize = 10;
928931
let config = SimulatorConfig {
929-
learn_span: 10,
930-
learn_limit: 10,
931-
deck_size: 200,
932+
learn_span: LOWER,
933+
learn_limit: LEARN_LIMIT,
934+
deck_size: DECK_SIZE,
932935
..Default::default()
933936
};
934937
let (_, review_cnt_per_day_10, _, _) =
935938
simulate(&config, &DEFAULT_PARAMETERS, 0.9, None, None)?;
936939
let config = SimulatorConfig {
937-
learn_span: 11,
938-
learn_limit: 10,
939-
deck_size: 200,
940+
learn_span: LOWER + 10,
941+
learn_limit: LEARN_LIMIT,
942+
deck_size: DECK_SIZE,
940943
..Default::default()
941944
};
942945
let (_, review_cnt_per_day_11, _, _) =
943946
simulate(&config, &DEFAULT_PARAMETERS, 0.9, None, None)?;
944-
// Compare first 10 items of review_cnt_per_day arrays
945-
for i in 0..10 {
946-
assert_eq!(review_cnt_per_day_10[i], review_cnt_per_day_11[i]);
947+
// Compare first LOWER items of review_cnt_per_day arrays
948+
for i in 0..LOWER {
949+
assert_eq!(
950+
review_cnt_per_day_10[i], review_cnt_per_day_11[i],
951+
"at index {}",
952+
i
953+
);
947954
}
948955
Ok(())
949-
}
950-
956+
}
951957
#[test]
952958
fn simulate_with_existing_cards() -> Result<()> {
953959
let config = SimulatorConfig {

0 commit comments

Comments
 (0)