Bring back github link checking (#2804)

* Bring back github link checking

* sync with spec config

* fix broken links

* Exclude false positive

* faster

* GITHUB_TOKEN

Author: trask

.github/workflows/reusable-markdown-link-check.yml

@@ -14,3 +14,6 @@ jobs:
 
       - name: Run markdown-link-check
         run: make markdown-link-check
+        env:
+          # see https://lychee.cli.rs/troubleshooting/rate-limits/#github-rate-limiting
+          GITHUB_TOKEN: ${{ github.token }}

.lychee.toml

@@ -1,13 +1,14 @@
 include_fragments = true
 
-# Accept 429 (rate limiting) to prevent failures
-accept = ["200..=299", "401", "403", "429"]
+accept = ["200..=299", "401", "403"]
 
 exclude = [
     # excluding links to user profiles is done for performance
     # because there are a lot of links to user profiles in this repository
     # and GitHub extra throttles access to user profile pages
     "^https://github.com/[^/]+$",
+    # this 404s when not hit from a browser
+    "^https://www.linuxfoundation.org/legal/generative-ai$",
 ]
 
 exclude_path = [
@@ -26,9 +27,8 @@ exclude_path = [
     "/home/repo/elections/2024/governance-committee-election.md",
 ]
 
-# Retry configuration with more reasonable timeout values
-max_retries = 3
-# Wait time (in seconds) between retries with exponential backoff
-retry_wait_time = 1
-# Reduce number of concurrent requests to avoid triggering rate limits
-max_concurrency = 75
+# better to be safe and avoid failures
+max_retries = 6
+
+# this helps slow down the rate of requests to avoid rate limiting
+max_concurrency = 16

guides/contributor/processes.md

@@ -209,9 +209,9 @@ carry a permissive software license that is compatible when combining with
 Apache-2.0 License. 
 
 If you directly incorporate or vendor Apache-2.0 license compatible third-party code, follow
-the [CNCF Recommendations for Attribution Notices](https://github.com/cncf/foundation/blob/main/recommendations-for-attribution.md).
+the [CNCF Recommendations for Attribution Notices](https://github.com/cncf/foundation/blob/main/policies-guidance/recommendations-for-attribution.md).
 
-The [CNCF Allowlist License Policy](https://github.com/cncf/foundation/blob/main/allowed-third-party-license-policy.md#cncf-allowlist-license-policy)
+The [CNCF Allowlist License Policy](https://github.com/cncf/foundation/blob/main/policies-guidance/allowed-third-party-license-policy.md#cncf-allowlist-license-policy)
 describes the requirements for depending on third-party code in CNCF codebases,
 along with a list of approved compatible licenses.