-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Expand file tree
/
Copy pathprocessor_test.go
More file actions
1720 lines (1484 loc) · 51.6 KB
/
processor_test.go
File metadata and controls
1720 lines (1484 loc) · 51.6 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0
package tailsamplingprocessor
import (
"context"
"encoding/binary"
"errors"
"sort"
"strings"
"sync"
"sync/atomic"
"testing"
"time"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"go.opentelemetry.io/collector/component"
"go.opentelemetry.io/collector/component/componenttest"
"go.opentelemetry.io/collector/consumer/consumertest"
"go.opentelemetry.io/collector/featuregate"
"go.opentelemetry.io/collector/pdata/pcommon"
"go.opentelemetry.io/collector/pdata/ptrace"
"go.opentelemetry.io/collector/processor/processortest"
"go.opentelemetry.io/otel/attribute"
"go.opentelemetry.io/otel/metric"
sdkmetric "go.opentelemetry.io/otel/sdk/metric"
"go.opentelemetry.io/otel/sdk/metric/metricdata"
"go.uber.org/zap"
"go.uber.org/zap/zaptest/observer"
"github.com/open-telemetry/opentelemetry-collector-contrib/processor/tailsamplingprocessor/internal/idbatcher"
"github.com/open-telemetry/opentelemetry-collector-contrib/processor/tailsamplingprocessor/internal/metadata"
"github.com/open-telemetry/opentelemetry-collector-contrib/processor/tailsamplingprocessor/internal/tailstorageextension"
"github.com/open-telemetry/opentelemetry-collector-contrib/processor/tailsamplingprocessor/pkg/samplingpolicy"
)
const (
defaultTestDecisionWait = 30 * time.Second
defaultNumTraces = 100
)
var (
testPolicy = []PolicyCfg{{sharedPolicyCfg: sharedPolicyCfg{Name: "test-policy", Type: AlwaysSample}}}
testLatencyPolicy = []PolicyCfg{
{
sharedPolicyCfg: sharedPolicyCfg{
Name: "test-policy",
Type: Latency,
LatencyCfg: LatencyCfg{ThresholdMs: 1},
},
},
}
testExtensionID = component.MustNewID("my_extension")
)
type TestPolicyEvaluator struct {
Started chan struct{}
CouldContinue chan struct{}
pe samplingpolicy.Evaluator
}
func (t *TestPolicyEvaluator) Evaluate(ctx context.Context, traceID pcommon.TraceID, trace *samplingpolicy.TraceData) (samplingpolicy.Decision, error) {
close(t.Started)
<-t.CouldContinue
return t.pe.Evaluate(ctx, traceID, trace)
}
func (t *TestPolicyEvaluator) IsStateful() bool {
return t.pe.IsStateful()
}
// testTSPController is a set of mechanisms to make the TSP do predictable
// things in tests.
type testTSPController struct {
tickChan chan chan struct{}
}
func newTestTSPController() *testTSPController {
return &testTSPController{
tickChan: make(chan chan struct{}),
}
}
func (t *testTSPController) triggerTicks() chan struct{} {
// We need a buffer so the ticker can signal completion without
// blocking.
tickDone := make(chan struct{}, 1)
t.tickChan <- tickDone
return tickDone
}
func (t *testTSPController) concurrentWithTick(f func()) {
tickDone := t.triggerTicks()
f()
<-tickDone
}
func (t *testTSPController) waitForTick() {
<-t.triggerTicks()
}
func withTestController(t *testTSPController) Option {
return func(tsp *tailSamplingSpanProcessor) {
tsp.tickChan = make(chan chan struct{})
t.tickChan = tsp.tickChan
// Use an unbuffered work channel so we know that when ConsumeTraces
// completes the traces will have been ingested by the TSP.
tsp.workChan = make(chan []traceBatch)
// use a sync ID batcher to avoid waiting on lots of empty ticks.
// We need to close the old one before creating a new one.
tsp.decisionBatcher = newSyncIDBatcher()
// Use a slow tick frequency to effectively disable automatic ticks.
// We'll manually trigger ticks as needed via the tickChan.
tsp.tickerFrequency = time.Hour
}
}
// withTickerFrequency sets the frequency at which the processor will evaluate
// the sampling policies.
func withTickerFrequency(frequency time.Duration) Option {
return func(tsp *tailSamplingSpanProcessor) {
tsp.tickerFrequency = frequency
}
}
// withPolicies sets the sampling policies to be used by the processor.
func withPolicies(policies []*policy) Option {
return func(tsp *tailSamplingSpanProcessor) {
tsp.policies = policies
}
}
type spanInfo struct {
span ptrace.Span
resource pcommon.Resource
scope pcommon.InstrumentationScope
}
func TestTraceIntegrity(t *testing.T) {
const spanCount = 4
// Generate trace with several spans with different scopes
traces := ptrace.NewTraces()
spans := make(map[pcommon.SpanID]spanInfo, 0)
// Fill resource
resourceSpans := traces.ResourceSpans().AppendEmpty()
resource := resourceSpans.Resource()
resourceSpans.Resource().Attributes().PutStr("key1", "value1")
resourceSpans.Resource().Attributes().PutInt("key2", 0)
// Fill scopeSpans 1
scopeSpans := resourceSpans.ScopeSpans().AppendEmpty()
scope := scopeSpans.Scope()
scopeSpans.Scope().SetName("scope1")
scopeSpans.Scope().Attributes().PutStr("key1", "value1")
scopeSpans.Scope().Attributes().PutInt("key2", 0)
// Add spans to scopeSpans 1
span := scopeSpans.Spans().AppendEmpty()
spanID := [8]byte{1, 2, 3, 4, 5, 6, 7, 8}
span.SetSpanID(pcommon.SpanID(spanID))
span.SetTraceID(pcommon.TraceID([16]byte{1, 2, 3, 4}))
spans[spanID] = spanInfo{span: span, resource: resource, scope: scope}
span = scopeSpans.Spans().AppendEmpty()
spanID = [8]byte{9, 10, 11, 12, 13, 14, 15, 16}
span.SetSpanID(pcommon.SpanID(spanID))
span.SetTraceID(pcommon.TraceID([16]byte{5, 6, 7, 8}))
spans[spanID] = spanInfo{span: span, resource: resource, scope: scope}
// Fill scopeSpans 2
scopeSpans = resourceSpans.ScopeSpans().AppendEmpty()
scope = scopeSpans.Scope()
scopeSpans.Scope().SetName("scope2")
scopeSpans.Scope().Attributes().PutStr("key1", "value1")
scopeSpans.Scope().Attributes().PutInt("key2", 0)
// Add spans to scopeSpans 2
span = scopeSpans.Spans().AppendEmpty()
spanID = [8]byte{17, 18, 19, 20, 21, 22, 23, 24}
span.SetSpanID(pcommon.SpanID(spanID))
span.SetTraceID(pcommon.TraceID([16]byte{9, 10, 11, 12}))
spans[spanID] = spanInfo{span: span, resource: resource, scope: scope}
span = scopeSpans.Spans().AppendEmpty()
spanID = [8]byte{25, 26, 27, 28, 29, 30, 31, 32}
span.SetSpanID(pcommon.SpanID(spanID))
span.SetTraceID(pcommon.TraceID([16]byte{13, 14, 15, 16}))
spans[spanID] = spanInfo{span: span, resource: resource, scope: scope}
require.Len(t, spans, spanCount)
nextConsumer := new(consumertest.TracesSink)
mpe1 := &mockPolicyEvaluator{}
policies := []*policy{
{name: "mock-policy-1", evaluator: mpe1, attribute: metric.WithAttributes(attribute.String("policy", "mock-policy-1"))},
}
controller := newTestTSPController()
cfg := Config{
SamplingStrategy: samplingStrategyTraceComplete,
DecisionWait: defaultTestDecisionWait,
NumTraces: defaultNumTraces,
Options: []Option{
withPolicies(policies),
withTestController(controller),
},
}
p, err := newTracesProcessor(t.Context(), processortest.NewNopSettings(metadata.Type), nextConsumer, cfg)
require.NoError(t, err)
require.NoError(t, p.Start(t.Context(), componenttest.NewNopHost()))
defer func() {
require.NoError(t, p.Shutdown(t.Context()))
}()
mpe1.SetDecision(samplingpolicy.Sampled)
// Generate and deliver first span
require.NoError(t, p.ConsumeTraces(t.Context(), traces))
// The first tick won't do anything
controller.waitForTick()
require.Equal(t, 0, mpe1.EvaluationCount())
// This will cause policy evaluations on the first span
controller.waitForTick()
// Both policies should have been evaluated once
assert.Equal(t, 4, mpe1.EvaluationCount())
consumed := nextConsumer.AllTraces()
require.Len(t, consumed, 4)
for _, trace := range consumed {
require.Equal(t, 1, trace.SpanCount())
require.Equal(t, 1, trace.ResourceSpans().Len())
require.Equal(t, 1, trace.ResourceSpans().At(0).ScopeSpans().Len())
require.Equal(t, 1, trace.ResourceSpans().At(0).ScopeSpans().At(0).Spans().Len())
span := trace.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(0)
if spanInfo, ok := spans[span.SpanID()]; ok {
require.Equal(t, spanInfo.span, span)
require.Equal(t, spanInfo.resource, trace.ResourceSpans().At(0).Resource())
require.Equal(t, spanInfo.scope, trace.ResourceSpans().At(0).ScopeSpans().At(0).Scope())
} else {
require.Fail(t, "Span not found")
}
}
}
func TestSequentialTraceArrival(t *testing.T) {
traceIDs, batches := generateIDsAndBatches(128)
controller := newTestTSPController()
cfg := Config{
SamplingStrategy: samplingStrategyTraceComplete,
DecisionWait: defaultTestDecisionWait,
NumTraces: uint64(2 * len(traceIDs)),
ExpectedNewTracesPerSec: 64,
PolicyCfgs: testPolicy,
Options: []Option{
withTestController(controller),
},
}
telem := setupTestTelemetry()
telemetrySettings := telem.newSettings()
nextConsumer := new(consumertest.TracesSink)
sp, err := newTracesProcessor(t.Context(), telemetrySettings, nextConsumer, cfg)
require.NoError(t, err)
err = sp.Start(t.Context(), componenttest.NewNopHost())
require.NoError(t, err)
defer func() {
err = sp.Shutdown(t.Context())
require.NoError(t, err)
}()
for _, batch := range batches {
require.NoError(t, sp.ConsumeTraces(t.Context(), batch))
}
// The first tick won't do anything
controller.waitForTick()
controller.waitForTick()
allSampledTraces := nextConsumer.AllTraces()
sampledTraceIDs := make(map[pcommon.TraceID]struct{})
for _, trace := range allSampledTraces {
sampledTraceIDs[trace.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(0).TraceID()] = struct{}{}
}
require.Len(t, sampledTraceIDs, 128)
for _, expectedTrace := range traceIDs {
_, ok := sampledTraceIDs[expectedTrace]
require.True(t, ok, "Expected trace %v to be sampled", expectedTrace)
delete(sampledTraceIDs, expectedTrace)
}
require.Empty(t, sampledTraceIDs, "No extra traces should be sampled")
}
func TestConcurrentTraceArrival(t *testing.T) {
traceIDs, batches := generateIDsAndBatches(128)
controller := newTestTSPController()
var wg sync.WaitGroup
cfg := Config{
SamplingStrategy: samplingStrategyTraceComplete,
DecisionWait: defaultTestDecisionWait,
NumTraces: uint64(2 * len(traceIDs)),
ExpectedNewTracesPerSec: 64,
PolicyCfgs: testPolicy,
Options: []Option{
withTestController(controller),
},
}
telem := setupTestTelemetry()
telemetrySettings := telem.newSettings()
nextConsumer := new(consumertest.TracesSink)
sp, err := newTracesProcessor(t.Context(), telemetrySettings, nextConsumer, cfg)
require.NoError(t, err)
err = sp.Start(t.Context(), componenttest.NewNopHost())
require.NoError(t, err)
defer func() {
err = sp.Shutdown(t.Context())
require.NoError(t, err)
}()
// Limit the concurrency here to avoid creating too many goroutines and hit
// https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/9126
concurrencyLimiter := make(chan struct{}, 128)
defer close(concurrencyLimiter)
for _, batch := range batches {
// Add the same traceId twice.
wg.Add(2)
concurrencyLimiter <- struct{}{}
go func(td ptrace.Traces) {
assert.NoError(t, sp.ConsumeTraces(t.Context(), td))
wg.Done()
<-concurrencyLimiter
}(batch)
concurrencyLimiter <- struct{}{}
go func(td ptrace.Traces) {
assert.NoError(t, sp.ConsumeTraces(t.Context(), td))
wg.Done()
<-concurrencyLimiter
}(batch)
}
wg.Wait()
// The first tick won't do anything
controller.waitForTick()
controller.waitForTick()
allSampledTraces := nextConsumer.AllTraces()
sampledTraceIDs := make(map[pcommon.TraceID]struct{})
for _, trace := range allSampledTraces {
sampledTraceIDs[trace.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(0).TraceID()] = struct{}{}
}
require.Len(t, sampledTraceIDs, 128)
for _, expectedTrace := range traceIDs {
_, ok := sampledTraceIDs[expectedTrace]
require.True(t, ok, "Expected trace %v to be sampled", expectedTrace)
delete(sampledTraceIDs, expectedTrace)
}
require.Empty(t, sampledTraceIDs, "No extra traces should be sampled")
}
func TestConcurrentArrivalAndEvaluation(t *testing.T) {
traceIDs, batches := generateIDsAndBatches(1)
controller := newTestTSPController()
var wg sync.WaitGroup
cfg := Config{
SamplingStrategy: samplingStrategyTraceComplete,
DecisionWait: defaultTestDecisionWait,
NumTraces: uint64(2 * len(traceIDs)),
ExpectedNewTracesPerSec: 64,
PolicyCfgs: testLatencyPolicy,
Options: []Option{
withTickerFrequency(time.Millisecond),
withTestController(controller),
},
}
sp, err := newTracesProcessor(t.Context(), processortest.NewNopSettings(metadata.Type), consumertest.NewNop(), cfg)
require.NoError(t, err)
err = sp.Start(t.Context(), componenttest.NewNopHost())
require.NoError(t, err)
defer func() {
err = sp.Shutdown(t.Context())
require.NoError(t, err)
}()
for _, batch := range batches {
wg.Add(1)
go func(td ptrace.Traces) {
for range 10 {
assert.NoError(t, sp.ConsumeTraces(t.Context(), td))
}
controller.concurrentWithTick(func() {
for range 10 {
assert.NoError(t, sp.ConsumeTraces(t.Context(), td))
}
})
wg.Done()
}(batch)
}
wg.Wait()
}
func TestSequentialTraceMapSize(t *testing.T) {
controller := newTestTSPController()
traceIDs, batches := generateIDsAndBatches(210)
cfg := Config{
SamplingStrategy: samplingStrategyTraceComplete,
DecisionWait: defaultTestDecisionWait,
NumTraces: defaultNumTraces,
ExpectedNewTracesPerSec: 64,
PolicyCfgs: testPolicy,
Options: []Option{
withTestController(controller),
},
}
nextConsumer := new(consumertest.TracesSink)
sp, err := newTracesProcessor(t.Context(), processortest.NewNopSettings(metadata.Type), nextConsumer, cfg)
require.NoError(t, err)
err = sp.Start(t.Context(), componenttest.NewNopHost())
require.NoError(t, err)
defer func() {
err = sp.Shutdown(t.Context())
require.NoError(t, err)
}()
for _, batch := range batches {
err = sp.ConsumeTraces(t.Context(), batch)
require.NoError(t, err)
}
// On sequential insertion it is possible to know exactly which traces
// should be still on the map. We expect those to be sampled now.
controller.waitForTick()
controller.waitForTick()
allSampledTraces := nextConsumer.AllTraces()
sampledTraceIDs := make(map[pcommon.TraceID]struct{})
for _, trace := range allSampledTraces {
sampledTraceIDs[trace.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(0).TraceID()] = struct{}{}
}
require.Len(t, sampledTraceIDs, int(cfg.NumTraces))
for _, expectedTrace := range traceIDs[len(traceIDs)-int(cfg.NumTraces):] {
_, ok := sampledTraceIDs[expectedTrace]
require.True(t, ok, "Expected trace %v to be sampled", expectedTrace)
delete(sampledTraceIDs, expectedTrace)
}
require.Empty(t, sampledTraceIDs, "No extra traces should be sampled")
}
func TestConsumptionDuringPolicyEvaluation(t *testing.T) {
// This test was added to reproduce a specific race condition:
// Each G is a goroutine
// G1: ConsumeTraces
// G1: Cache.Get (miss)
// G2: OnTick
// G2: makeDecision
// G2: Cache.Put
// G2: idToTrace.Delete
// G1: idToTrace.LoadOrStore
// G1: AppendToCurrentBatch
// < — At this point, we have a trace id which is in the batcher (G1 added it), the idToTrace map (G1 added it), and the decision cache (G2 added it).
// G3: ConsumeTraces
// G3: Cache.Get (hit)
// G3: idToTrace.Delete
// < — At this point, G3 has dropped the data added by G1, and orphaned a trace ID in the batcher.
// G2: CloseCurrentAndTakeFirstBatch
// G2: idToTrace.Load (miss) <- this is the droppedTooEarly signal
// We need a lot of tries to make this happen reliably.
numBatches := 100
_, batches := generateIDsAndBatches(numBatches)
// prepare
msp := new(consumertest.TracesSink)
cfg := Config{
SamplingStrategy: samplingStrategyTraceComplete,
DecisionWait: 10 * time.Millisecond,
// idToTrace map size is 2x the number of batches, to eliminate "expected"
// dropped too early errors.
NumTraces: uint64(numBatches * 2),
PolicyCfgs: testPolicy,
DecisionCache: DecisionCacheConfig{
// Cache large enough to hold all traces, to eliminate "expected"
// dropped too early errors.
SampledCacheSize: numBatches * 2,
},
Options: []Option{
withTickerFrequency(5 * time.Millisecond),
},
}
settings := processortest.NewNopSettings(metadata.Type)
reader := sdkmetric.NewManualReader()
settings.MeterProvider = sdkmetric.NewMeterProvider(sdkmetric.WithReader(reader))
tsp, err := newTracesProcessor(t.Context(), settings, msp, cfg)
require.NoError(t, err)
require.NoError(t, tsp.Start(t.Context(), componenttest.NewNopHost()))
defer func() {
require.NoError(t, tsp.Shutdown(t.Context()))
}()
var expectedSpans atomic.Int64
wg := sync.WaitGroup{}
var combinedErr error
errCh := make(chan error, len(batches))
errDone := make(chan struct{})
go func() {
for err := range errCh {
combinedErr = errors.Join(combinedErr, err)
}
close(errDone)
}()
// For each batch, we consume the same trace repeatedly for at least 2x the decision wait time
// this ensures that batches are being consumed concurrently with policy evaluation.
for _, batch := range batches {
wg.Go(func() {
start := time.Now()
// The important thing here is that we are writing as close as
// possible to the moment when the policy is evaluated. We can't
// know exactly when that will happen, so we just write in a loop
// until the time must have passed.
for time.Since(start) < 2*cfg.DecisionWait {
expectedSpans.Add(int64(batch.SpanCount()))
err := tsp.ConsumeTraces(t.Context(), batch)
if err != nil {
errCh <- err
}
}
})
}
wg.Wait()
close(errCh)
<-errDone
require.NoError(t, combinedErr)
// verify
// despite all the concurrency above, we should eventually sample all the spans.
require.EventuallyWithT(t, func(collect *assert.CollectT) {
received := int64(msp.SpanCount())
expected := expectedSpans.Load()
missing := expected - received
require.Equal(collect, expected, received, "expected %d spans, received %d, missing %d", expected, received, missing)
}, 1*time.Second, 100*time.Millisecond)
}
func TestMultipleBatchesAreCombinedIntoOne(t *testing.T) {
controller := newTestTSPController()
msp := new(consumertest.TracesSink)
cfg := Config{
SamplingStrategy: samplingStrategyTraceComplete,
DecisionWait: defaultTestDecisionWait,
NumTraces: defaultNumTraces,
PolicyCfgs: []PolicyCfg{
{
sharedPolicyCfg: sharedPolicyCfg{
Name: "always",
Type: AlwaysSample,
},
},
},
Options: []Option{
withTestController(controller),
},
}
p, err := newTracesProcessor(t.Context(), processortest.NewNopSettings(metadata.Type), msp, cfg)
require.NoError(t, err)
require.NoError(t, p.Start(t.Context(), componenttest.NewNopHost()))
defer func() {
require.NoError(t, p.Shutdown(t.Context()))
}()
traceIDs, batches := generateIDsAndBatches(3)
for _, batch := range batches {
require.NoError(t, p.ConsumeTraces(t.Context(), batch))
}
controller.waitForTick() // the first tick always gets an empty batch
controller.waitForTick()
require.Len(t, msp.AllTraces(), 3, "There should be three batches, one for each trace")
expectedSpanIDs := make(map[int][]pcommon.SpanID)
expectedSpanIDs[0] = []pcommon.SpanID{
uInt64ToSpanID(uint64(1)),
}
expectedSpanIDs[1] = []pcommon.SpanID{
uInt64ToSpanID(uint64(2)),
uInt64ToSpanID(uint64(3)),
}
expectedSpanIDs[2] = []pcommon.SpanID{
uInt64ToSpanID(uint64(4)),
uInt64ToSpanID(uint64(5)),
uInt64ToSpanID(uint64(6)),
}
receivedTraces := msp.AllTraces()
for i, traceID := range traceIDs {
trace := findTrace(t, receivedTraces, traceID)
require.Equal(t, i+1, trace.SpanCount(), "The trace should have all of its spans in a single batch")
expected := expectedSpanIDs[i]
got := collectSpanIDs(trace)
// might have received out of order, sort for comparison
sort.Slice(got, func(i, j int) bool {
bytesA := got[i]
a := binary.BigEndian.Uint64(bytesA[:])
bytesB := got[j]
b := binary.BigEndian.Uint64(bytesB[:])
return a < b
})
require.Equal(t, expected, got)
}
}
func TestSetSamplingPolicy(t *testing.T) {
controller := newTestTSPController()
msp := new(consumertest.TracesSink)
telem := setupTestTelemetry()
cfg := Config{
SamplingStrategy: samplingStrategyTraceComplete,
DecisionWait: defaultTestDecisionWait,
NumTraces: defaultNumTraces,
PolicyCfgs: []PolicyCfg{
{
sharedPolicyCfg: sharedPolicyCfg{
Name: "only-metrics",
Type: StringAttribute,
StringAttributeCfg: StringAttributeCfg{
Key: "url.path",
Values: []string{"/metrics"},
},
},
},
},
Options: []Option{
withTestController(controller),
},
}
p, err := newTracesProcessor(t.Context(), telem.newSettings(), msp, cfg)
require.NoError(t, err)
require.NoError(t, p.Start(t.Context(), componenttest.NewNopHost()))
defer func() {
require.NoError(t, p.Shutdown(t.Context()))
}()
// Send some metrics traces and confirm they are sampled
metricsTrace := simpleTracesWithID(uInt64ToTraceID(1))
metricsTrace.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(0).Attributes().PutStr("url.path", "/metrics")
healthTrace := simpleTracesWithID(uInt64ToTraceID(2))
healthTrace.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(0).Attributes().PutStr("url.path", "/health")
require.NoError(t, p.ConsumeTraces(t.Context(), metricsTrace))
require.NoError(t, p.ConsumeTraces(t.Context(), healthTrace))
controller.waitForTick()
controller.waitForTick()
assert.Len(t, msp.AllTraces(), 1)
assert.Equal(t, uInt64ToTraceID(1), msp.AllTraces()[0].ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(0).TraceID())
msp.Reset()
cfgs := []PolicyCfg{
{
sharedPolicyCfg: sharedPolicyCfg{
Name: "only-health",
Type: StringAttribute,
StringAttributeCfg: StringAttributeCfg{
Key: "url.path",
Values: []string{"/health"},
},
},
},
}
p.(*tailSamplingSpanProcessor).SetSamplingPolicy(cfgs)
controller.waitForTick()
metricsTrace = simpleTracesWithID(uInt64ToTraceID(3))
metricsTrace.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(0).Attributes().PutStr("url.path", "/metrics")
healthTrace = simpleTracesWithID(uInt64ToTraceID(4))
healthTrace.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(0).Attributes().PutStr("url.path", "/health")
require.NoError(t, p.ConsumeTraces(t.Context(), metricsTrace))
require.NoError(t, p.ConsumeTraces(t.Context(), healthTrace))
controller.waitForTick()
controller.waitForTick()
assert.Len(t, msp.AllTraces(), 1)
assert.Equal(t, uInt64ToTraceID(4), msp.AllTraces()[0].ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(0).TraceID())
}
func TestSubSecondDecisionTime(t *testing.T) {
// prepare
msp := new(consumertest.TracesSink)
tsp, err := newTracesProcessor(t.Context(), processortest.NewNopSettings(metadata.Type), msp, Config{
SamplingStrategy: samplingStrategyTraceComplete,
DecisionWait: 500 * time.Millisecond,
NumTraces: defaultNumTraces,
PolicyCfgs: testPolicy,
Options: []Option{
withTickerFrequency(10 * time.Millisecond),
},
})
require.NoError(t, err)
require.NoError(t, tsp.Start(t.Context(), componenttest.NewNopHost()))
defer func() {
require.NoError(t, tsp.Shutdown(t.Context()))
}()
// test
require.NoError(t, tsp.ConsumeTraces(t.Context(), simpleTraces()))
// verify
require.Eventually(t, func() bool {
return len(msp.AllTraces()) == 1
}, time.Second, 10*time.Millisecond)
}
func TestPolicyLoggerAddsPolicyName(t *testing.T) {
// prepare
zc, logs := observer.New(zap.DebugLevel)
logger := zap.New(zc)
set := componenttest.NewNopTelemetrySettings()
set.Logger = logger
cfg := &sharedPolicyCfg{
Type: AlwaysSample, // we test only one evaluator
}
evaluator, err := getSharedPolicyEvaluator(set, cfg, nil)
require.NoError(t, err)
// test
_, err = evaluator.Evaluate(t.Context(), pcommon.TraceID{}, nil)
require.NoError(t, err)
// verify
assert.Len(t, logs.All(), 1)
assert.Equal(t, AlwaysSample, logs.All()[0].ContextMap()["policy"])
}
func TestDuplicatePolicyName(t *testing.T) {
// prepare
msp := new(consumertest.TracesSink)
alwaysSample := sharedPolicyCfg{
Name: "always_sample",
Type: AlwaysSample,
}
p, err := newTracesProcessor(t.Context(), processortest.NewNopSettings(metadata.Type), msp, Config{
SamplingStrategy: samplingStrategyTraceComplete,
DecisionWait: defaultTestDecisionWait,
NumTraces: defaultNumTraces,
PolicyCfgs: []PolicyCfg{
{sharedPolicyCfg: alwaysSample},
{sharedPolicyCfg: alwaysSample},
},
})
require.NoError(t, err)
err = p.Start(t.Context(), componenttest.NewNopHost())
defer func() {
err = p.Shutdown(t.Context())
require.NoError(t, err)
}()
// verify
assert.Equal(t, err, errors.New(`duplicate policy name "always_sample"`))
}
func TestDropPolicyIsFirstInPolicyList(t *testing.T) {
controller := newTestTSPController()
msp := new(consumertest.TracesSink)
cfg := Config{
SamplingStrategy: samplingStrategyTraceComplete,
DecisionWait: defaultTestDecisionWait,
NumTraces: defaultNumTraces,
PolicyCfgs: []PolicyCfg{
{
sharedPolicyCfg: sharedPolicyCfg{
Name: "regular-policy",
Type: AlwaysSample,
},
},
{
sharedPolicyCfg: sharedPolicyCfg{
Name: "drop-metrics-policy",
Type: Drop,
},
DropCfg: DropCfg{
SubPolicyCfg: []AndSubPolicyCfg{
{
sharedPolicyCfg: sharedPolicyCfg{
Name: "drop-metrics-policy",
Type: StringAttribute,
StringAttributeCfg: StringAttributeCfg{
Key: "url.path",
Values: []string{"/metrics"},
},
},
},
},
},
},
},
Options: []Option{
withTestController(controller),
},
}
p, err := newTracesProcessor(t.Context(), processortest.NewNopSettings(metadata.Type), msp, cfg)
require.NoError(t, err)
err = p.Start(t.Context(), componenttest.NewNopHost())
require.NoError(t, err)
defer func() {
err := p.Shutdown(t.Context())
require.NoError(t, err)
}()
metricsTrace := simpleTracesWithID(uInt64ToTraceID(1))
metricsTrace.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(0).Attributes().PutStr("url.path", "/metrics")
require.NoError(t, p.ConsumeTraces(t.Context(), metricsTrace))
healthTrace := simpleTracesWithID(uInt64ToTraceID(2))
healthTrace.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(0).Attributes().PutStr("url.path", "/health")
require.NoError(t, p.ConsumeTraces(t.Context(), healthTrace))
controller.waitForTick()
controller.waitForTick()
assert.Len(t, msp.AllTraces(), 1, "Health trace should be sampled")
sampledTraceIDs := make(map[pcommon.TraceID]struct{})
for _, trace := range msp.AllTraces() {
sampledTraceIDs[trace.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(0).TraceID()] = struct{}{}
}
require.Len(t, sampledTraceIDs, 1)
assert.Contains(t, sampledTraceIDs, uInt64ToTraceID(2))
}
func TestDecisionHooks(t *testing.T) {
controller := newTestTSPController()
// Track hook invocations
var sampledHookCalls []struct {
id pcommon.TraceID
td *TraceData
}
var nonSampledHookCalls []struct {
id pcommon.TraceID
td *TraceData
}
sampledHook := func(_ context.Context, id pcommon.TraceID, td *TraceData) {
sampledHookCalls = append(sampledHookCalls, struct {
id pcommon.TraceID
td *TraceData
}{id: id, td: td})
}
nonSampledHook := func(_ context.Context, id pcommon.TraceID, td *TraceData) {
nonSampledHookCalls = append(nonSampledHookCalls, struct {
id pcommon.TraceID
td *TraceData
}{id: id, td: td})
}
cfg := Config{
SamplingStrategy: samplingStrategyTraceComplete,
DecisionWait: defaultTestDecisionWait,
NumTraces: defaultNumTraces,
PolicyCfgs: []PolicyCfg{
{
sharedPolicyCfg: sharedPolicyCfg{
Name: "sample-high-latency",
Type: Latency,
LatencyCfg: LatencyCfg{
ThresholdMs: 100,
},
},
},
},
Options: []Option{
withTestController(controller),
WithSampledHooks(sampledHook),
WithNonSampledHooks(nonSampledHook),
},
}
msp := new(consumertest.TracesSink)
p, err := newTracesProcessor(t.Context(), processortest.NewNopSettings(metadata.Type), msp, cfg)
require.NoError(t, err)
require.NoError(t, p.Start(t.Context(), componenttest.NewNopHost()))
defer func() {
require.NoError(t, p.Shutdown(t.Context()))
}()
// Create a trace that will be sampled (high latency)
sampledTraceID := uInt64ToTraceID(1)
sampledTrace := simpleTracesWithID(sampledTraceID)
sampledTrace.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(0).SetStartTimestamp(pcommon.NewTimestampFromTime(time.Now().Add(-200 * time.Millisecond)))
sampledTrace.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(0).SetEndTimestamp(pcommon.NewTimestampFromTime(time.Now()))
// Create a trace that will not be sampled (low latency)
nonSampledTraceID := uInt64ToTraceID(2)
nonSampledTrace := simpleTracesWithID(nonSampledTraceID)
nonSampledTrace.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(0).SetStartTimestamp(pcommon.NewTimestampFromTime(time.Now().Add(-50 * time.Millisecond)))
nonSampledTrace.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(0).SetEndTimestamp(pcommon.NewTimestampFromTime(time.Now()))
require.NoError(t, p.ConsumeTraces(t.Context(), sampledTrace))
require.NoError(t, p.ConsumeTraces(t.Context(), nonSampledTrace))
controller.waitForTick() // First tick does nothing
controller.waitForTick() // Second tick makes decisions
// Verify hooks were called
require.Len(t, sampledHookCalls, 1, "sampled hook should be called once")
require.Len(t, nonSampledHookCalls, 1, "non-sampled hook should be called once")
// Verify sampled hook data
sampledCall := sampledHookCalls[0]
assert.Equal(t, sampledTraceID, sampledCall.id)
assert.NotNil(t, sampledCall.td)
assert.Equal(t, samplingpolicy.Sampled, sampledCall.td.FinalDecision)
assert.Equal(t, "sample-high-latency", sampledCall.td.PolicyName)
assert.Equal(t, int64(1), sampledCall.td.SpanCount)
// Verify non-sampled hook data
nonSampledCall := nonSampledHookCalls[0]
assert.Equal(t, nonSampledTraceID, nonSampledCall.id)
assert.NotNil(t, nonSampledCall.td)
assert.Equal(t, samplingpolicy.NotSampled, nonSampledCall.td.FinalDecision)
assert.Empty(t, nonSampledCall.td.PolicyName, "PolicyName should be empty for not sampled traces")
assert.Equal(t, int64(1), nonSampledCall.td.SpanCount)
}
func collectSpanIDs(trace ptrace.Traces) []pcommon.SpanID {
var spanIDs []pcommon.SpanID
for i := 0; i < trace.ResourceSpans().Len(); i++ {
ilss := trace.ResourceSpans().At(i).ScopeSpans()
for j := 0; j < ilss.Len(); j++ {
ils := ilss.At(j)
for k := 0; k < ils.Spans().Len(); k++ {
span := ils.Spans().At(k)
spanIDs = append(spanIDs, span.SpanID())
}
}
}
return spanIDs
}
func findTrace(t *testing.T, a []ptrace.Traces, traceID pcommon.TraceID) ptrace.Traces {
for _, batch := range a {
id := batch.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(0).TraceID()
if traceID == id {
return batch
}
}
t.Fatalf("Trace was not received. TraceId %s", traceID)
return ptrace.Traces{}
}