fix pkg/golden

Author: dmathieu

pkg/golden/golden_test.go

@@ -368,25 +368,26 @@ func TestProfilesRoundTrip(t *testing.T) {
 
 func CreateTestProfiles() pprofile.Profiles {
 	profiles := pprofile.NewProfiles()
+	dic := profiles.ProfilesDictionary()
 	resource := profiles.ResourceProfiles().AppendEmpty()
 	scope := resource.ScopeProfiles().AppendEmpty()
 	profile := scope.Profiles().AppendEmpty()
 
-	profile.StringTable().Append("samples", "count", "cpu", "nanoseconds")
+	dic.StringTable().Append("samples", "count", "cpu", "nanoseconds")
 	st := profile.SampleType().AppendEmpty()
 	st.SetTypeStrindex(0)
 	st.SetUnitStrindex(1)
 	pt := profile.PeriodType()
 	pt.SetTypeStrindex(2)
 	pt.SetUnitStrindex(3)
 
-	a := profile.AttributeTable().AppendEmpty()
+	a := dic.AttributeTable().AppendEmpty()
 	a.SetKey("process.executable.build_id.htlhash")
 	a.Value().SetStr("600DCAFE4A110000F2BF38C493F5FB92")
-	a = profile.AttributeTable().AppendEmpty()
+	a = dic.AttributeTable().AppendEmpty()
 	a.SetKey("profile.frame.type")
 	a.Value().SetStr("native")
-	a = profile.AttributeTable().AppendEmpty()
+	a = dic.AttributeTable().AppendEmpty()
 	a.SetKey("host.id")
 	a.Value().SetStr("localhost")
 
@@ -396,10 +397,10 @@ func CreateTestProfiles() pprofile.Profiles {
 	sample.TimestampsUnixNano().Append(0)
 	sample.SetLocationsLength(1)
 
-	m := profile.MappingTable().AppendEmpty()
+	m := dic.MappingTable().AppendEmpty()
 	m.AttributeIndices().Append(0)
 
-	l := profile.LocationTable().AppendEmpty()
+	l := dic.LocationTable().AppendEmpty()
 	l.SetMappingIndex(0)
 	l.SetAddress(111)
 	l.AttributeIndices().Append(1)

pkg/golden/testdata/profiles-roundtrip/expected.yaml

@@ -1,27 +1,33 @@
+dictionary:
+  attributeTable:
+    - key: process.executable.build_id.htlhash
+      value:
+        stringValue: 600DCAFE4A110000F2BF38C493F5FB92
+    - key: profile.frame.type
+      value:
+        stringValue: native
+    - key: host.id
+      value:
+        stringValue: localhost
+  locationTable:
+    - address: "111"
+      attributeIndices:
+        - 1
+      mappingIndex: 0
+  mappingTable:
+    - attributeIndices:
+        - 0
+  stringTable:
+    - samples
+    - count
+    - cpu
+    - nanoseconds
 resourceProfiles:
   - resource: {}
     scopeProfiles:
       - profiles:
           - attributeIndices:
               - 2
-            attributeTable:
-              - key: process.executable.build_id.htlhash
-                value:
-                  stringValue: 600DCAFE4A110000F2BF38C493F5FB92
-              - key: profile.frame.type
-                value:
-                  stringValue: native
-              - key: host.id
-                value:
-                  stringValue: localhost
-            locationTable:
-              - address: "111"
-                attributeIndices:
-                  - 1
-                mappingIndex: 0
-            mappingTable:
-              - attributeIndices:
-                  - 0
             periodType:
               typeStrindex: 2
               unitStrindex: 3
@@ -32,9 +38,4 @@ resourceProfiles:
                   - "0"
             sampleType:
               - unitStrindex: 1
-            stringTable:
-              - samples
-              - count
-              - cpu
-              - nanoseconds
         scope: {}