Commit 45cc538
committed
[extension/encoding/googlecloudlogentryencoding] accept short ALPN protocol tokens
handleHTTPRequestField required exactly one "/" in the protocol string,
rejecting tokens like "h2" that Google Cloud Load Balancers started using
for HTTP/2 in late 2024. This silently dropped affected log entries.
Relax the check: if the protocol string contains no "/", store it as-is
in network.protocol.name and omit network.protocol.version. If a "/"
is present the existing validation (both sides must be non-empty) still
applies.
Fixes #45214
Signed-off-by: alliasgher <alliasgher123@gmail.com>1 parent bedd81d commit 45cc538
3 files changed
Lines changed: 43 additions & 13 deletions
File tree
- .chloggen
- extension/encoding/googlecloudlogentryencodingextension
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
Lines changed: 15 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
232 | 232 | | |
233 | 233 | | |
234 | 234 | | |
235 | | - | |
| 235 | + | |
236 | 236 | | |
237 | | - | |
| 237 | + | |
238 | 238 | | |
239 | 239 | | |
240 | 240 | | |
241 | | - | |
242 | | - | |
243 | | - | |
244 | | - | |
245 | | - | |
246 | | - | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
247 | 254 | | |
248 | | - | |
249 | | - | |
250 | 255 | | |
251 | 256 | | |
252 | 257 | | |
| |||
Lines changed: 23 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
115 | | - | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
116 | 118 | | |
117 | | - | |
| 119 | + | |
118 | 120 | | |
119 | | - | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
120 | 140 | | |
121 | 141 | | |
122 | 142 | | |
| |||
0 commit comments