Apply suggestions

Author: alexcams

pkg/ottl/ottlfuncs/func_base64encode.go

@@ -27,10 +27,10 @@ func createBase64EncodeFunction[K any](_ ottl.FunctionContext, oArgs ottl.Argume
 		return nil, errors.New("Base64EncodeFactory args must be of type *Base64EncodeArguments[K]")
 	}
 
-	return Base64Encode(args.Target, args.Variant)
+	return base64Encode(args.Target, args.Variant), nil
 }
 
-func Base64Encode[K any](target ottl.StringGetter[K], variant ottl.Optional[ottl.StringGetter[K]]) (ottl.ExprFunc[K], error) {
+func base64Encode[K any](target ottl.StringGetter[K], variant ottl.Optional[ottl.StringGetter[K]]) ottl.ExprFunc[K] {
 	return func(ctx context.Context, tCtx K) (any, error) {
 		str, err := target.Get(ctx, tCtx)
 		if err != nil {
@@ -59,5 +59,5 @@ func Base64Encode[K any](target ottl.StringGetter[K], variant ottl.Optional[ottl
 		default:
 			return nil, fmt.Errorf("unsupported base64 variant: %s", variantVal)
 		}
-	}, nil
+	}
 }

pkg/ottl/ottlfuncs/func_base64encode_test.go

@@ -14,8 +14,6 @@ import (
 )
 
 func TestBase64Encode(t *testing.T) {
-	testValue := pcommon.NewValueStr("test string")
-
 	type testCase struct {
 		name          string
 		value         any
@@ -36,7 +34,7 @@ func TestBase64Encode(t *testing.T) {
 		},
 		{
 			name:  "convert Value to base64 (default variant)",
-			value: testValue,
+			value: pcommon.NewValueStr("test string"),
 			want:  "dGVzdCBzdHJpbmc=",
 		},
 		{