Skip to content

Commit 90d004b

Browse files
authored
[chore] Pass runCtx into supervisor Health check test (#43681)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Without a valid `runCtx`, anything that attempts to use the context segfaults. In open-telemetry/opentelemetry-collector#14058 I am using the context, so this test borks. This adds the runCtx to fix it. <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue open-telemetry/opentelemetry-collector#14058 <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> Signed-off-by: sinkingpoint <[email protected]>
1 parent 355c59d commit 90d004b

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

cmd/opampsupervisor/supervisor/supervisor_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2189,6 +2189,7 @@ func TestSupervisor_HealthCheckServer(t *testing.T) {
21892189

21902190
t.Run("Health check server errors out if port is in-use", func(t *testing.T) {
21912191
newSupervisor := &Supervisor{
2192+
runCtx: t.Context(),
21922193
telemetrySettings: newNopTelemetrySettings(),
21932194
persistentState: &persistentState{InstanceID: testUUID},
21942195
cfgState: &atomic.Value{},

0 commit comments

Comments
 (0)