[chore] handle breaking change in pdata/pprofile

open-telemetry/opentelemetry-collector#15517 is a breaking change to prevent a panic. Handle this change for OTel collector contrib.

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>

Author: florianl

.chloggen/collector-15517.yaml

@@ -0,0 +1,27 @@
+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: 'breaking'   
+
+# The name of the component, or a single word describing the area of concern, (e.g. receiver/filelog)
+component: all
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: handle breaking change in pdata/pprofile
+
+# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
+issues: []
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext:
+
+# If your change doesn't affect end users or the exported elements of any package,
+# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
+# Optional: The change log or logs in which this entry should be included.
+# e.g. '[user]' or '[user, api]'
+# Include 'user' if the change is relevant to end users.
+# Include 'api' if there is a change to a library API.
+# Default: '[user]'
+change_logs: [api]

connector/countconnector/connector.go

@@ -247,8 +247,12 @@ func (c *count) ConsumeProfiles(ctx context.Context, ld pprofile.Profiles) error
 				profile := scopeProfile.Profiles().At(k)
 				counter.updateTimestamp(profile.Time())
 				pCtx := ottlprofile.NewTransformContextPtr(resourceProfile, scopeProfile, profile, ld.Dictionary())
-				attributes := pprofile.FromAttributeIndices(ld.Dictionary().AttributeTable(), profile, ld.Dictionary())
-				multiError = errors.Join(multiError, counter.update(ctx, attributes, scopeAttrs, resourceAttrs, pCtx))
+				attributes, attrErr := pprofile.FromAttributeIndices(ld.Dictionary().AttributeTable(), profile, ld.Dictionary())
+				if attrErr != nil {
+					multiError = errors.Join(multiError, attrErr)
+				} else {
+					multiError = errors.Join(multiError, counter.update(ctx, attributes, scopeAttrs, resourceAttrs, pCtx))
+				}
 				pCtx.Close()
 			}
 		}

connector/signaltometricsconnector/connector.go

@@ -346,7 +346,10 @@ func (sm *signalToMetrics) ConsumeProfiles(ctx context.Context, profiles pprofil
 
 			for k := 0; k < scopeProfile.Profiles().Len(); k++ {
 				profile := scopeProfile.Profiles().At(k)
-				profileAttrs := pprofile.FromAttributeIndices(profiles.Dictionary().AttributeTable(), profile, profiles.Dictionary())
+				profileAttrs, err := pprofile.FromAttributeIndices(profiles.Dictionary().AttributeTable(), profile, profiles.Dictionary())
+				if err != nil {
+					return fmt.Errorf("failed to get profile attributes: %w", err)
+				}
 				for mdIdx, md := range sm.profileMetricDefs {
 					if !md.MatchAttributes(profileAttrs) {
 						continue

exporter/elasticsearchexporter/internal/serializer/otelserializer/serializeprofiles/transform.go

@@ -83,7 +83,10 @@ func stackPayloads(dic pprofile.ProfilesDictionary, resource pcommon.Resource, s
 	unsymbolizedExecutablesSet := make(map[libpf.FileID]struct{})
 	stackPayload := make([]StackPayload, 0, profile.Samples().Len())
 
-	commonResourceAttributes := populateResourceData(dic, resource, scope, profile)
+	commonResourceAttributes, err := populateResourceData(dic, resource, scope, profile)
+	if err != nil {
+		return nil, fmt.Errorf("failed to populate resource data: %w", err)
+	}
 
 	frequency := int64(math.Round(1e9 / float64(profile.Period())))
 	if frequency <= 0 {
@@ -513,16 +516,20 @@ func int64ToBytes(value int64) []byte {
 	return buf
 }
 
-func populateResourceData(dic pprofile.ProfilesDictionary, resource pcommon.Resource, scope pcommon.InstrumentationScope, profile pprofile.Profile) map[string]string {
+func populateResourceData(dic pprofile.ProfilesDictionary, resource pcommon.Resource, scope pcommon.InstrumentationScope, profile pprofile.Profile) (map[string]string, error) {
 	numAttrs := resource.Attributes().Len() + scope.Attributes().Len() + profile.AttributeIndices().Len()
 	if numAttrs == 0 {
-		return map[string]string{}
+		return map[string]string{}, nil
 	}
 	attrs := make(map[string]string, numAttrs)
 
 	addEventHostData(attrs, resource.Attributes())
 	addEventHostData(attrs, scope.Attributes())
-	addEventHostData(attrs, pprofile.FromAttributeIndices(dic.AttributeTable(), profile, dic))
+	profileAttrs, err := pprofile.FromAttributeIndices(dic.AttributeTable(), profile, dic)
+	if err != nil {
+		return nil, err
+	}
+	addEventHostData(attrs, profileAttrs)
 
-	return attrs
+	return attrs, nil
 }

exporter/elasticsearchexporter/internal/serializer/otelserializer/serializeprofiles/transform_test.go

@@ -847,7 +847,8 @@ func TestStackTraceEvent(t *testing.T) {
 			p := rp.ScopeProfiles().At(0).Profiles().At(0)
 			s := p.Samples().At(0)
 
-			resourceAttrs := populateResourceData(dic, rp.Resource(), rp.ScopeProfiles().At(0).Scope(), p)
+			resourceAttrs, err := populateResourceData(dic, rp.Resource(), rp.ScopeProfiles().At(0).Scope(), p)
+			require.NoError(t, err)
 			event := stackTraceEvent(dic, stacktraceIDBase64, s, 20, resourceAttrs)
 			event.TimeStamp = newUnixTime64(tt.timestamp)
 

pkg/ottl/contexts/internal/ctxprofilecommon/attributes.go

@@ -23,7 +23,7 @@ func AccessAttributes[K any](source attributeSource[K]) ottl.StandardGetSetter[K
 	return ottl.StandardGetSetter[K]{
 		Getter: func(_ context.Context, tCtx K) (any, error) {
 			dict, attributable := source(tCtx)
-			return pprofile.FromAttributeIndices(dict.AttributeTable(), attributable, dict), nil
+			return pprofile.FromAttributeIndices(dict.AttributeTable(), attributable, dict)
 		},
 		Setter: func(_ context.Context, tCtx K, val any) error {
 			m, err := ctxutil.GetMap(val)
@@ -56,7 +56,11 @@ func AccessAttributesKey[K any](key []ottl.Key[K], source attributeSource[K]) ot
 	return ottl.StandardGetSetter[K]{
 		Getter: func(ctx context.Context, tCtx K) (any, error) {
 			dict, attributable := source(tCtx)
-			return ctxutil.GetMapValue[K](ctx, tCtx, pprofile.FromAttributeIndices(dict.AttributeTable(), attributable, dict), key)
+			m, err := pprofile.FromAttributeIndices(dict.AttributeTable(), attributable, dict)
+			if err != nil {
+				return nil, err
+			}
+			return ctxutil.GetMapValue[K](ctx, tCtx, m, key)
 		},
 		Setter: func(ctx context.Context, tCtx K, val any) error {
 			newKey, err := ctxutil.GetMapKeyName(ctx, tCtx, key[0])