Skip to content

Commit a96f868

Browse files
committed
pr review
Signed-off-by: odubajDT <[email protected]>
1 parent 0a6c7bc commit a96f868

File tree

7 files changed

+103
-195
lines changed

7 files changed

+103
-195
lines changed

.chloggen/k8sattributesprocessor-stable-observability.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ change_type: 'enhancement'
77
component: processor/k8sattributes
88

99
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10-
note: "Added processor-specific observability metrics: `processor_k8sattributes_pod_association_success`, `processor_k8sattributes_pod_association_error`, and `processor_k8sattributes_resource_attributes_added` with k8s_telemetry_type attribute for signal differentiation"
10+
note: "Added processor-specific observability metrics: `otelsvc_k8s_pod_association` with `k8s_telemetry_type` and `status` attributes for signal and type differentiation"
1111

1212
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
1313
issues: [44587]

processor/k8sattributesprocessor/documentation.md

Lines changed: 15 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,21 @@ Number of pod add events received [Development]
105105
| ---- | ----------- | ---------- | --------- | --------- |
106106
| 1 | Sum | Int | true | Development |
107107

108+
### otelcol_otelsvc_k8s_pod_association
109+
110+
Number of pod associations [Development]
111+
112+
| Unit | Metric Type | Value Type | Monotonic | Stability |
113+
| ---- | ----------- | ---------- | --------- | --------- |
114+
| {resources} | Sum | Int | true | Development |
115+
116+
#### Attributes
117+
118+
| Name | Description | Values |
119+
| ---- | ----------- | ------ |
120+
| k8s_telemetry_type | The type of telemetry data being processed (traces, metrics, logs, profiles) | Str: ``traces``, ``metrics``, ``logs``, ``profiles`` |
121+
| status | The status of the pod association operation | Str: ``success``, ``error`` |
122+
108123
### otelcol_otelsvc_k8s_pod_deleted
109124

110125
Number of pod delete events received [Development]
@@ -152,45 +167,3 @@ Number of ReplicaSet update events received [Development]
152167
| Unit | Metric Type | Value Type | Monotonic | Stability |
153168
| ---- | ----------- | ---------- | --------- | --------- |
154169
| 1 | Sum | Int | true | Development |
155-
156-
### otelcol_processor_k8sattributes_pod_association_error
157-
158-
Number of failed pod associations [Development]
159-
160-
| Unit | Metric Type | Value Type | Monotonic | Stability |
161-
| ---- | ----------- | ---------- | --------- | --------- |
162-
| {resources} | Sum | Int | true | Development |
163-
164-
#### Attributes
165-
166-
| Name | Description | Values |
167-
| ---- | ----------- | ------ |
168-
| k8s_telemetry_type | The type of telemetry data being processed (traces, metrics, logs, profiles) | Str: ``traces``, ``metrics``, ``logs``, ``profiles`` |
169-
170-
### otelcol_processor_k8sattributes_pod_association_success
171-
172-
Number of successful pod associations [Development]
173-
174-
| Unit | Metric Type | Value Type | Monotonic | Stability |
175-
| ---- | ----------- | ---------- | --------- | --------- |
176-
| {resources} | Sum | Int | true | Development |
177-
178-
#### Attributes
179-
180-
| Name | Description | Values |
181-
| ---- | ----------- | ------ |
182-
| k8s_telemetry_type | The type of telemetry data being processed (traces, metrics, logs, profiles) | Str: ``traces``, ``metrics``, ``logs``, ``profiles`` |
183-
184-
### otelcol_processor_k8sattributes_resource_attributes_added
185-
186-
Number of times resource attributes were successfully added to resources [Development]
187-
188-
| Unit | Metric Type | Value Type | Monotonic | Stability |
189-
| ---- | ----------- | ---------- | --------- | --------- |
190-
| {resources} | Sum | Int | true | Development |
191-
192-
#### Attributes
193-
194-
| Name | Description | Values |
195-
| ---- | ----------- | ------ |
196-
| k8s_telemetry_type | The type of telemetry data being processed (traces, metrics, logs, profiles) | Str: ``traces``, ``metrics``, ``logs``, ``profiles`` |

processor/k8sattributesprocessor/internal/metadata/generated_telemetry.go

Lines changed: 36 additions & 50 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

processor/k8sattributesprocessor/internal/metadatatest/generated_telemetrytest.go

Lines changed: 16 additions & 48 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

processor/k8sattributesprocessor/internal/metadatatest/generated_telemetrytest_test.go

Lines changed: 4 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

processor/k8sattributesprocessor/metadata.yaml

Lines changed: 16 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,12 @@ attributes:
149149
- metrics
150150
- logs
151151
- profiles
152+
status:
153+
description: The status of the pod association operation
154+
type: string
155+
enum:
156+
- success
157+
- error
152158

153159
telemetry:
154160
metrics:
@@ -305,6 +311,16 @@ telemetry:
305311
sum:
306312
value_type: int
307313
monotonic: true
314+
otelsvc_k8s_pod_association:
315+
enabled: true
316+
description: Number of pod associations
317+
stability:
318+
level: development
319+
unit: "{resources}"
320+
attributes: [k8s_telemetry_type, status]
321+
sum:
322+
value_type: int
323+
monotonic: true
308324
otelsvc_k8s_pod_deleted:
309325
enabled: true
310326
description: Number of pod delete events received
@@ -385,34 +401,4 @@ telemetry:
385401
sum:
386402
value_type: int
387403
monotonic: true
388-
processor_k8sattributes_pod_association_error:
389-
enabled: true
390-
description: Number of failed pod associations
391-
stability:
392-
level: development
393-
unit: "{resources}"
394-
attributes: [k8s_telemetry_type]
395-
sum:
396-
value_type: int
397-
monotonic: true
398-
processor_k8sattributes_pod_association_success:
399-
enabled: true
400-
description: Number of successful pod associations
401-
stability:
402-
level: development
403-
unit: "{resources}"
404-
attributes: [k8s_telemetry_type]
405-
sum:
406-
value_type: int
407-
monotonic: true
408-
processor_k8sattributes_resource_attributes_added:
409-
enabled: true
410-
description: Number of times resource attributes were successfully added to resources
411-
stability:
412-
level: development
413-
unit: "{resources}"
414-
attributes: [k8s_telemetry_type]
415-
sum:
416-
value_type: int
417-
monotonic: true
418404

0 commit comments

Comments
 (0)