Skip to content

Commit a9c1681

Browse files
authored
[extension/jaegerremotesampling] remove stabilized feature gate (#47553)
The gate was marked stable in v0.91.0, time to remove it. --------- Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
1 parent 7a10a5e commit a9c1681

4 files changed

Lines changed: 28 additions & 15 deletions

File tree

.chloggen/codeboten_rm-fg.yaml

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: breaking
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. receiver/filelog)
7+
component: extension/jaegerremotesampling
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: Remove replaceThriftWithProto feature gate.
11+
12+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
13+
issues: [47553]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# If your change doesn't affect end users or the exported elements of any package,
21+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
22+
# Optional: The change log or logs in which this entry should be included.
23+
# e.g. '[user]' or '[user, api]'
24+
# Include 'user' if the change is relevant to end users.
25+
# Include 'api' if there is a change to a library API.
26+
# Default: '[user]'
27+
change_logs: []

.golangci.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -149,9 +149,6 @@ linters:
149149
- linters:
150150
- forbidigo
151151
path: extension/encoding/awslogsencodingextension/
152-
- linters:
153-
- forbidigo
154-
path: extension/jaegerremotesampling/
155152
- linters:
156153
- forbidigo
157154
path: extension/opampextension/

extension/jaegerremotesampling/factory.go

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import (
1212
"go.opentelemetry.io/collector/config/confighttp"
1313
"go.opentelemetry.io/collector/config/confignet"
1414
"go.opentelemetry.io/collector/extension"
15-
"go.opentelemetry.io/collector/featuregate"
1615
"go.uber.org/zap"
1716

1817
"github.com/open-telemetry/opentelemetry-collector-contrib/extension/jaegerremotesampling/internal/metadata"
@@ -55,16 +54,6 @@ func logDeprecation(logger *zap.Logger) {
5554
})
5655
}
5756

58-
//nolint:unused
59-
var protoGate = featuregate.GlobalRegistry().MustRegister(
60-
"extension.jaegerremotesampling.replaceThriftWithProto",
61-
featuregate.StageStable,
62-
featuregate.WithRegisterDescription(
63-
"When enabled, the jaegerremotesampling will use Proto-gen over Thrift-gen.",
64-
),
65-
featuregate.WithRegisterToVersion("0.92.0"),
66-
)
67-
6857
func createExtension(_ context.Context, set extension.Settings, cfg component.Config) (extension.Extension, error) {
6958
logDeprecation(set.Logger)
7059
return newExtension(cfg.(*Config), set.TelemetrySettings), nil

extension/jaegerremotesampling/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ require (
2020
go.opentelemetry.io/collector/confmap/xconfmap v0.150.0
2121
go.opentelemetry.io/collector/extension v1.56.0
2222
go.opentelemetry.io/collector/extension/extensiontest v0.150.0
23-
go.opentelemetry.io/collector/featuregate v1.56.0
2423
go.uber.org/goleak v1.3.0
2524
go.uber.org/zap v1.27.1
2625
google.golang.org/grpc v1.80.0
@@ -63,6 +62,7 @@ require (
6362
go.opentelemetry.io/collector/config/configoptional v1.56.0 // indirect
6463
go.opentelemetry.io/collector/extension/extensionauth v1.56.0 // indirect
6564
go.opentelemetry.io/collector/extension/extensionmiddleware v0.150.0 // indirect
65+
go.opentelemetry.io/collector/featuregate v1.56.0 // indirect
6666
go.opentelemetry.io/collector/internal/componentalias v0.150.0 // indirect
6767
go.opentelemetry.io/collector/pdata v1.56.0 // indirect
6868
go.opentelemetry.io/collector/pipeline v1.56.0 // indirect

0 commit comments

Comments
 (0)