Commit d38d1f9
authored
fix(processor/schema): fetch target schema URL on upgrade path (#47632)
#### Description
When upgrading a signal (incoming version older than the configured
target), the manager was fetching the incoming signal's schema URL to
retrieve the schema file. Real OTel schema files only contain history up
to their own version — an incoming `1.21.0` schema file has no knowledge
of changes made in `1.22.0`–`1.27.0`. The translator found no matching
revisions and silently returned `NoChange`, meaning no attributes were
ever renamed on the upgrade path.
The fix: for upgrades, fetch the **target** schema URL instead. The
target schema file contains the complete forward migration history.
Downgrades correctly continue to fetch the incoming signal's (newer)
URL, since that file contains the history needed to reverse changes.
#### Link to tracking issue
Fixes #47427
#### Testing
Added `TestRequestTranslationUpgrade` in `manager_test.go`. It uses a
URL-aware HTTP server that serves a stub schema (no forward history) for
old version URLs and the full schema only at the target URL. This
proves:
1. The fix correctly fetches the target URL on the upgrade path
2. The attribute rename defined in the target schema
(`db.cassandra.keyspace` → `db.name`) is applied
3. Without the fix, the test fails because the stub schema has no
revisions to apply
#### Documentation
No documentation changes required — this is a bug fix for behaviour that
was never working correctly.1 parent 4682913 commit d38d1f9
3 files changed
Lines changed: 87 additions & 2 deletions
File tree
- .chloggen
- processor/schemaprocessor/internal/translation
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
Lines changed: 10 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
98 | 106 | | |
99 | | - | |
| 107 | + | |
100 | 108 | | |
101 | 109 | | |
102 | 110 | | |
103 | | - | |
| 111 | + | |
104 | 112 | | |
105 | 113 | | |
106 | 114 | | |
| |||
Lines changed: 66 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| 18 | + | |
17 | 19 | | |
18 | 20 | | |
19 | 21 | | |
| |||
66 | 68 | | |
67 | 69 | | |
68 | 70 | | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
69 | 135 | | |
70 | 136 | | |
71 | 137 | | |
| |||
0 commit comments