Skip to content

Commit f53f700

Browse files
committed
apply review's suggestion
1 parent ddb4a29 commit f53f700

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

.chloggen/fix-42462.yaml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,10 @@ subtext: |
2020
Currently, the feature gate is enabled by default, so the unit will remain `ms`. After one or two release cycles, the unit will switch to `s` and the feature gate will also be disabled by default.
2121
To revert this change manually, users can either enable the feature gate or modify the configuration as follows:
2222
```
23-
spanmetrics:
24-
histogram:
25-
unit: "ms"
23+
connectors
24+
spanmetrics:
25+
histogram:
26+
unit: "ms"
2627
```
2728
2829
# If your change doesn't affect end users or the exported elements of any package,

connector/spanmetricsconnector/factory.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ func init() {
5050
)
5151
legacyDefaultMetricsUnit = featuregate.GlobalRegistry().MustRegister(
5252
legacyDefaultMetricsUnitFeatureGateID,
53-
featuregate.StageBeta, // current enabled by default and disable it in the feature release
53+
featuregate.StageBeta, // current enabled by default and disable it in the next release
5454
featuregate.WithRegisterDescription("enabled by default, connector use ms unit for duration metrics."),
5555
featuregate.WithRegisterReferenceURL("https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/42103"),
5656
)

0 commit comments

Comments
 (0)