Skip to content

Tail Sampler: Improve Rate Limit Algorithm #1651

Open
@chris-smith-zocdoc

Description

@chris-smith-zocdoc

Describe the solution you'd like
The current rate_limiting algorithm enforces a strict spans per second limit which has a couple of flaws:

  • Traces with more spans than the span/sec limit cannot be sampled, they are always dropped
  • Variations in the arrival rate of spans cannot be used to "burst" and temporarily consume previously unused capacity. This is desirable when the exact spans/sec rate is not required and the capacity can be spread over minutes or hours.

Describe alternatives you've considered
A token bucket or leaky bucket implementation would be useful

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestnever staleIssues marked with this label will be never staled and automatically removedprocessor/tailsamplingTail sampling processorspec:trace

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions