[receiver/hostmetrics] Rename memory state attribute to system.memory.state

[rogercoll]

Component(s)

receiver/hostmetrics

Is your feature request related to a problem? Please describe.

state attribute in the memory scrapper should be renamed to system.memory.state for alignment with semantic conventions: https://github.com/rogercoll/semantic-conventions/blob/a77e59d1f1ffe6cebf7622a9eee7c25a326d7ac7/model/registry/system.yaml#L33

Describe the solution you'd like

Rename state attribute to system.memory.state under a feature gate.

Describe alternatives you've considered

No response

Additional context

No response

[github-actions]

Pinging code owners:

• receiver/hostmetrics: @dmitryax @braydonk

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[crobert-1]

Makes sense to me, agreed that they should match.

One thing I'm a bit unfamiliar with, I see valid values for upstream's semantic conventions don't match with the receiver attribute's valid values. Do we also have to consolidate those values, or is it acceptable to keep existing values? (Open question to anyone who would know).

[braydonk]

We have a transition plan to move everything over. Roughly:

• There will be a semantic conventions featuregate for the receiver (I had intended to do this by now but work got in the way; it's still on my list)
• Under that featuregate, metrics and attributes will use new names
• When the semantic conventions are stabilized upstream, we will ensure they are all reflected under the featuregate
• After some time the featuregate will go beta (on by default), and eventually the featuregate will be removed and only the new names will exist

[odubajDT]

Hi, I would like to look at this issue

[rogercoll]

@odubajDT Thanks for involvement! I am not 100% if this issue is ready to be contributed yet, as it should be implemented under a semantic conventions feature gate that will wrap the latest system metric changes. Like #32712 and #34311

I think @braydonk is currently working with the addition of this featuregate.

[braydonk]

Yes, unfortunately this is blocked right now. We want to have a proper guard in place, preferably with a feature gate, but there were some complications I had putting that in place. Changes are likely required to mdatagen, which I am working on but have been away quite a bit the last couple weeks.

[odubajDT]

All clear, thanks for the update!

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• receiver/hostmetrics: @dmitryax @braydonk

See Adding Labels via Comments if you do not have permissions to add labels yourself.