Skip to content

[receiver/kubeletstats] Enable re-aggregation feature#46455

Closed
rite7sh wants to merge 12 commits intoopen-telemetry:mainfrom
rite7sh:kubeletstats-enable-reaggregation
Closed

[receiver/kubeletstats] Enable re-aggregation feature#46455
rite7sh wants to merge 12 commits intoopen-telemetry:mainfrom
rite7sh:kubeletstats-enable-reaggregation

Conversation

@rite7sh
Copy link
Copy Markdown
Contributor

@rite7sh rite7sh commented Feb 26, 2026

Description

Enables re-aggregation support for the kubeletstats receiver by updating metadata configuration.

This change adds the required reaggregation block and classifies all resource attributes and metric attributes with appropriate aggregation levels. The update is limited strictly to metadata and does not modify any metric definitions, names, or stability levels.


Link to tracking issue

Fixes #46363


Testing

  • Ran receiver module tests:

    go test ./receiver/kubeletstatsreceiver/...

  • Ran vet checks:

    go vet ./receiver/kubeletstatsreceiver/...

  • Verified metadata builds and parses correctly with no schema or structural errors.

No additional tests were required as this change only affects metadata configuration.


Documentation

No documentation changes required.

This update only enables re-aggregation support via metadata and does not change user-facing configuration or receiver behavior beyond aggregation capability.

@github-actions github-actions bot added the first-time contributor PRs made by new contributors label Feb 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better!

@paulojmdias
Copy link
Copy Markdown
Member

/workflow-approve

@rite7sh
Copy link
Copy Markdown
Contributor Author

rite7sh commented Feb 26, 2026

hey @paulojmdias i am pretty sure this does not require changelog entry can it be mentioned under skip changelog lable?
if not i would add the changelog entry if you say so.

@paulojmdias
Copy link
Copy Markdown
Member

/workflow-approve

@paulojmdias
Copy link
Copy Markdown
Member

paulojmdias commented Feb 26, 2026

@rite7sh I think this deserves a changelog entry, please add it

@paulojmdias
Copy link
Copy Markdown
Member

/workflow-approve

@rite7sh rite7sh force-pushed the kubeletstats-enable-reaggregation branch from e0dedd0 to 2747011 Compare March 1, 2026 12:46
@paulojmdias
Copy link
Copy Markdown
Member

/workflow-approve

@rite7sh
Copy link
Copy Markdown
Contributor Author

rite7sh commented Mar 1, 2026

I tried implementing the re-aggregation changes by adding reaggregation and level fields in metadata.yaml as described in the issue. However the CodeGen CI step fails with:
-invalid keys: level
-invalid keys: reaggregation
It seems the current metadata schema used by mdatagen may not support these fields yet. Leaving the changes here so it's easier to see what was attempted , happy to adjust once we know the expected approach. P.S.. This is just a suggestive approach :)

@rite7sh rite7sh force-pushed the kubeletstats-enable-reaggregation branch 3 times, most recently from 006b01d to ebccfa8 Compare March 11, 2026 20:18
Comment thread receiver/kubeletstatsreceiver/metadata.yaml Outdated
Comment thread receiver/kubeletstatsreceiver/metadata.yaml Outdated
@rite7sh rite7sh force-pushed the kubeletstats-enable-reaggregation branch from de80626 to 8021921 Compare March 12, 2026 08:26
@rite7sh
Copy link
Copy Markdown
Contributor Author

rite7sh commented Mar 12, 2026

@dmitryax please let me know if the changes look good to you whenever you can :)


description: |
The Kubelet Stats Receiver pulls node, pod, container, and volume metrics from the API server on a kubelet
and sends it down the metric pipeline for further processing.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why description removed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh my bad, i will revert it back to as needed.

aws.volume.id:
description: "[DEPRECATED] The id of the AWS Volume"
enabled: true
requirement_level: opt_in
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need requirement_level on resource_attributes yet. Only on attributes

@dmitryax
Copy link
Copy Markdown
Member

dmitryax commented Mar 15, 2026

It needs another merge from main and re-generating the go files

@rite7sh rite7sh force-pushed the kubeletstats-enable-reaggregation branch from b8bf339 to d138e00 Compare March 15, 2026 15:15
@rite7sh
Copy link
Copy Markdown
Contributor Author

rite7sh commented Mar 15, 2026

@dmitryax done with the requested changes hopefully its good to go :)?

@github-actions
Copy link
Copy Markdown
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Mar 30, 2026
@rite7sh rite7sh force-pushed the kubeletstats-enable-reaggregation branch from ac0b951 to 316012a Compare April 2, 2026 12:30
@rite7sh rite7sh closed this Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[receiver/kubeletstats] Enable re-aggregation feature

3 participants