[exporter/otelarrow] Fix TestStreamUnsupported panic#46964
Open
singhvibhanshu wants to merge 2 commits intoopen-telemetry:mainfrom
Open
[exporter/otelarrow] Fix TestStreamUnsupported panic#46964singhvibhanshu wants to merge 2 commits intoopen-telemetry:mainfrom
singhvibhanshu wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
Signed-off-by: singhvibhanshu <singhvibhanshu@hotmail.com>
singhvibhanshu
changed the title
Contributor
Author
|
/rerun |
singhvibhanshu
changed the title
Contributor
Author
|
Hi there! |
Contributor
Author
|
Hi there! |
Contributor
Author
|
Hi team! |
Contributor
Author
|
Kindly take a look @jmacd, @lquerel, @codeboten when you get a chance |
Contributor
Author
|
@jmacd, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46671
Description:
This fixes a race condition in
TestStreamUnsupportedthat resulted in a panic (unexpected nil stream). If the background stream runner shut down before the test calledmustSendAndWait, the stream evaluated tonil. This updatesmustSendAndWaitto gracefully returnErrStreamRestartinginstead of panicking when the stream isnil.Testing:
Ran
make testandmake lintinexporter/otelarrowexporter/.