[internal/aws/proxy] Migrate from AWS SDK v1 to v2#47244
Merged
andrzej-stencel merged 26 commits intoopen-telemetry:mainfrom Apr 15, 2026
Merged
[internal/aws/proxy] Migrate from AWS SDK v1 to v2#47244andrzej-stencel merged 26 commits intoopen-telemetry:mainfrom
andrzej-stencel merged 26 commits intoopen-telemetry:mainfrom
Conversation
|
|
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
github-actions
bot
requested review from
Aneurysm9,
mxiamxia,
srprash and
wangzlei
mitali-salvi
force-pushed
the
feature/aws-proxy-sdk-v2-migration
branch
2 times, most recently
from
2d9fc25 to
88403eb
Compare
srprash
reviewed
Mar 31, 2026
mitali-salvi
force-pushed
the
feature/aws-proxy-sdk-v2-migration
branch
from
7669a9a to
d22bd92
Compare
Contributor
|
Moving to draft while you work on this, please mark ready for review when CI passes. |
mitali-salvi
force-pushed
the
feature/aws-proxy-sdk-v2-migration
branch
from
d22bd92 to
2dcc158
Compare
This change migrates the internal AWS proxy module from AWS SDK Go v1 to v2, removing dependency on the deprecated AWS SDK v1. Fixes open-telemetry#40461
Extract region detection from getAWSConfigSession into smaller, focused functions for better readability and maintainability.
- Remove unused `implicitGlobalRegion` field from partitionConfig struct - Remove unused `getServiceEndpointFromConfig` function - Fix errorlint: use %w for error wrapping in fmt.Errorf - Fix unused-parameter: rename unused ctx parameters to _ - Fix usetesting: replace context.Background() with t.Context()
…d consolidate proxy functions - Convert getRegionFromEC2Metadata to mockable function variable to prevent real HTTP calls to EC2 IMDS (169.254.169.254) during tests - Export GetProxyAddress and GetProxyURL from awsutil package - Remove duplicate getProxyAddress/getProxyURL from proxy package
- Remove hand-rolled partition table; use sts.NewDefaultEndpointResolverV2() for getServiceEndpoint covering all 8 AWS partitions - Remove duplicate cfg.RetryMaxAttempts and redundant cfg.Region assignment - Replace getPrimaryRegion with prefix-based matching for all partitions - Refactor setupMock to use t.Cleanup() with meaningful variable names - Fix data race in signing tests: use buffered channels + r.Clone() - Replace silent nil-guards with require.NotNil/require.NotEmpty - Expand TestGetServiceEndpoint with iso/isob/isoe/isof/eusc partitions - Remove TestLoadEnvConfigCreds (covered by awsutil package tests) Assisted-by: Claude Opus 4
Aneurysm9
reviewed
Apr 8, 2026
- Fix misleading error message in getRegionFromMetadata: only mentions ECS and EC2 metadata (config/env vars are checked in resolveRegion) - Migrate from deprecated Director to Rewrite in ReverseProxy to address security concern (hop-by-hop headers handled automatically) - Unexport GetProxyAddress and GetProxyURL since they are not used outside the awsutil package
Aneurysm9
reviewed
Apr 9, 2026
Also address round 2 review feedback from Aneurysm9: - Delete unused getProxyAddress/getProxyURL and their tests (dead code) - Simplify Rewrite comment (Director deprecation detail in commit history) - Read from r.In.Body instead of r.Out.Body for hash computation
mitali-salvi
force-pushed
the
feature/aws-proxy-sdk-v2-migration
branch
from
0cb0ee1 to
c35f9bc
Compare
Aneurysm9
approved these changes
Apr 9, 2026
mxiamxia
approved these changes
Apr 10, 2026
|
@mitali-salvi Hey, I was looking at issue #37728. Do you intend to migrate all AWS use cases from v1 to v2? If yes, then I would pick up another issue to work on. Thanks. |
Contributor
Author
|
@atoulme should be ready to review now |
Contributor
Author
|
@andrzej-stencel I would appreciate a review as well :) |
Member
|
/workflow-approve |
paulojmdias
approved these changes
Apr 14, 2026
Member
|
/workflow-approve |
Contributor
Author
|
@codeboten can I get this PR merged please ? :) |
Contributor
|
Thank you for your contribution @mitali-salvi! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates internal/aws/proxy from AWS SDK Go v1 to v2.
Link to tracking issue
Fixes #40461
Related: #37728
Testing
Documentation
No documentation changes needed — test-only fix.