[receiver/oracledb] Exclude collector's own queries from Top Query an…#47381
Open
harshitt13 wants to merge 2 commits intoopen-telemetry:mainfrom
Open
[receiver/oracledb] Exclude collector's own queries from Top Query an…#47381harshitt13 wants to merge 2 commits intoopen-telemetry:mainfrom
harshitt13 wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
…d Query Sample collection Resolves open-telemetry#47366 Signed-off-by: Harshit Kushwaha <find.harshitkushwaha@gmail.com>
harshitt13
requested review from
a team,
atoulme,
crobert-1 and
dmitryax
as code owners
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an observability feedback loop in the
oracledbreceiverwhere the collector's own monitoring queries appear in the collected data for Top Queries and Query Samples.Changes made:
/* otel-collector */to/* otel-collector-ignore */.WHEREclause filter (AND <alias>.SQL_FULLTEXT NOT LIKE '/* otel-collector-ignore */%') tooracleQueryMetricsAndTextSql.tmplandoracleQuerySampleSql.tmpl. This pushes the self-exclusion logic down to the database engine level.oracleQueryPlanSql.tmpl(noWHEREclause filter needed here as it strictly queries byCHILD_ADDRESSvalues already filtered by the above queries).Link to tracking issue
Fixes #47366
Testing
make --no-print-directory -C receiver/oracledbreceiver test(all 74 tests passed).Documentation
chloggen.