[scraper/zookeeper] fix float parsing for zk_avg_latency on ZK 3.7+#47407
Open
vyagh wants to merge 2 commits intoopen-telemetry:mainfrom
Open
[scraper/zookeeper] fix float parsing for zk_avg_latency on ZK 3.7+#47407vyagh wants to merge 2 commits intoopen-telemetry:mainfrom
vyagh wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
|
@antonblock could you please review and approve it |
vyagh
force-pushed
the
fix-zookeeper-avg-latency-float
branch
from
3ce8348 to
e3c58b4
Compare
vyagh
force-pushed
the
fix-zookeeper-avg-latency-float
branch
from
e3c58b4 to
401c642
Compare
|
@antonblock could you please review and approve it |
atoulme
approved these changes
Apr 20, 2026
Contributor
|
@antonblock @akats7 please review as codeowners |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zookeeper 3.7+ reports
zk_avg_latencyas a float (e.g.0.0989), which causesstrconv.ParseIntto fail silently, dropping thezookeeper.latency.avgmetric entirely.Fall back to
strconv.ParseFloatwhenParseIntfails, truncating the result toint64to match the existing metric schema.Fixes #47320